[jboss-jira] [JBoss JIRA] (WFCORE-4170) The vault resource needs to expose a capability that requires the picketbox package
[
https://issues.jboss.org/browse/WFCORE-4170?page=com.atlassian.jira.plugi...
]
Brian Stansberry commented on WFCORE-4170:
------------------------------------------
I wonder if at some point we should revisit not including PB in core. The PB jars
themselves add about 1MB but at this point the core zip is 30MB so this isn't a big
difference, and not shipping it results in ugly hacks. And the galleon layer stuff can
help users reach the key objective of not including it in their dist regardless of what FP
it is shipped in.
One caution though is the org.picketbox module comes with a ton of dependencies most of
which should not be in core even if PB was. Mostly optional ones, and others perhaps could
be.
{code}
<module name="org.picketbox" xmlns="urn:jboss:module:1.5">
<!-- This module is deprecated and subject to being removed in a subsequent
release. -->
<properties>
<property name="jboss.api" value="deprecated"/>
</properties>
<resources>
<resource-root path="picketbox-5.0.3.Final.jar"/>
<resource-root path="picketbox-infinispan-5.0.3.Final.jar"/>
<resource-root path="picketbox-commons-1.0.0.final.jar"/>
</resources>
<dependencies>
<module name="javax.api"/>
<module name="javax.persistence.api" optional="true"/>
<module name="javax.resource.api" optional="true"/>
<module name="javax.security.auth.message.api"
optional="true"/>
<module name="javax.security.jacc.api"/>
<module name="javax.servlet.api"/>
<module name="javax.transaction.api" optional="true"/>
<module name="javax.xml.bind.api" optional="true"/>
<module name="javax.xml.stream.api" optional="true"/>
<module name="org.jboss.logging"/>
<module name="org.infinispan" optional="true"/>
<module name="org.jboss.security.xacml"
optional="true"/>
<module name="org.jboss.modules" optional="true"/>
<module name="sun.jdk"/>
</dependencies>
</module>
{code}
I'm not advocating making this any kind of a priority, particularly if it wouldn't
be simple.
The vault resource needs to expose a capability that requires the
picketbox package
-----------------------------------------------------------------------------------
Key: WFCORE-4170
URL: https://issues.jboss.org/browse/WFCORE-4170
Project: WildFly Core
Issue Type: Bug
Components: Management
Reporter: Brian Stansberry
Assignee: Jeff Mesnil
Priority: Major
The picketbox module is optional in core, but there is no link from configuration to a
hard requirement for PB. The result is Galleon could theoretically provision a server
with a vault in the config but not PB module on the FS. The way to add such a link is via
a capability for vault and the use of
RuntimeCapability.Builder.addAdditionalRequiredPackages.
Note that I think this means the vault feature can't be part of any layer in core, or
at least not a layer that's depended upon by any 'default' core layer. This
is because the PB module will not be part of the core feature pack.
[~jfdenise] FYI; this is a follow up to our conversation earlier today.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)