March 2015 - jbossts-issues - Jboss List Archives

[JBoss JIRA] (JBTM-2353) Compensation handler interceptors should not throw exception, if there is no transaction

by Gytis Trikleris (JIRA)

[ https://issues.jboss.org/browse/JBTM-2353?page=com.atlassian.jira.plugin.... ] Gytis Trikleris updated JBTM-2353: ---------------------------------- Summary: Compensation handler interceptors should not throw exception, if there is no transaction (was: Compensation handler interceptors should not throw exception, if there is not transaction) > Compensation handler interceptors should not throw exception, if there is no transaction > ---------------------------------------------------------------------------------------- > > Key: JBTM-2353 > URL: https://issues.jboss.org/browse/JBTM-2353 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: TXFramework > Reporter: Gytis Trikleris > Assignee: Gytis Trikleris > Fix For: 5.0.5 > > > @TXCompensate, @TXConfirm, and @TxLogged interceptors throw exception, if there is not transaction. However, transaction availability check is also done by @Compensatable interceptor. -- This message was sent by Atlassian JIRA (v6.3.11#6341)

9 years, 8 months

1
0
0 / 0

[JBoss JIRA] (JBTM-2353) Compensation handler interceptors should not throw exception, if there is no transaction

by Gytis Trikleris (JIRA)

[ https://issues.jboss.org/browse/JBTM-2353?page=com.atlassian.jira.plugin.... ] Gytis Trikleris updated JBTM-2353: ---------------------------------- Status: Pull Request Sent (was: Open) Git Pull Request: https://github.com/jbosstm/narayana/pull/816 > Compensation handler interceptors should not throw exception, if there is no transaction > ---------------------------------------------------------------------------------------- > > Key: JBTM-2353 > URL: https://issues.jboss.org/browse/JBTM-2353 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: TXFramework > Reporter: Gytis Trikleris > Assignee: Gytis Trikleris > Fix For: 5.0.5 > > > @TXCompensate, @TXConfirm, and @TxLogged interceptors throw exception, if there is not transaction. However, transaction availability check is also done by @Compensatable interceptor. -- This message was sent by Atlassian JIRA (v6.3.11#6341)

9 years, 8 months

1
0
0 / 0

[JBoss JIRA] (JBTM-2353) Compensation handler interceptors should not throw exception, if there is not transaction

by Gytis Trikleris (JIRA)

Gytis Trikleris created JBTM-2353: ------------------------------------- Summary: Compensation handler interceptors should not throw exception, if there is not transaction Key: JBTM-2353 URL: https://issues.jboss.org/browse/JBTM-2353 Project: JBoss Transaction Manager Issue Type: Bug Components: TXFramework Reporter: Gytis Trikleris Assignee: Gytis Trikleris Fix For: 5.0.5 @TXCompensate, @TXConfirm, and @TxLogged interceptors throw exception, if there is not transaction. However, transaction availability check is also done by @Compensatable interceptor. -- This message was sent by Atlassian JIRA (v6.3.11#6341)

9 years, 8 months

1
0
0 / 0

[JBoss JIRA] (JBTM-2206) Use synchronized HashMaps

by Tom Jenkinson (JIRA)

[ https://issues.jboss.org/browse/JBTM-2206?page=com.atlassian.jira.plugin.... ] Tom Jenkinson commented on JBTM-2206: ------------------------------------- Sure, to be clear what I have proposed is that we need to see 10% for it to be considered an improvement and if we see 3% loss we class it as a degradation. But I have asked Mike to prioritise getting his article and forum post online as it will be easier to discuss it there. > Use synchronized HashMaps > ------------------------- > > Key: JBTM-2206 > URL: https://issues.jboss.org/browse/JBTM-2206 > Project: JBoss Transaction Manager > Issue Type: Sub-task > Components: Transaction Core > Reporter: Jesper Pedersen > Assignee: Michael Musgrove > > Change usage of Hashtable into synchronized HashMap's instead. -- This message was sent by Atlassian JIRA (v6.3.11#6341)

9 years, 8 months

1
0
0 / 0

[JBoss JIRA] (JBTM-2206) Use synchronized HashMaps

by Mark Little (JIRA)

[ https://issues.jboss.org/browse/JBTM-2206?page=com.atlassian.jira.plugin.... ] Mark Little commented on JBTM-2206: ----------------------------------- 0.5% improvement seems way to small, so I'm happy with 10%. My concern is that we should be cautious when making changes in case we introduce bugs (not necessarily in our code but in the routines we add). 10% seems like a good point at which to say we should take a risk. > Use synchronized HashMaps > ------------------------- > > Key: JBTM-2206 > URL: https://issues.jboss.org/browse/JBTM-2206 > Project: JBoss Transaction Manager > Issue Type: Sub-task > Components: Transaction Core > Reporter: Jesper Pedersen > Assignee: Michael Musgrove > > Change usage of Hashtable into synchronized HashMap's instead. -- This message was sent by Atlassian JIRA (v6.3.11#6341)

9 years, 8 months

1
0
0 / 0

[JBoss JIRA] (JBTM-2206) Use synchronized HashMaps

by Michael Musgrove (JIRA)

[ https://issues.jboss.org/browse/JBTM-2206?page=com.atlassian.jira.plugin.... ] Michael Musgrove commented on JBTM-2206: ---------------------------------------- OK, sounds reasonable. I will tweak the job parameters to match that. We can do further tweaks as and when needed. > Use synchronized HashMaps > ------------------------- > > Key: JBTM-2206 > URL: https://issues.jboss.org/browse/JBTM-2206 > Project: JBoss Transaction Manager > Issue Type: Sub-task > Components: Transaction Core > Reporter: Jesper Pedersen > Assignee: Michael Musgrove > > Change usage of Hashtable into synchronized HashMap's instead. -- This message was sent by Atlassian JIRA (v6.3.11#6341)

9 years, 8 months

1
0
0 / 0

[JBoss JIRA] (JBTM-2206) Use synchronized HashMaps

by Tom Jenkinson (JIRA)

[ https://issues.jboss.org/browse/JBTM-2206?page=com.atlassian.jira.plugin.... ] Tom Jenkinson commented on JBTM-2206: ------------------------------------- I suggested 10% improvement should be required for it to be considered as an improvement - but that only 3% degradation would be needed for it to be considered that it is a performance regression. The reason I said 3% is that is the most variance I have seen on jobs that have no material effect on the code and so our environment seems to exhibit about 3% variance. > Use synchronized HashMaps > ------------------------- > > Key: JBTM-2206 > URL: https://issues.jboss.org/browse/JBTM-2206 > Project: JBoss Transaction Manager > Issue Type: Sub-task > Components: Transaction Core > Reporter: Jesper Pedersen > Assignee: Michael Musgrove > > Change usage of Hashtable into synchronized HashMap's instead. -- This message was sent by Atlassian JIRA (v6.3.11#6341)

9 years, 8 months

1
0
0 / 0

[JBoss JIRA] (JBTM-2206) Use synchronized HashMaps

by Michael Musgrove (JIRA)

[ https://issues.jboss.org/browse/JBTM-2206?page=com.atlassian.jira.plugin.... ] Michael Musgrove edited comment on JBTM-2206 at 3/18/15 11:57 AM: ------------------------------------------------------------------ Yes, we will only make the change if we can demonstrate a benefit. That said, the current criteria for a performance improvement/degradation is 10% better/worse, respectively, which may be too ambitious/unambitious, Tom suggests 0.5%. It is also possible that the benchmarks that the PR job runs will not exercise the code changes so it may be necessary for new benchmarks to be added (by us or by whoever raises the PR). The article Tom mentioned will give a fuller description of what and how we benchmark and the criteria for pass/failure. was (Author: mmusgrov): Yes, we will only make the change if we can demonstrate a benefit. That said, the current criteria for a performance improvement/degradation is 10% better/worse, respectively, which may be too ambitiou/unambitious, Tom suggests 0.5%. It is also possible that the benchmarks that the PR job runs will not exercise the code changes so it may be necessary for new benchmarks to be added (by us or by whoever raises the PR). The article Tom mentioned will give a fuller description of what and how we benchmark and the criteria for pass/failure. > Use synchronized HashMaps > ------------------------- > > Key: JBTM-2206 > URL: https://issues.jboss.org/browse/JBTM-2206 > Project: JBoss Transaction Manager > Issue Type: Sub-task > Components: Transaction Core > Reporter: Jesper Pedersen > Assignee: Michael Musgrove > > Change usage of Hashtable into synchronized HashMap's instead. -- This message was sent by Atlassian JIRA (v6.3.11#6341)

9 years, 8 months

1
0
0 / 0

[JBoss JIRA] (JBTM-2206) Use synchronized HashMaps

by Michael Musgrove (JIRA)

[ https://issues.jboss.org/browse/JBTM-2206?page=com.atlassian.jira.plugin.... ] Michael Musgrove edited comment on JBTM-2206 at 3/18/15 11:57 AM: ------------------------------------------------------------------ Yes, we will only make the change if we can demonstrate a benefit. That said, the current criteria for a performance improvement/degradation is 10% better/worse, respectively, which may be too ambitiou/unambitious, Tom suggests 0.5%. It is also possible that the benchmarks that the PR job runs will not exercise the code changes so it may be necessary for new benchmarks to be added (by us or by whoever raises the PR). The article Tom mentioned will give a fuller description of what and how we benchmark and the criteria for pass/failure. was (Author: mmusgrov): Yes, we will only make the change if we can demonstrate a benefit. That said, the current criteria for a performance improvement/degradation is 10% better/worse, respectively, which may be too unambitious, Tom suggests 0.5%. It is also possible that the benchmarks that the PR job runs will not exercise the code changes so it may be necessary for new benchmarks to be added (by us or by whoever raises the PR). The article Tom mentioned will give a fuller description of what and how we benchmark and the criteria for pass/failure. > Use synchronized HashMaps > ------------------------- > > Key: JBTM-2206 > URL: https://issues.jboss.org/browse/JBTM-2206 > Project: JBoss Transaction Manager > Issue Type: Sub-task > Components: Transaction Core > Reporter: Jesper Pedersen > Assignee: Michael Musgrove > > Change usage of Hashtable into synchronized HashMap's instead. -- This message was sent by Atlassian JIRA (v6.3.11#6341)

9 years, 8 months

1
0
0 / 0

[JBoss JIRA] (JBTM-2206) Use synchronized HashMaps

by Michael Musgrove (JIRA)

[ https://issues.jboss.org/browse/JBTM-2206?page=com.atlassian.jira.plugin.... ] Michael Musgrove edited comment on JBTM-2206 at 3/18/15 11:57 AM: ------------------------------------------------------------------ Yes, we will only make the change if we can demonstrate a benefit. That said, the current criteria for a performance improvement/degradation is 10% better/worse, respectively, which may be too unambitious, Tom suggests 0.5%. It is also possible that the benchmarks that the PR job runs will not exercise the code changes so it may be necessary for new benchmarks to be added (by us or by whoever raises the PR). The article Tom mentioned will give a fuller description of what and how we benchmark and the criteria for pass/failure. was (Author: mmusgrov): Yes, we will only make the change if we can demonstrate a benefit. That said, the current criteria for a performance improvement/degradation is 10% better/worse, respectively, which may be too ambitious, Tom suggests 0.5%. It is also possible that the benchmarks that the PR job runs will not exercise the code changes so it may be necessary for new benchmarks to be added (by us or by whoever raises the PR). The article Tom mentioned will give a fuller description of what and how we benchmark and the criteria for pass/failure. > Use synchronized HashMaps > ------------------------- > > Key: JBTM-2206 > URL: https://issues.jboss.org/browse/JBTM-2206 > Project: JBoss Transaction Manager > Issue Type: Sub-task > Components: Transaction Core > Reporter: Jesper Pedersen > Assignee: Michael Musgrove > > Change usage of Hashtable into synchronized HashMap's instead. -- This message was sent by Atlassian JIRA (v6.3.11#6341)

9 years, 8 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

jbossts-issues March 2015