March 2015 - jbossts-issues - Jboss List Archives

[JBoss JIRA] (JBTM-2206) Use synchronized HashMaps

by Michael Musgrove (JIRA)

[ https://issues.jboss.org/browse/JBTM-2206?page=com.atlassian.jira.plugin.... ] Michael Musgrove commented on JBTM-2206: ---------------------------------------- Yes, we will only make the change if we can demonstrate a benefit. That said, the current criteria for a performance improvement/degradation is 10% better/worse, respectively, which may be too ambitious, Tom suggests 0.5%. It is also possible that the benchmarks that the PR job runs will not exercise the code changes so it may be necessary for new benchmarks to be added (by us or by whoever raises the PR). The article Tom mentioned will give a fuller description of what and how we benchmark and the criteria for pass/failure. > Use synchronized HashMaps > ------------------------- > > Key: JBTM-2206 > URL: https://issues.jboss.org/browse/JBTM-2206 > Project: JBoss Transaction Manager > Issue Type: Sub-task > Components: Transaction Core > Reporter: Jesper Pedersen > Assignee: Michael Musgrove > > Change usage of Hashtable into synchronized HashMap's instead. -- This message was sent by Atlassian JIRA (v6.3.11#6341)

9 years, 8 months

1
0
0 / 0

[JBoss JIRA] (JBTM-2206) Use synchronized HashMaps

by Tom Jenkinson (JIRA)

[ https://issues.jboss.org/browse/JBTM-2206?page=com.atlassian.jira.plugin.... ] Tom Jenkinson commented on JBTM-2206: ------------------------------------- Yes - it is. > Use synchronized HashMaps > ------------------------- > > Key: JBTM-2206 > URL: https://issues.jboss.org/browse/JBTM-2206 > Project: JBoss Transaction Manager > Issue Type: Sub-task > Components: Transaction Core > Reporter: Jesper Pedersen > Assignee: Michael Musgrove > > Change usage of Hashtable into synchronized HashMap's instead. -- This message was sent by Atlassian JIRA (v6.3.11#6341)

9 years, 8 months

1
0
0 / 0

[JBoss JIRA] (JBTM-2206) Use synchronized HashMaps

by Mark Little (JIRA)

[ https://issues.jboss.org/browse/JBTM-2206?page=com.atlassian.jira.plugin.... ] Mark Little commented on JBTM-2206: ----------------------------------- I assume the plan is to leave things alone if there is no significant difference? http://www.phrases.org.uk/meanings/if-it-aint-broke-dont-fix-it.html > Use synchronized HashMaps > ------------------------- > > Key: JBTM-2206 > URL: https://issues.jboss.org/browse/JBTM-2206 > Project: JBoss Transaction Manager > Issue Type: Sub-task > Components: Transaction Core > Reporter: Jesper Pedersen > Assignee: Michael Musgrove > > Change usage of Hashtable into synchronized HashMap's instead. -- This message was sent by Atlassian JIRA (v6.3.11#6341)

9 years, 8 months

1
0
0 / 0

[JBoss JIRA] (JBTM-2206) Use synchronized HashMaps

by Tom Jenkinson (JIRA)

[ https://issues.jboss.org/browse/JBTM-2206?page=com.atlassian.jira.plugin.... ] Tom Jenkinson commented on JBTM-2206: ------------------------------------- Mike is preparing a document on how we do our performance testing to share on our dev forum and he will create a discussion around it. The reason I mention that is because it is possible (but unlikely, as one of the tests we use Mike wrote specifically for this purpose) that our suite doesn't exercise the area where the improvement would be found. > Use synchronized HashMaps > ------------------------- > > Key: JBTM-2206 > URL: https://issues.jboss.org/browse/JBTM-2206 > Project: JBoss Transaction Manager > Issue Type: Sub-task > Components: Transaction Core > Reporter: Jesper Pedersen > Assignee: Michael Musgrove > > Change usage of Hashtable into synchronized HashMap's instead. -- This message was sent by Atlassian JIRA (v6.3.11#6341)

9 years, 8 months

1
0
0 / 0

[JBoss JIRA] (JBTM-2206) Use synchronized HashMaps

by Mark Little (JIRA)

[ https://issues.jboss.org/browse/JBTM-2206?page=com.atlassian.jira.plugin.... ] Mark Little commented on JBTM-2206: ----------------------------------- So no perceivable difference at all? > Use synchronized HashMaps > ------------------------- > > Key: JBTM-2206 > URL: https://issues.jboss.org/browse/JBTM-2206 > Project: JBoss Transaction Manager > Issue Type: Sub-task > Components: Transaction Core > Reporter: Jesper Pedersen > Assignee: Michael Musgrove > > Change usage of Hashtable into synchronized HashMap's instead. -- This message was sent by Atlassian JIRA (v6.3.11#6341)

9 years, 8 months

1
0
0 / 0

[JBoss JIRA] (JBTM-2206) Use synchronized HashMaps

by Michael Musgrove (JIRA)

[ https://issues.jboss.org/browse/JBTM-2206?page=com.atlassian.jira.plugin.... ] Michael Musgrove commented on JBTM-2206: ---------------------------------------- The perf profile looks for anything more than a 10% change (regression or improvement). The run did not show any "significant" change. The figures for each performance test were: {code} com.hp.mwtests.ts.arjuna.performance.Performance1.onePhase: 895697.232857 vrs 902345.326032 (change: 0) com.hp.mwtests.ts.arjuna.atomicaction.CheckedActionTest.testThreadActionData: 437838.597325 vrs 430096.956384 (change: 0) com.hp.mwtests.ts.arjuna.atomicaction.CheckedActionTest.testCheckedAction: 32320.338816 vrs 33034.983201 (change: 0) com.arjuna.ats.jta.xa.performance.JTAStoreTests.jtaTest: 90531.981753 vrs 89787.577741 (change: 0) com.hp.mwtests.ts.arjuna.performance.Performance1.twoPhase: 817996.341431 vrs 790490.246540 (change: 0) {code} where the first figure is the benchmark for the code being tested in the PR and the second figure is the figure for the code in the master branch > Use synchronized HashMaps > ------------------------- > > Key: JBTM-2206 > URL: https://issues.jboss.org/browse/JBTM-2206 > Project: JBoss Transaction Manager > Issue Type: Sub-task > Components: Transaction Core > Reporter: Jesper Pedersen > Assignee: Michael Musgrove > > Change usage of Hashtable into synchronized HashMap's instead. -- This message was sent by Atlassian JIRA (v6.3.11#6341)

9 years, 8 months

1
0
0 / 0

[JBoss JIRA] (JBTM-2203) Remove ReentrantLock from StateManager

by Tom Jenkinson (JIRA)

[ https://issues.jboss.org/browse/JBTM-2203?page=com.atlassian.jira.plugin.... ] Tom Jenkinson commented on JBTM-2203: ------------------------------------- Sorry, I was cleaning up the pull queue a little today hence the activity but we aren't in a position to merge these changes yet, hence why we haven't deprecated anything. The changes I made to this Jira this morning are to support investigating the benefits of merging changes in this area. The PR has the "Hold" label on it. The reason I raised a PR is so that our performance runs can work out the benefit. I modified my comment when I realized it was not accurate. > Remove ReentrantLock from StateManager > -------------------------------------- > > Key: JBTM-2203 > URL: https://issues.jboss.org/browse/JBTM-2203 > Project: JBoss Transaction Manager > Issue Type: Sub-task > Components: JTA > Affects Versions: 5.0.2 > Reporter: Michael Musgrove > Assignee: Michael Musgrove > Priority: Minor > Fix For: 5.x.y > > > Remove unused lock from StateManager, and add the access methods to LockManager instead -- This message was sent by Atlassian JIRA (v6.3.11#6341)

9 years, 8 months

1
0
0 / 0

[JBoss JIRA] (JBTM-2203) Remove ReentrantLock from StateManager

by Mark Little (JIRA)

[ https://issues.jboss.org/browse/JBTM-2203?page=com.atlassian.jira.plugin.... ] Mark Little commented on JBTM-2203: ----------------------------------- Hold on ... doesn't this changed the public API of StateManager and LockManager? Whilst the latter is a superset of the previous API, the former isn't and potentially breaks other classes from users that may inherit from StateManager. Did we deprecate as discussed last July? Did we determine what the cost/benefit is of doing this? > Remove ReentrantLock from StateManager > -------------------------------------- > > Key: JBTM-2203 > URL: https://issues.jboss.org/browse/JBTM-2203 > Project: JBoss Transaction Manager > Issue Type: Sub-task > Components: JTA > Affects Versions: 5.0.2 > Reporter: Michael Musgrove > Assignee: Michael Musgrove > Priority: Minor > Fix For: 5.x.y > > > Remove unused lock from StateManager, and add the access methods to LockManager instead -- This message was sent by Atlassian JIRA (v6.3.11#6341)

9 years, 8 months

1
0
0 / 0

[JBoss JIRA] (JBTM-2206) Use synchronized HashMaps

by Tom Jenkinson (JIRA)

[ https://issues.jboss.org/browse/JBTM-2206?page=com.atlassian.jira.plugin.... ] Tom Jenkinson updated JBTM-2206: -------------------------------- Git Pull Request: https://github.com/jbosstm/narayana/pull/807 (was: https://github.com/jbosstm/narayana/pull/679, https://github.com/jbosstm/narayana/pull/794) > Use synchronized HashMaps > ------------------------- > > Key: JBTM-2206 > URL: https://issues.jboss.org/browse/JBTM-2206 > Project: JBoss Transaction Manager > Issue Type: Sub-task > Components: Transaction Core > Reporter: Jesper Pedersen > Assignee: Michael Musgrove > > Change usage of Hashtable into synchronized HashMap's instead. -- This message was sent by Atlassian JIRA (v6.3.11#6341)

9 years, 8 months

1
0
0 / 0

[JBoss JIRA] (JBTM-2203) Remove ReentrantLock from StateManager

by Tom Jenkinson (JIRA)

[ https://issues.jboss.org/browse/JBTM-2203?page=com.atlassian.jira.plugin.... ] Tom Jenkinson edited comment on JBTM-2203 at 3/16/15 8:43 AM: -------------------------------------------------------------- I have pulled the changes to the hashmap into a separate commit and raised a PR for it over on https://github.com/jbosstm/narayana/pull/794 (note it does not have a minor effect on the API of StateManager as the protected state is now of a different type). was (Author: tomjenkinson): I have pulled the changes to the hashmap into a separate commit and raised a PR for it over on https://github.com/jbosstm/narayana/pull/794 (note it does not have an effect on the API of StateManager). > Remove ReentrantLock from StateManager > -------------------------------------- > > Key: JBTM-2203 > URL: https://issues.jboss.org/browse/JBTM-2203 > Project: JBoss Transaction Manager > Issue Type: Sub-task > Components: JTA > Affects Versions: 5.0.2 > Reporter: Michael Musgrove > Assignee: Michael Musgrove > Priority: Minor > Fix For: 5.x.y > > > Remove unused lock from StateManager, and add the access methods to LockManager instead -- This message was sent by Atlassian JIRA (v6.3.11#6341)

9 years, 8 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

jbossts-issues March 2015