[JBoss JIRA] (JBTM-1901) Revert the Blacktie Subsystem
by Amos Feng (JIRA)
Amos Feng created JBTM-1901:
-------------------------------
Summary: Revert the Blacktie Subsystem
Key: JBTM-1901
URL: https://issues.jboss.org/browse/JBTM-1901
Project: JBoss Transaction Manager
Issue Type: Task
Security Level: Public (Everyone can see)
Components: Application Server Integration, BlackTie
Reporter: Amos Feng
Assignee: Amos Feng
Fix For: 5.0.0.M5
we may need to back out the BlackTie subsystem from WildFly as we are not able to commit much time to this now.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 8 months
[JBoss JIRA] (JBTM-1431) LastResourceRecord.shouldAdd allows insertion regardless of order and type info
by RH Bugzilla Integration (JIRA)
[ https://issues.jboss.org/browse/JBTM-1431?page=com.atlassian.jira.plugin.... ]
RH Bugzilla Integration updated JBTM-1431:
------------------------------------------
Bugzilla Update: Perform
Bugzilla References: https://bugzilla.redhat.com/show_bug.cgi?id=1001909
> LastResourceRecord.shouldAdd allows insertion regardless of order and type info
> -------------------------------------------------------------------------------
>
> Key: JBTM-1431
> URL: https://issues.jboss.org/browse/JBTM-1431
> Project: JBoss Transaction Manager
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: Transaction Core
> Affects Versions: 4.17.3
> Reporter: Mark Little
> Assignee: Mark Little
> Fix For: 4.17.9, 5.0.0.M2
>
>
> So looking at the code, LastResource is meant to be ordered last in the intentions list (check topLevelPrepare to see this). However, a quick look at the code in LastResourceRecord shows that there is a bug:
> public boolean shouldAdd (AbstractRecord a)
> {
> if (a.typeIs() == typeIs())
> {
> if (ALLOW_MULTIPLE_LAST_RESOURCES) {
> if (!_disableMLRWarning
> || (_disableMLRWarning && !_issuedWarning)) {
> tsLogger.i18NLogger.warn_lastResource_multipleWarning(a.toString());
> _issuedWarning = true;
> }
> return true;
> }
> else {
> tsLogger.i18NLogger.warn_lastResource_disallow(this.toString(), a.toString());
> return false;
> }
> }
> else
> {
> return true; <------- Here is the bug!
> }
> }
> Basically if the record to be added is not a LastResourceRecord then it gets added immediately, ignoring any further checks on type, order etc. This is wrong.
> And looking back at the code from 6 years ago we see that this was much simpler:
> public boolean shouldAdd (AbstractRecord a)
> {
> return (a.typeIs() == typeIs()) ;
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 8 months
[JBoss JIRA] (JBTM-1431) LastResourceRecord.shouldAdd allows insertion regardless of order and type info
by RH Bugzilla Integration (JIRA)
[ https://issues.jboss.org/browse/JBTM-1431?page=com.atlassian.jira.plugin.... ]
RH Bugzilla Integration commented on JBTM-1431:
-----------------------------------------------
James Livingston <jlivings(a)redhat.com> made a comment on [bug 1002330|https://bugzilla.redhat.com/show_bug.cgi?id=1002330]
+++ This bug was initially created as a clone of Bug #1001909 +++
Due to https://issues.jboss.org/browse/JBTM-1431, it is possible for a last resource (e.g. non-XA resource) to be committed prior to another XA resource, which is unsafe.
This was fixed in master prior to 6.1, but not in a bugfix release so was not pulled into EAP.
--- Additional comment from James Livingston on 2013-08-29 08:36:19 EST ---
Fix backported to 4.17 branch by Tom, https://github.com/jbosstm/narayana/commit/986d7792d2dbcc5d01844a5f2240a3...
> LastResourceRecord.shouldAdd allows insertion regardless of order and type info
> -------------------------------------------------------------------------------
>
> Key: JBTM-1431
> URL: https://issues.jboss.org/browse/JBTM-1431
> Project: JBoss Transaction Manager
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: Transaction Core
> Affects Versions: 4.17.3
> Reporter: Mark Little
> Assignee: Mark Little
> Fix For: 4.17.9, 5.0.0.M2
>
>
> So looking at the code, LastResource is meant to be ordered last in the intentions list (check topLevelPrepare to see this). However, a quick look at the code in LastResourceRecord shows that there is a bug:
> public boolean shouldAdd (AbstractRecord a)
> {
> if (a.typeIs() == typeIs())
> {
> if (ALLOW_MULTIPLE_LAST_RESOURCES) {
> if (!_disableMLRWarning
> || (_disableMLRWarning && !_issuedWarning)) {
> tsLogger.i18NLogger.warn_lastResource_multipleWarning(a.toString());
> _issuedWarning = true;
> }
> return true;
> }
> else {
> tsLogger.i18NLogger.warn_lastResource_disallow(this.toString(), a.toString());
> return false;
> }
> }
> else
> {
> return true; <------- Here is the bug!
> }
> }
> Basically if the record to be added is not a LastResourceRecord then it gets added immediately, ignoring any further checks on type, order etc. This is wrong.
> And looking back at the code from 6 years ago we see that this was much simpler:
> public boolean shouldAdd (AbstractRecord a)
> {
> return (a.typeIs() == typeIs()) ;
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 8 months
[JBoss JIRA] (JBTM-1431) LastResourceRecord.shouldAdd allows insertion regardless of order and type info
by RH Bugzilla Integration (JIRA)
[ https://issues.jboss.org/browse/JBTM-1431?page=com.atlassian.jira.plugin.... ]
RH Bugzilla Integration commented on JBTM-1431:
-----------------------------------------------
James Livingston <jlivings(a)redhat.com> made a comment on [bug 1001909|https://bugzilla.redhat.com/show_bug.cgi?id=1001909]
Fix backported to 4.17 branch by Tom, https://github.com/jbosstm/narayana/commit/986d7792d2dbcc5d01844a5f2240a3...
> LastResourceRecord.shouldAdd allows insertion regardless of order and type info
> -------------------------------------------------------------------------------
>
> Key: JBTM-1431
> URL: https://issues.jboss.org/browse/JBTM-1431
> Project: JBoss Transaction Manager
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: Transaction Core
> Affects Versions: 4.17.3
> Reporter: Mark Little
> Assignee: Mark Little
> Fix For: 4.17.9, 5.0.0.M2
>
>
> So looking at the code, LastResource is meant to be ordered last in the intentions list (check topLevelPrepare to see this). However, a quick look at the code in LastResourceRecord shows that there is a bug:
> public boolean shouldAdd (AbstractRecord a)
> {
> if (a.typeIs() == typeIs())
> {
> if (ALLOW_MULTIPLE_LAST_RESOURCES) {
> if (!_disableMLRWarning
> || (_disableMLRWarning && !_issuedWarning)) {
> tsLogger.i18NLogger.warn_lastResource_multipleWarning(a.toString());
> _issuedWarning = true;
> }
> return true;
> }
> else {
> tsLogger.i18NLogger.warn_lastResource_disallow(this.toString(), a.toString());
> return false;
> }
> }
> else
> {
> return true; <------- Here is the bug!
> }
> }
> Basically if the record to be added is not a LastResourceRecord then it gets added immediately, ignoring any further checks on type, order etc. This is wrong.
> And looking back at the code from 6 years ago we see that this was much simpler:
> public boolean shouldAdd (AbstractRecord a)
> {
> return (a.typeIs() == typeIs()) ;
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 8 months
[JBoss JIRA] (JBTM-1431) LastResourceRecord.shouldAdd allows insertion regardless of order and type info
by RH Bugzilla Integration (JIRA)
[ https://issues.jboss.org/browse/JBTM-1431?page=com.atlassian.jira.plugin.... ]
RH Bugzilla Integration commented on JBTM-1431:
-----------------------------------------------
James Livingston <jlivings(a)redhat.com> changed the Status of [bug 1001909|https://bugzilla.redhat.com/show_bug.cgi?id=1001909] from NEW to POST
> LastResourceRecord.shouldAdd allows insertion regardless of order and type info
> -------------------------------------------------------------------------------
>
> Key: JBTM-1431
> URL: https://issues.jboss.org/browse/JBTM-1431
> Project: JBoss Transaction Manager
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: Transaction Core
> Affects Versions: 4.17.3
> Reporter: Mark Little
> Assignee: Mark Little
> Fix For: 4.17.9, 5.0.0.M2
>
>
> So looking at the code, LastResource is meant to be ordered last in the intentions list (check topLevelPrepare to see this). However, a quick look at the code in LastResourceRecord shows that there is a bug:
> public boolean shouldAdd (AbstractRecord a)
> {
> if (a.typeIs() == typeIs())
> {
> if (ALLOW_MULTIPLE_LAST_RESOURCES) {
> if (!_disableMLRWarning
> || (_disableMLRWarning && !_issuedWarning)) {
> tsLogger.i18NLogger.warn_lastResource_multipleWarning(a.toString());
> _issuedWarning = true;
> }
> return true;
> }
> else {
> tsLogger.i18NLogger.warn_lastResource_disallow(this.toString(), a.toString());
> return false;
> }
> }
> else
> {
> return true; <------- Here is the bug!
> }
> }
> Basically if the record to be added is not a LastResourceRecord then it gets added immediately, ignoring any further checks on type, order etc. This is wrong.
> And looking back at the code from 6 years ago we see that this was much simpler:
> public boolean shouldAdd (AbstractRecord a)
> {
> return (a.typeIs() == typeIs()) ;
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 8 months
[JBoss JIRA] (JBTM-1900) Add test profiles to narayana.sh
by Gytis Trikleris (JIRA)
[ https://issues.jboss.org/browse/JBTM-1900?page=com.atlassian.jira.plugin.... ]
Gytis Trikleris updated JBTM-1900:
----------------------------------
Status: Pull Request Sent (was: Coding In Progress)
Git Pull Request: https://github.com/jbosstm/narayana/pull/416
> Add test profiles to narayana.sh
> --------------------------------
>
> Key: JBTM-1900
> URL: https://issues.jboss.org/browse/JBTM-1900
> Project: JBoss Transaction Manager
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: Build System
> Reporter: Gytis Trikleris
> Assignee: Gytis Trikleris
> Fix For: 5.0.0.M5
>
> Original Estimate: 1 hour
> Remaining Estimate: 1 hour
>
> Take example from narayana multi-job:
> {code}
> if [ "$TESTS" == "MAIN" ]; then
> export NARAYANA_BUILD=1 AS_BUILD=1 NARAYANA_TESTS=1 RTS_AS_TESTS=1 RTS_TESTS=1 JTA_CDI_TESTS=1 TXF_TESTS=0 XTS_TESTS=0 XTS_AS_TESTS=0 txbridge=0 QA_TESTS=0 BLACKTIE=0
> elif [ "$TESTS" == "XTS" ]; then
> export NARAYANA_BUILD=1 AS_BUILD=1 NARAYANA_TESTS=0 RTS_AS_TESTS=0 RTS_TESTS=0 JTA_CDI_TESTS=0 TXF_TESTS=1 XTS_TESTS=1 XTS_AS_TESTS=1 txbridge=1 QA_TESTS=0 BLACKTIE=0
> elif [ "$TESTS" == "QA_JTA" ]; then
> export NARAYANA_BUILD=1 AS_BUILD=1 NARAYANA_TESTS=0 RTS_AS_TESTS=0 RTS_TESTS=0 JTA_CDI_TESTS=0 TXF_TESTS=0 XTS_TESTS=0 XTS_AS_TESTS=0 txbridge=0 QA_TESTS=1 SUN_ORB=1 JAC_ORB=0 QA_TARGET=ci-tests-nojts BLACKTIE=0
> elif [ "$TESTS" == "QA_JTS_JACORB" ]; then
> export NARAYANA_BUILD=1 AS_BUILD=1 NARAYANA_TESTS=0 RTS_AS_TESTS=0 RTS_TESTS=0 JTA_CDI_TESTS=0 TXF_TESTS=0 XTS_TESTS=0 XTS_AS_TESTS=0 txbridge=0 QA_TESTS=1 SUN_ORB=0 JAC_ORB=1 QA_TARGET=ci-jts-tests BLACKTIE=0
> elif [ "$TESTS" == "QA_JTS_JDKORB" ]; then
> export NARAYANA_BUILD=1 AS_BUILD=1 NARAYANA_TESTS=0 RTS_AS_TESTS=0 RTS_TESTS=0 JTA_CDI_TESTS=0 TXF_TESTS=0 XTS_TESTS=0 XTS_AS_TESTS=0 txbridge=0 QA_TESTS=1 SUN_ORB=1 JAC_ORB=0 QA_TARGET=ci-jts-tests BLACKTIE=0
> elif [ "$TESTS" == "BLACKTIE" ]; then
> export NARAYANA_BUILD=1 AS_BUILD=1 NARAYANA_TESTS=0 RTS_AS_TESTS=0 RTS_TESTS=0 JTA_CDI_TESTS=0 TXF_TESTS=0 XTS_TESTS=0 XTS_AS_TESTS=0 txbridge=0 QA_TESTS=0 BLACKTIE=1
> if [ "$label" == "linux64el5" ]; then
> export SKIP_VALGRIND=-Duse.valgrind=false
> fi
> fi
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 8 months
[JBoss JIRA] (JBTM-1900) Add test profiles to narayana.sh
by Gytis Trikleris (JIRA)
[ https://issues.jboss.org/browse/JBTM-1900?focusedWorklogId=12429602&page=... ]
Gytis Trikleris logged work on JBTM-1900:
-----------------------------------------
Author: Gytis Trikleris
Created on: 28/Aug/13 11:48 AM
Start Date: 28/Aug/13 11:47 AM
Worklog Time Spent: 1 hour
Issue Time Tracking
-------------------
Remaining Estimate: 0 minutes (was: 1 hour)
Time Spent: 1 hour
Worklog Id: (was: 12429602)
> Add test profiles to narayana.sh
> --------------------------------
>
> Key: JBTM-1900
> URL: https://issues.jboss.org/browse/JBTM-1900
> Project: JBoss Transaction Manager
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: Build System
> Reporter: Gytis Trikleris
> Assignee: Gytis Trikleris
> Fix For: 5.0.0.M5
>
> Original Estimate: 1 hour
> Time Spent: 1 hour
> Remaining Estimate: 0 minutes
>
> Take example from narayana multi-job:
> {code}
> if [ "$TESTS" == "MAIN" ]; then
> export NARAYANA_BUILD=1 AS_BUILD=1 NARAYANA_TESTS=1 RTS_AS_TESTS=1 RTS_TESTS=1 JTA_CDI_TESTS=1 TXF_TESTS=0 XTS_TESTS=0 XTS_AS_TESTS=0 txbridge=0 QA_TESTS=0 BLACKTIE=0
> elif [ "$TESTS" == "XTS" ]; then
> export NARAYANA_BUILD=1 AS_BUILD=1 NARAYANA_TESTS=0 RTS_AS_TESTS=0 RTS_TESTS=0 JTA_CDI_TESTS=0 TXF_TESTS=1 XTS_TESTS=1 XTS_AS_TESTS=1 txbridge=1 QA_TESTS=0 BLACKTIE=0
> elif [ "$TESTS" == "QA_JTA" ]; then
> export NARAYANA_BUILD=1 AS_BUILD=1 NARAYANA_TESTS=0 RTS_AS_TESTS=0 RTS_TESTS=0 JTA_CDI_TESTS=0 TXF_TESTS=0 XTS_TESTS=0 XTS_AS_TESTS=0 txbridge=0 QA_TESTS=1 SUN_ORB=1 JAC_ORB=0 QA_TARGET=ci-tests-nojts BLACKTIE=0
> elif [ "$TESTS" == "QA_JTS_JACORB" ]; then
> export NARAYANA_BUILD=1 AS_BUILD=1 NARAYANA_TESTS=0 RTS_AS_TESTS=0 RTS_TESTS=0 JTA_CDI_TESTS=0 TXF_TESTS=0 XTS_TESTS=0 XTS_AS_TESTS=0 txbridge=0 QA_TESTS=1 SUN_ORB=0 JAC_ORB=1 QA_TARGET=ci-jts-tests BLACKTIE=0
> elif [ "$TESTS" == "QA_JTS_JDKORB" ]; then
> export NARAYANA_BUILD=1 AS_BUILD=1 NARAYANA_TESTS=0 RTS_AS_TESTS=0 RTS_TESTS=0 JTA_CDI_TESTS=0 TXF_TESTS=0 XTS_TESTS=0 XTS_AS_TESTS=0 txbridge=0 QA_TESTS=1 SUN_ORB=1 JAC_ORB=0 QA_TARGET=ci-jts-tests BLACKTIE=0
> elif [ "$TESTS" == "BLACKTIE" ]; then
> export NARAYANA_BUILD=1 AS_BUILD=1 NARAYANA_TESTS=0 RTS_AS_TESTS=0 RTS_TESTS=0 JTA_CDI_TESTS=0 TXF_TESTS=0 XTS_TESTS=0 XTS_AS_TESTS=0 txbridge=0 QA_TESTS=0 BLACKTIE=1
> if [ "$label" == "linux64el5" ]; then
> export SKIP_VALGRIND=-Duse.valgrind=false
> fi
> fi
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 8 months