[jbossts-issues] [JBoss JIRA] (JBTM-2904) ConnectionManager no longer uses the underlying XADataSource's credentials when none are provided in its Properties

ConnectionManager no longer uses the underlying XADataSource's credentials when none are provided in its Properties ------------------------------------------------------------------------------------------------------------------- Key: JBTM-2904 URL: https://issues.jboss.org/browse/JBTM-2904 Project: JBoss Transaction Manager Issue Type: Bug Affects Versions: 5.5.7.Final Reporter: Andy Wilkinson I believe that [this commit|https://github.com/jbosstm/narayana/commit/789a02b78c8ffe5a7a07960...] has introduced a regression in how {{ConnectionManager}} handles credentials. Previously, if the {{Properties}} contained an {{XADataSource}} and no credentials, the data source's default credentials would be used, i.e. {{XADataSource.getXAConnection()}} would be called by {{ProvidedXADataSourceConnection}}. With the aforelinked change, {{ConnectionManager}} now coerces {{null}} credentials to empty strings. As a result {{XADataSource.getXAConnection(String, String)}} is called by {{ProvidedXADataSourceConnection}} with the empty credentials.