[jbossts-issues] [JBoss JIRA] Commented: (JBTM-419) Hardcoded "1.5" java version check in com\arjuna\ats\internal\jdbc\ConnectionManager.java won't work on Java 1.6
[
https://jira.jboss.org/jira/browse/JBTM-419?page=com.atlassian.jira.plugi...
]
Jonathan Halliday commented on JBTM-419:
----------------------------------------
unless you try to use them "as if" they were JDBC4
implementations.
Ahh, ok, you basically want to exploit a weakness in the type checking system, claiming
the implementation of the interface is complete when actually it's not.. Since the
classloader does not verify that you'll get away with it... except if you
inadvertently use a JDBC4 method you get a runtime rather than compile time error
(java.lang.AbstractMethodError). That seems like a bit of a quality control nightmare and
not really something we want to encourage even though it is technically feasible. Besides
which the JIRA is about the compile time version check rather than a runtime issue, thus
resolution does mean either not building the driver or implementing the full JDBC4 API for
JDK 6. Which fortunately is almost done...
Hardcoded "1.5" java version check in
com\arjuna\ats\internal\jdbc\ConnectionManager.java won't work on Java 1.6
----------------------------------------------------------------------------------------------------------------
Key: JBTM-419
URL: https://jira.jboss.org/jira/browse/JBTM-419
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: JTA
Affects Versions: 4.4.0.GA
Environment: Sun's J2SE DevKit 1.6u10
Reporter: Sergey Proskurnya
Assignee: Jonathan Halliday
Priority: Minor
Fix For: 4.7.0
There is a hard-coded version check in com.arjuna.ats.internal.jdbc.ConnectionManager in
"create (String dbUrl, Properties info)" method:
--------------------------------------------------------------------------------------------------------------------------
...
line 116:
if(System.getProperty("java.specification.version").equals("1.5"))
{
// the 1.5 (JDBC3) wrapper version is loaded dynamically because classloading
// it on earlier versions of the platform is not possible.
....
}
--------------------------------------------------------------------------------------------------------------------------
That piece of code will not work correctly on Java 1.6, because
System.getProperty("java.specification.version") returns "1.6" on Java
1.6.
It is needed to parse the result of
System.getProperty("java.specification.version") and compare major and minor
versions separately.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira