[jbossts-issues] [JBoss JIRA] (JBTM-1810) If the XAResourceRecoveryHelper returns a different XAResource and isSameRM does not function correctly for the resource manager it is possible that the _xidScans can contain older XAResources which may cache old Xids so should not be scanned

If the XAResourceRecoveryHelper returns a different XAResource and isSameRM does not function correctly for the resource manager it is possible that the _xidScans can contain older XAResources which may cache old Xids so should not be scanned -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- Key: JBTM-1810 URL: https://issues.jboss.org/browse/JBTM-1810 Project: JBoss Transaction Manager Issue Type: Bug Security Level: Public(Everyone can see) Components: JTA Affects Versions: 4.17.4 Reporter: Tom Jenkinson Assignee: Tom Jenkinson Priority: Critical Fix For: 4.17.5, 5.0.0.M4 This is evidenced in linked bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=979058 I can see in the logs on 979058 that we are trying to call rollback on the same XID, this is coming from an older XAResource reference that has cached the Xid reference in the original scan but wasn't expired by the stale check. It appears to have been re introduced after 4.17.3.Final as that version does not exhibit the same behavior. Fix is to revert most of: https://github.com/jbosstm/narayana/commit/fc1ce60d8b7cd0f0193350537775b1...