[jbossts-issues] [JBoss JIRA] Closed: (JBTM-377) XAResourceRecord save/restore state insufficiently paranoid

XAResourceRecord save/restore state insufficiently paranoid ----------------------------------------------------------- Key: JBTM-377 URL: http://jira.jboss.com/jira/browse/JBTM-377 Project: JBoss Transaction Manager Issue Type: Bug Security Level: Public(Everyone can see) Components: JTA Implementation, Recovery Affects Versions: 4.3.0.GA Reporter: Jonathan Halliday Assigned To: Mark Little Fix For: 4.4.CR2 The XAResourceRecord save state method writes meta-data into the objectstore before attempting to Serialize and write the actual bytes for an XAResource that it believes, on the basis of it implementing the marker interface, is Serializable. If the serialization fails at runtime, the objectstore record is left in an invalid state and can cause the recovery pass to blow up in horrible ways. We should obtain the byte[] representing the serialized resource before writing anything to the record so that this does not occur. If serialization fails, the record will therefore be useless but at least not otherwise broken.