[jbossts-issues] [JBoss JIRA] Commented: (JBTM-353) XAResourceRecovery has wrong conceptual model

XAResourceRecovery has wrong conceptual model --------------------------------------------- Key: JBTM-353 URL: http://jira.jboss.com/jira/browse/JBTM-353 Project: JBoss Transaction Manager Issue Type: Task Security Level: Public(Everyone can see) Components: Recovery Affects Versions: 4.3.0.GA Reporter: Jonathan Halliday Assigned To: Jonathan Halliday Fix For: 4.4.CR1 XAResourceRecovery is based on an iterator model: public boolean initialise (String p) throws SQLException; public boolean hasMoreResources (); public XAResource getXAResource () throws SQLException; However, XAResourceRecovery instances are created once at recovery manager startup. This means there is only ever one recovery pass that actually returns resources. On later passes the iterator is exhausted and returns nothing. This is the wrong model. XAResources are not individual entities in need of recovery. Rather they are entities from which a list of Xids in need of recovery can be retrieved. If the configuration of the underlying system does not change, the set of XAResources should remain constant over time, being one per known resource manager. On each recovery pass the list of in-doubt Xids returned by a recover scan on that resource many change. The model should change to follow that used by JCA ResourceAdapter: public XAResource[] getXAResources() The recovery pass would then obtain and walk the array rather than using the current iterator model. Additionally the exception types should be more generic. SQLException assumes the resource manager is a db, which may not be the case. This will also impact the recovery examples, which implement this interface.