4:30 p.m.
incorrect cleanup registration causes memory leak
-------------------------------------------------
Key: JBTM-770
URL: https://jira.jboss.org/browse/JBTM-770
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: JTS
Affects Versions: 4.6.1.CP06, 4.12.0
Reporter: Jonathan Halliday
Assignee: Mark Little
Fix For: 4.13.0, 4.6.1.CP08
jts.TransactionImple constructors attempt to optimize the cleanup callback needed to
remove entries from _transactions, bypassing the ORB for interposition scenarios:
theTx = (TwoPhaseCoordinator) BasicAction.Current();
if (theTx != null) {
theTx.addSynchronization(new LocalCleanupSynchronization(this));
} else {
registerSynchronization(new CleanupSynchronization(this));
}
Unfortunately this does not work and leads to memory leaks on _transactions in certain
cases. Specifically, where theTx is a ServerTransaction (i.e. extends
ArjunaTransactionImple, which extends TwoPhaseCoordinator), the callbacks run (by
ArjunaTransactionImple.do[Before|After]Completion()) are those in
ArjunaTransactionImple._syncs, not the masked ones in TwoPhaseCoordinator._syncs. Thus
using TwoPhaseCoordinator.addSynchronization registers a callback which is never invoked.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:43 p.m.
New subject: [JBoss JIRA] Work started: (JBTM-770) incorrect cleanup registration causes memory leak
[
https://jira.jboss.org/browse/JBTM-770?page=com.atlassian.jira.plugin.sys...
]
Work on JBTM-770 started by Mark Little.
incorrect cleanup registration causes memory leak
-------------------------------------------------
Key: JBTM-770
URL: https://jira.jboss.org/browse/JBTM-770
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: JTS
Affects Versions: 4.12.0, 4.6.1.CP06
Reporter: Jonathan Halliday
Assignee: Mark Little
Fix For: 4.13.0, 4.6.1.CP08
jts.TransactionImple constructors attempt to optimize the cleanup callback needed to
remove entries from _transactions, bypassing the ORB for interposition scenarios:
theTx = (TwoPhaseCoordinator) BasicAction.Current();
if (theTx != null) {
theTx.addSynchronization(new LocalCleanupSynchronization(this));
} else {
registerSynchronization(new CleanupSynchronization(this));
}
Unfortunately this does not work and leads to memory leaks on _transactions in certain
cases. Specifically, where theTx is a ServerTransaction (i.e. extends
ArjunaTransactionImple, which extends TwoPhaseCoordinator), the callbacks run (by
ArjunaTransactionImple.do[Before|After]Completion()) are those in
ArjunaTransactionImple._syncs, not the masked ones in TwoPhaseCoordinator._syncs. Thus
using TwoPhaseCoordinator.addSynchronization registers a callback which is never invoked.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:21 p.m.
New subject: [JBoss JIRA] Resolved: (JBTM-770) incorrect cleanup registration causes memory leak
[
https://jira.jboss.org/browse/JBTM-770?page=com.atlassian.jira.plugin.sys...
]
Mark Little resolved JBTM-770.
------------------------------
Resolution: Done
ArjunaTransactionImple before/afterCompletion should be calling TwoPhaseCoordinator
equivalents too.
incorrect cleanup registration causes memory leak
-------------------------------------------------
Key: JBTM-770
URL: https://jira.jboss.org/browse/JBTM-770
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: JTS
Affects Versions: 4.12.0, 4.6.1.CP06
Reporter: Jonathan Halliday
Assignee: Mark Little
Fix For: 4.13.0, 4.6.1.CP08
jts.TransactionImple constructors attempt to optimize the cleanup callback needed to
remove entries from _transactions, bypassing the ORB for interposition scenarios:
theTx = (TwoPhaseCoordinator) BasicAction.Current();
if (theTx != null) {
theTx.addSynchronization(new LocalCleanupSynchronization(this));
} else {
registerSynchronization(new CleanupSynchronization(this));
}
Unfortunately this does not work and leads to memory leaks on _transactions in certain
cases. Specifically, where theTx is a ServerTransaction (i.e. extends
ArjunaTransactionImple, which extends TwoPhaseCoordinator), the callbacks run (by
ArjunaTransactionImple.do[Before|After]Completion()) are those in
ArjunaTransactionImple._syncs, not the masked ones in TwoPhaseCoordinator._syncs. Thus
using TwoPhaseCoordinator.addSynchronization registers a callback which is never invoked.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:21 p.m.
New subject: [JBoss JIRA] Assigned: (JBTM-770) incorrect cleanup registration causes memory leak
[
https://jira.jboss.org/browse/JBTM-770?page=com.atlassian.jira.plugin.sys...
]
Mark Little reassigned JBTM-770:
--------------------------------
Assignee: Jonathan Halliday (was: Mark Little)
Assigning to Jonathan so he can apply to CP and then close on both branches.
incorrect cleanup registration causes memory leak
-------------------------------------------------
Key: JBTM-770
URL: https://jira.jboss.org/browse/JBTM-770
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: JTS
Affects Versions: 4.12.0, 4.6.1.CP06
Reporter: Jonathan Halliday
Assignee: Jonathan Halliday
Fix For: 4.13.0, 4.6.1.CP08
jts.TransactionImple constructors attempt to optimize the cleanup callback needed to
remove entries from _transactions, bypassing the ORB for interposition scenarios:
theTx = (TwoPhaseCoordinator) BasicAction.Current();
if (theTx != null) {
theTx.addSynchronization(new LocalCleanupSynchronization(this));
} else {
registerSynchronization(new CleanupSynchronization(this));
}
Unfortunately this does not work and leads to memory leaks on _transactions in certain
cases. Specifically, where theTx is a ServerTransaction (i.e. extends
ArjunaTransactionImple, which extends TwoPhaseCoordinator), the callbacks run (by
ArjunaTransactionImple.do[Before|After]Completion()) are those in
ArjunaTransactionImple._syncs, not the masked ones in TwoPhaseCoordinator._syncs. Thus
using TwoPhaseCoordinator.addSynchronization registers a callback which is never invoked.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:16 p.m.
New subject: [JBoss JIRA] Closed: (JBTM-770) incorrect cleanup registration causes memory leak
[
https://jira.jboss.org/browse/JBTM-770?page=com.atlassian.jira.plugin.sys...
]
Jonathan Halliday closed JBTM-770.
----------------------------------
backport done.
incorrect cleanup registration causes memory leak
-------------------------------------------------
Key: JBTM-770
URL: https://jira.jboss.org/browse/JBTM-770
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: JTS
Affects Versions: 4.12.0, 4.6.1.CP06
Reporter: Jonathan Halliday
Assignee: Jonathan Halliday
Fix For: 4.13.0, 4.6.1.CP08
jts.TransactionImple constructors attempt to optimize the cleanup callback needed to
remove entries from _transactions, bypassing the ORB for interposition scenarios:
theTx = (TwoPhaseCoordinator) BasicAction.Current();
if (theTx != null) {
theTx.addSynchronization(new LocalCleanupSynchronization(this));
} else {
registerSynchronization(new CleanupSynchronization(this));
}
Unfortunately this does not work and leads to memory leaks on _transactions in certain
cases. Specifically, where theTx is a ServerTransaction (i.e. extends
ArjunaTransactionImple, which extends TwoPhaseCoordinator), the callbacks run (by
ArjunaTransactionImple.do[Before|After]Completion()) are those in
ArjunaTransactionImple._syncs, not the masked ones in TwoPhaseCoordinator._syncs. Thus
using TwoPhaseCoordinator.addSynchronization registers a callback which is never invoked.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:41 a.m.
New subject: [JBoss JIRA] (JBTM-770) incorrect cleanup registration causes memory leak
[
https://issues.jboss.org/browse/JBTM-770?page=com.atlassian.jira.plugin.s...
]
Justin Bertram commented on JBTM-770:
-------------------------------------
I noticed a couple of changes were made to trunk (i.e. 35422 and 35425) after the
back-port to JBOSSTS_4_6_1_GA_CP was done. Should those be back-ported as well?
incorrect cleanup registration causes memory leak
-------------------------------------------------
Key: JBTM-770
URL: https://issues.jboss.org/browse/JBTM-770
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: JTS
Affects Versions: 4.12.0, 4.6.1.CP06
Reporter: Jonathan Halliday
Assignee: Jonathan Halliday
Fix For: 4.13.0, 4.6.1.CP08
jts.TransactionImple constructors attempt to optimize the cleanup callback needed to
remove entries from _transactions, bypassing the ORB for interposition scenarios:
theTx = (TwoPhaseCoordinator) BasicAction.Current();
if (theTx != null) {
theTx.addSynchronization(new LocalCleanupSynchronization(this));
} else {
registerSynchronization(new CleanupSynchronization(this));
}
Unfortunately this does not work and leads to memory leaks on _transactions in certain
cases. Specifically, where theTx is a ServerTransaction (i.e. extends
ArjunaTransactionImple, which extends TwoPhaseCoordinator), the callbacks run (by
ArjunaTransactionImple.do[Before|After]Completion()) are those in
ArjunaTransactionImple._syncs, not the masked ones in TwoPhaseCoordinator._syncs. Thus
using TwoPhaseCoordinator.addSynchronization registers a callback which is never invoked.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:05 p.m.
New subject: [JBoss JIRA] (JBTM-770) incorrect cleanup registration causes memory leak
[
https://issues.jboss.org/browse/JBTM-770?page=com.atlassian.jira.plugin.s...
]
Jonathan Halliday commented on JBTM-770:
----------------------------------------
IIRC mark's original 'fix' on trunk was buggy. I fixed the backport version on
the fly, but mark took two subsequent attempts to apply the same fix to trunk. Take the
patch using the single commit on the 4.6.1 branch as your source, that single change set
should be equivalent to applying all three of the trunk changes in order.
incorrect cleanup registration causes memory leak
-------------------------------------------------
Key: JBTM-770
URL: https://issues.jboss.org/browse/JBTM-770
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: JTS
Affects Versions: 4.12.0, 4.6.1.CP06
Reporter: Jonathan Halliday
Assignee: Jonathan Halliday
Fix For: 4.13.0, 4.6.1.CP08
jts.TransactionImple constructors attempt to optimize the cleanup callback needed to
remove entries from _transactions, bypassing the ORB for interposition scenarios:
theTx = (TwoPhaseCoordinator) BasicAction.Current();
if (theTx != null) {
theTx.addSynchronization(new LocalCleanupSynchronization(this));
} else {
registerSynchronization(new CleanupSynchronization(this));
}
Unfortunately this does not work and leads to memory leaks on _transactions in certain
cases. Specifically, where theTx is a ServerTransaction (i.e. extends
ArjunaTransactionImple, which extends TwoPhaseCoordinator), the callbacks run (by
ArjunaTransactionImple.do[Before|After]Completion()) are those in
ArjunaTransactionImple._syncs, not the masked ones in TwoPhaseCoordinator._syncs. Thus
using TwoPhaseCoordinator.addSynchronization registers a callback which is never invoked.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:41 p.m.
New subject: [JBoss JIRA] (JBTM-770) incorrect cleanup registration causes memory leak
[
https://issues.jboss.org/browse/JBTM-770?page=com.atlassian.jira.plugin.s...
]
Justin Bertram commented on JBTM-770:
-------------------------------------
Thanks, Jonathan. I'm concerned with line 1650 that was changed in revision 35425 on
trunk that is different from the corresponding line (i.e. 1736) on JBOSSTS_4_6_1_GA_CP.
Can you comment on this difference? Which branch is correct? Or perhaps did this change
get associated with this JIRA illegitimately?
incorrect cleanup registration causes memory leak
-------------------------------------------------
Key: JBTM-770
URL: https://issues.jboss.org/browse/JBTM-770
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: JTS
Affects Versions: 4.12.0, 4.6.1.CP06
Reporter: Jonathan Halliday
Assignee: Jonathan Halliday
Fix For: 4.13.0, 4.6.1.CP08
jts.TransactionImple constructors attempt to optimize the cleanup callback needed to
remove entries from _transactions, bypassing the ORB for interposition scenarios:
theTx = (TwoPhaseCoordinator) BasicAction.Current();
if (theTx != null) {
theTx.addSynchronization(new LocalCleanupSynchronization(this));
} else {
registerSynchronization(new CleanupSynchronization(this));
}
Unfortunately this does not work and leads to memory leaks on _transactions in certain
cases. Specifically, where theTx is a ServerTransaction (i.e. extends
ArjunaTransactionImple, which extends TwoPhaseCoordinator), the callbacks run (by
ArjunaTransactionImple.do[Before|After]Completion()) are those in
ArjunaTransactionImple._syncs, not the masked ones in TwoPhaseCoordinator._syncs. Thus
using TwoPhaseCoordinator.addSynchronization registers a callback which is never invoked.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:22 p.m.
New subject: [JBoss JIRA] (JBTM-770) incorrect cleanup registration causes memory leak
[
https://issues.jboss.org/browse/JBTM-770?page=com.atlassian.jira.plugin.s...
]
Jonathan Halliday commented on JBTM-770:
----------------------------------------
Actually they are both wrong, but the bug in the 4.6.1 version is not relevant to AS use
cases.
problem = !super.afterCompletion(myStatus == Status.StatusCommitted ?
ActionStatus.COMMITTED : ActionStatus.ABORTED);
incorrectly ignores the prior value of problem, such that an exception won't be thrown
in some cases where it should be. However, since ServerTransaction just throws it away
anyhow that's not a big issue.
problem = problem || !super.afterCompletion(myStatus == Status.StatusCommitted ?
ActionStatus.COMMITTED : ActionStatus.ABORTED);
attempts to preserve the prior value of problem, but fails to account for short circuit
boolean evaluation. As a result the parent afterCompletions won't be called in some
cases, which is more serious.
The correct form is arguably
boolean superProblem = !super.afterCompletion(myStatus == Status.StatusCommitted ?
ActionStatus.COMMITTED : ActionStatus.ABORTED);
problem = problem || superProblem
incorrect cleanup registration causes memory leak
-------------------------------------------------
Key: JBTM-770
URL: https://issues.jboss.org/browse/JBTM-770
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: JTS
Affects Versions: 4.12.0, 4.6.1.CP06
Reporter: Jonathan Halliday
Assignee: Jonathan Halliday
Fix For: 4.13.0, 4.6.1.CP08
jts.TransactionImple constructors attempt to optimize the cleanup callback needed to
remove entries from _transactions, bypassing the ORB for interposition scenarios:
theTx = (TwoPhaseCoordinator) BasicAction.Current();
if (theTx != null) {
theTx.addSynchronization(new LocalCleanupSynchronization(this));
} else {
registerSynchronization(new CleanupSynchronization(this));
}
Unfortunately this does not work and leads to memory leaks on _transactions in certain
cases. Specifically, where theTx is a ServerTransaction (i.e. extends
ArjunaTransactionImple, which extends TwoPhaseCoordinator), the callbacks run (by
ArjunaTransactionImple.do[Before|After]Completion()) are those in
ArjunaTransactionImple._syncs, not the masked ones in TwoPhaseCoordinator._syncs. Thus
using TwoPhaseCoordinator.addSynchronization registers a callback which is never invoked.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:25 a.m.
New subject: [JBoss JIRA] (JBTM-770) incorrect cleanup registration causes memory leak
[
https://issues.jboss.org/browse/JBTM-770?page=com.atlassian.jira.plugin.s...
]
Jonathan Halliday reopened JBTM-770:
------------------------------------
incorrect cleanup registration causes memory leak
-------------------------------------------------
Key: JBTM-770
URL: https://issues.jboss.org/browse/JBTM-770
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: JTS
Affects Versions: 4.12.0, 4.6.1.CP06
Reporter: Jonathan Halliday
Assignee: Jonathan Halliday
Fix For: 4.13.0, 4.6.1.CP08
jts.TransactionImple constructors attempt to optimize the cleanup callback needed to
remove entries from _transactions, bypassing the ORB for interposition scenarios:
theTx = (TwoPhaseCoordinator) BasicAction.Current();
if (theTx != null) {
theTx.addSynchronization(new LocalCleanupSynchronization(this));
} else {
registerSynchronization(new CleanupSynchronization(this));
}
Unfortunately this does not work and leads to memory leaks on _transactions in certain
cases. Specifically, where theTx is a ServerTransaction (i.e. extends
ArjunaTransactionImple, which extends TwoPhaseCoordinator), the callbacks run (by
ArjunaTransactionImple.do[Before|After]Completion()) are those in
ArjunaTransactionImple._syncs, not the masked ones in TwoPhaseCoordinator._syncs. Thus
using TwoPhaseCoordinator.addSynchronization registers a callback which is never invoked.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:35 a.m.
New subject: [JBoss JIRA] (JBTM-770) incorrect cleanup registration causes memory leak
[
https://issues.jboss.org/browse/JBTM-770?page=com.atlassian.jira.plugin.s...
]
Jonathan Halliday updated JBTM-770:
-----------------------------------
Fix Version/s: 4.6.1.CP13
4.15.4
5.0.0.M2
incorrect cleanup registration causes memory leak
-------------------------------------------------
Key: JBTM-770
URL: https://issues.jboss.org/browse/JBTM-770
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: JTS
Affects Versions: 4.12.0, 4.6.1.CP06
Reporter: Jonathan Halliday
Assignee: Jonathan Halliday
Fix For: 4.13.0, 4.6.1.CP08, 4.6.1.CP13, 4.15.4, 5.0.0.M2
jts.TransactionImple constructors attempt to optimize the cleanup callback needed to
remove entries from _transactions, bypassing the ORB for interposition scenarios:
theTx = (TwoPhaseCoordinator) BasicAction.Current();
if (theTx != null) {
theTx.addSynchronization(new LocalCleanupSynchronization(this));
} else {
registerSynchronization(new CleanupSynchronization(this));
}
Unfortunately this does not work and leads to memory leaks on _transactions in certain
cases. Specifically, where theTx is a ServerTransaction (i.e. extends
ArjunaTransactionImple, which extends TwoPhaseCoordinator), the callbacks run (by
ArjunaTransactionImple.do[Before|After]Completion()) are those in
ArjunaTransactionImple._syncs, not the masked ones in TwoPhaseCoordinator._syncs. Thus
using TwoPhaseCoordinator.addSynchronization registers a callback which is never invoked.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:35 a.m.
New subject: [JBoss JIRA] (JBTM-770) incorrect cleanup registration causes memory leak
[
https://issues.jboss.org/browse/JBTM-770?page=com.atlassian.jira.plugin.s...
]
Jonathan Halliday resolved JBTM-770.
------------------------------------
Resolution: Done
Unified afterCompletion problem handling across all active branches.
incorrect cleanup registration causes memory leak
-------------------------------------------------
Key: JBTM-770
URL: https://issues.jboss.org/browse/JBTM-770
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: JTS
Affects Versions: 4.12.0, 4.6.1.CP06
Reporter: Jonathan Halliday
Assignee: Jonathan Halliday
Fix For: 4.6.1.CP13, 4.15.4, 5.0.0.M2, 4.6.1.CP08, 4.13.0
jts.TransactionImple constructors attempt to optimize the cleanup callback needed to
remove entries from _transactions, bypassing the ORB for interposition scenarios:
theTx = (TwoPhaseCoordinator) BasicAction.Current();
if (theTx != null) {
theTx.addSynchronization(new LocalCleanupSynchronization(this));
} else {
registerSynchronization(new CleanupSynchronization(this));
}
Unfortunately this does not work and leads to memory leaks on _transactions in certain
cases. Specifically, where theTx is a ServerTransaction (i.e. extends
ArjunaTransactionImple, which extends TwoPhaseCoordinator), the callbacks run (by
ArjunaTransactionImple.do[Before|After]Completion()) are those in
ArjunaTransactionImple._syncs, not the masked ones in TwoPhaseCoordinator._syncs. Thus
using TwoPhaseCoordinator.addSynchronization registers a callback which is never invoked.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:37 a.m.
New subject: [JBoss JIRA] (JBTM-770) incorrect cleanup registration causes memory leak
[
https://issues.jboss.org/browse/JBTM-770?page=com.atlassian.jira.plugin.s...
]
Jonathan Halliday closed JBTM-770.
----------------------------------
incorrect cleanup registration causes memory leak
-------------------------------------------------
Key: JBTM-770
URL: https://issues.jboss.org/browse/JBTM-770
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: JTS
Affects Versions: 4.12.0, 4.6.1.CP06
Reporter: Jonathan Halliday
Assignee: Jonathan Halliday
Fix For: 4.13.0, 4.6.1.CP08, 4.6.1.CP13, 4.15.4, 5.0.0.M2
jts.TransactionImple constructors attempt to optimize the cleanup callback needed to
remove entries from _transactions, bypassing the ORB for interposition scenarios:
theTx = (TwoPhaseCoordinator) BasicAction.Current();
if (theTx != null) {
theTx.addSynchronization(new LocalCleanupSynchronization(this));
} else {
registerSynchronization(new CleanupSynchronization(this));
}
Unfortunately this does not work and leads to memory leaks on _transactions in certain
cases. Specifically, where theTx is a ServerTransaction (i.e. extends
ArjunaTransactionImple, which extends TwoPhaseCoordinator), the callbacks run (by
ArjunaTransactionImple.do[Before|After]Completion()) are those in
ArjunaTransactionImple._syncs, not the masked ones in TwoPhaseCoordinator._syncs. Thus
using TwoPhaseCoordinator.addSynchronization registers a callback which is never invoked.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:52 p.m.
New subject: [JBoss JIRA] (JBTM-770) incorrect cleanup registration causes memory leak
[
https://issues.jboss.org/browse/JBTM-770?page=com.atlassian.jira.plugin.s...
]
Tom Jenkinson updated JBTM-770:
-------------------------------
Fix Version/s: 4.17.0
(was: 5.0.0.M2)
incorrect cleanup registration causes memory leak
-------------------------------------------------
Key: JBTM-770
URL: https://issues.jboss.org/browse/JBTM-770
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: JTS
Affects Versions: 4.12.0, 4.6.1.CP06
Reporter: Jonathan Halliday
Assignee: Jonathan Halliday
Fix For: 4.13.0, 4.6.1.CP08, 4.6.1.CP13, 4.16.0.Beta1, 4.17.0
jts.TransactionImple constructors attempt to optimize the cleanup callback needed to
remove entries from _transactions, bypassing the ORB for interposition scenarios:
theTx = (TwoPhaseCoordinator) BasicAction.Current();
if (theTx != null) {
theTx.addSynchronization(new LocalCleanupSynchronization(this));
} else {
registerSynchronization(new CleanupSynchronization(this));
}
Unfortunately this does not work and leads to memory leaks on _transactions in certain
cases. Specifically, where theTx is a ServerTransaction (i.e. extends
ArjunaTransactionImple, which extends TwoPhaseCoordinator), the callbacks run (by
ArjunaTransactionImple.do[Before|After]Completion()) are those in
ArjunaTransactionImple._syncs, not the masked ones in TwoPhaseCoordinator._syncs. Thus
using TwoPhaseCoordinator.addSynchronization registers a callback which is never invoked.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:52 p.m.
New subject: [JBoss JIRA] (JBTM-770) incorrect cleanup registration causes memory leak
[
https://issues.jboss.org/browse/JBTM-770?page=com.atlassian.jira.plugin.s...
]
Tom Jenkinson reopened JBTM-770:
--------------------------------
incorrect cleanup registration causes memory leak
-------------------------------------------------
Key: JBTM-770
URL: https://issues.jboss.org/browse/JBTM-770
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: JTS
Affects Versions: 4.12.0, 4.6.1.CP06
Reporter: Jonathan Halliday
Assignee: Jonathan Halliday
Fix For: 4.13.0, 4.6.1.CP08, 4.6.1.CP13, 4.16.0.Beta1, 5.0.0.M2
jts.TransactionImple constructors attempt to optimize the cleanup callback needed to
remove entries from _transactions, bypassing the ORB for interposition scenarios:
theTx = (TwoPhaseCoordinator) BasicAction.Current();
if (theTx != null) {
theTx.addSynchronization(new LocalCleanupSynchronization(this));
} else {
registerSynchronization(new CleanupSynchronization(this));
}
Unfortunately this does not work and leads to memory leaks on _transactions in certain
cases. Specifically, where theTx is a ServerTransaction (i.e. extends
ArjunaTransactionImple, which extends TwoPhaseCoordinator), the callbacks run (by
ArjunaTransactionImple.do[Before|After]Completion()) are those in
ArjunaTransactionImple._syncs, not the masked ones in TwoPhaseCoordinator._syncs. Thus
using TwoPhaseCoordinator.addSynchronization registers a callback which is never invoked.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:54 p.m.
New subject: [JBoss JIRA] (JBTM-770) incorrect cleanup registration causes memory leak
[
https://issues.jboss.org/browse/JBTM-770?page=com.atlassian.jira.plugin.s...
]
Tom Jenkinson closed JBTM-770.
------------------------------
Resolution: Done
incorrect cleanup registration causes memory leak
-------------------------------------------------
Key: JBTM-770
URL: https://issues.jboss.org/browse/JBTM-770
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: JTS
Affects Versions: 4.12.0, 4.6.1.CP06
Reporter: Jonathan Halliday
Assignee: Jonathan Halliday
Fix For: 4.17.0, 4.16.0.Beta1, 4.6.1.CP13, 4.6.1.CP08, 4.13.0
jts.TransactionImple constructors attempt to optimize the cleanup callback needed to
remove entries from _transactions, bypassing the ORB for interposition scenarios:
theTx = (TwoPhaseCoordinator) BasicAction.Current();
if (theTx != null) {
theTx.addSynchronization(new LocalCleanupSynchronization(this));
} else {
registerSynchronization(new CleanupSynchronization(this));
}
Unfortunately this does not work and leads to memory leaks on _transactions in certain
cases. Specifically, where theTx is a ServerTransaction (i.e. extends
ArjunaTransactionImple, which extends TwoPhaseCoordinator), the callbacks run (by
ArjunaTransactionImple.do[Before|After]Completion()) are those in
ArjunaTransactionImple._syncs, not the masked ones in TwoPhaseCoordinator._syncs. Thus
using TwoPhaseCoordinator.addSynchronization registers a callback which is never invoked.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4199
days inactive
5007
days old
jbossts-issues@lists.jboss.org
15 comments
9 participants
participants (9)
-
Jonathan Halliday (Closed) (JIRA) -
Jonathan Halliday (Commented) (JIRA)
-
Jonathan Halliday (JIRA)
-
Jonathan Halliday (Reopened) (JIRA)
-
Jonathan Halliday (Resolved) (JIRA)
-
Jonathan Halliday (Updated) (JIRA)
-
Justin Bertram (Commented) (JIRA)
-
Mark Little (JIRA)
-
Tom Jenkinson (JIRA)