[jbossts-issues] [JBoss JIRA] (JBTM-770) incorrect cleanup registration causes memory leak

incorrect cleanup registration causes memory leak ------------------------------------------------- Key: JBTM-770 URL: https://issues.jboss.org/browse/JBTM-770 Project: JBoss Transaction Manager Issue Type: Bug Security Level: Public(Everyone can see) Components: JTS Affects Versions: 4.12.0, 4.6.1.CP06 Reporter: Jonathan Halliday Assignee: Jonathan Halliday Fix For: 4.13.0, 4.6.1.CP08, 4.6.1.CP13, 4.15.4, 5.0.0.M2 jts.TransactionImple constructors attempt to optimize the cleanup callback needed to remove entries from _transactions, bypassing the ORB for interposition scenarios: theTx = (TwoPhaseCoordinator) BasicAction.Current(); if (theTx != null) { theTx.addSynchronization(new LocalCleanupSynchronization(this)); } else { registerSynchronization(new CleanupSynchronization(this)); } Unfortunately this does not work and leads to memory leaks on _transactions in certain cases. Specifically, where theTx is a ServerTransaction (i.e. extends ArjunaTransactionImple, which extends TwoPhaseCoordinator), the callbacks run (by ArjunaTransactionImple.do[Before|After]Completion()) are those in ArjunaTransactionImple._syncs, not the masked ones in TwoPhaseCoordinator._syncs. Thus using TwoPhaseCoordinator.addSynchronization registers a callback which is never invoked.