Author: psakar
Date: 2014-02-24 04:51:06 -0500 (Mon, 24 Feb 2014)
New Revision: 18410
Modified:
stack/cxf/trunk/modules/testsuite/cxf-tests/src/test/java/org/jboss/test/ws/jaxws/cxf/udp/UDPEndpointAPITestCase.java
Log:
[JBWS-3721] Fixing testcase - improve readability
Modified:
stack/cxf/trunk/modules/testsuite/cxf-tests/src/test/java/org/jboss/test/ws/jaxws/cxf/udp/UDPEndpointAPITestCase.java
===================================================================
---
stack/cxf/trunk/modules/testsuite/cxf-tests/src/test/java/org/jboss/test/ws/jaxws/cxf/udp/UDPEndpointAPITestCase.java 2014-02-24
03:34:56 UTC (rev 18409)
+++
stack/cxf/trunk/modules/testsuite/cxf-tests/src/test/java/org/jboss/test/ws/jaxws/cxf/udp/UDPEndpointAPITestCase.java 2014-02-24
09:51:06 UTC (rev 18410)
@@ -63,7 +63,7 @@
public void testClientSide() throws Exception
{
if (!isProperNetworkSetup()) {
- System.out.println("Skipping broadcast test: no non-loopback IPv4 interface
available");
+ System.out.println("Skipping broadcast test: no non-loopback IPv4 interface
available"); //IPv6 does not support broadcast, so some IPv4 nonloopback interface
with broacast is required
return;
}
Bus bus = BusFactory.newInstance().createBus();
@@ -88,22 +88,15 @@
private boolean isProperNetworkSetup() throws Exception {
Enumeration<NetworkInterface> interfaces =
NetworkInterface.getNetworkInterfaces();
- int count = 0;
while (interfaces.hasMoreElements())
{
NetworkInterface networkInterface = interfaces.nextElement();
- if (!networkInterface.isUp() || networkInterface.isLoopback() ||
!isBroadcastAddressAvailable(networkInterface))
+ if (networkInterface.isUp() && !networkInterface.isLoopback() &&
isBroadcastAddressAvailable(networkInterface))
{
- continue;
+ return true;
}
- count++;
}
- if (count == 0)
- {
- //no non-loopbacks, cannot do broadcasts
- return false;
- }
- return true;
+ return false;
}
private boolean isBroadcastAddressAvailable(NetworkInterface networkInterface) {