[richfaces-svn-commits] JBoss Rich Faces SVN: r21533 - in trunk/core: impl/src/main/java/org/richfaces/application/push/impl and 1 other directory.

Author: nbelaevski Date: 2011-02-08 08:52:29 -0500 (Tue, 08 Feb 2011) New Revision: 21533 Modified: trunk/core/api/src/main/java/org/richfaces/application/push/Session.java trunk/core/impl/src/main/java/org/richfaces/application/push/impl/AbstractSession.java trunk/core/impl/src/main/java/org/richfaces/application/push/impl/AtmospherePushHandler.java trunk/core/impl/src/main/java/org/richfaces/application/push/impl/SessionManagerImpl.java Log: - Push session refactoring - Added missing Request.suspend for push https://issues.jboss.org/browse/RF-10457 Modified: trunk/core/api/src/main/java/org/richfaces/application/push/Session.java =================================================================== --- trunk/core/api/src/main/java/org/richfaces/application/push/Session.java 2011-02-08 13:24:19 UTC (rev 21532) +++ trunk/core/api/src/main/java/org/richfaces/application/push/Session.java 2011-02-08 13:52:29 UTC (rev 21533) @@ -51,6 +51,4 @@ public void invalidate(); - public void destroy(); - } Modified: trunk/core/impl/src/main/java/org/richfaces/application/push/impl/AbstractSession.java =================================================================== --- trunk/core/impl/src/main/java/org/richfaces/application/push/impl/AbstractSession.java 2011-02-08 13:24:19 UTC (rev 21532) +++ trunk/core/impl/src/main/java/org/richfaces/application/push/impl/AbstractSession.java 2011-02-08 13:52:29 UTC (rev 21533) @@ -26,6 +26,7 @@ import org.richfaces.application.push.Request; import org.richfaces.application.push.Session; import org.richfaces.application.push.SessionManager; +import org.richfaces.application.push.impl.SessionManagerImpl.DestroyableSession; import org.richfaces.log.Logger; import org.richfaces.log.RichfacesLogger; @@ -33,7 +34,7 @@ * @author Nick Belaevski * */ -public abstract class AbstractSession implements Session { +public abstract class AbstractSession implements Session, DestroyableSession { private static final Logger LOGGER = RichfacesLogger.APPLICATION.getLogger(); Modified: trunk/core/impl/src/main/java/org/richfaces/application/push/impl/AtmospherePushHandler.java =================================================================== --- trunk/core/impl/src/main/java/org/richfaces/application/push/impl/AtmospherePushHandler.java 2011-02-08 13:24:19 UTC (rev 21532) +++ trunk/core/impl/src/main/java/org/richfaces/application/push/impl/AtmospherePushHandler.java 2011-02-08 13:52:29 UTC (rev 21533) @@ -96,7 +96,8 @@ resp.setContentType("text/plain"); try { - session.connect(createRequest(resource, session)); + Request request = createRequest(resource, session); + request.suspend(); } catch (Exception e) { // TODO Auto-generated catch block e.printStackTrace(); Modified: trunk/core/impl/src/main/java/org/richfaces/application/push/impl/SessionManagerImpl.java =================================================================== --- trunk/core/impl/src/main/java/org/richfaces/application/push/impl/SessionManagerImpl.java 2011-02-08 13:24:19 UTC (rev 21532) +++ trunk/core/impl/src/main/java/org/richfaces/application/push/impl/SessionManagerImpl.java 2011-02-08 13:52:29 UTC (rev 21533) @@ -40,13 +40,21 @@ private static final Logger LOGGER = RichfacesLogger.APPLICATION.getLogger(); + interface DestroyableSession { + + public void destroy(); + + } + private final class SessionsExpirationRunnable implements Runnable { public void run() { while (true) { try { Session session = sessionQueue.take(); sessionMap.remove(session.getId()); - session.destroy(); + if (session instanceof DestroyableSession) { + ((DestroyableSession) session).destroy(); + } } catch (InterruptedException e) { LOGGER.error(e.getMessage(), e); } @@ -75,7 +83,9 @@ for (Iterator<Session> sessionsItr = sessionMap.values().iterator(); sessionsItr.hasNext(); ) { Session session = sessionsItr.next(); - session.destroy(); + if (session instanceof DestroyableSession) { + ((DestroyableSession) session).destroy(); + } } }