[richfaces-svn-commits] JBoss Rich Faces SVN: r34 - trunk/richfaces/datascroller/src/main/java/org/richfaces/component.
Author: d.bulahov
Date: 2007-03-07 10:48:00 -0500 (Wed, 07 Mar 2007)
New Revision: 34
Modified:
trunk/richfaces/datascroller/src/main/java/org/richfaces/component/UIDatascroller.java
Log:
Code Review
Modified:
trunk/richfaces/datascroller/src/main/java/org/richfaces/component/UIDatascroller.java
===================================================================
---
trunk/richfaces/datascroller/src/main/java/org/richfaces/component/UIDatascroller.java 2007-03-07
12:50:41 UTC (rev 33)
+++
trunk/richfaces/datascroller/src/main/java/org/richfaces/component/UIDatascroller.java 2007-03-07
15:48:00 UTC (rev 34)
@@ -358,13 +358,13 @@
* @return int
*/
public int getRowCount() {
- //TODO nick -> alex - scrollable models can return -1 here
+ //xxx nick -> alex - scrollable models can return -1 here
//let's implement "dychotomic" discovery
// setPage(1)... if isPageAvailable() setPage(2) then 4, 8, etc.
// setPage() { setRowIndex(pageIdx * rows); }
// isPageAvailable() { return isRowAvailable() }
- return getUIData().getRowCount();
- //return BinarySearch(getUIData());
+ //return getUIData().getRowCount();
+ return BinarySearch(getUIData());
}
@@ -373,7 +373,7 @@
int n=1;
int k=2;
for (;;){
- Data.setRows(k-1);
+ Data.setRowIndex(k-1);
if (Data.isRowAvailable()){
n=k;
k=k*2;
@@ -384,10 +384,9 @@
}
- while (n < k) {
- //int kk = (int)Math.round((n + k)/ 2 + 0.5) - 1;
- int kk = (int)Math.round((n + k)/ 2);
- Data.setRows(kk-1);
+ while (n < k) {
+ int kk = (int)Math.round((n + k)/ 2)+1;
+ Data.setRowIndex(kk-1);
if (Data.isRowAvailable()){
n = kk;
}
@@ -397,7 +396,7 @@
}
- Data.setRows(k-1);
+ Data.setRowIndex(k-1);
if (Data.isRowAvailable()){
return k;
}