On 28 Jun 2007, at 12:35, Tom Fennelly wrote:
Mark Little wrote:
> The problem with revamping is that you never know where to stop or
> you could be opening up a can of worms. I think Kev hinted at this
> yesterday.
Shotgun Surgery - that was moi
OK. I knew I'd seen it somewhere ;-)
> So although I'd be +1 to fixing these if it makes an
appreciable
> difference to build time, I'd -1 if that means spending the next
> week or so working on build scripts and the knock-on effect that
> has on everyone else while it's going on and after it's
"complete".
Know what you mean... I'd leave it altogether until after the 4.2
release, at which point you'll probably want to leave it
forever ;-) Personally I feel there's only one real solution to
this and that's a rework, but I'm sure others will disagree and
push for more patching :-)
If the patch is too much effort (more than an hour, say), then I
agree with you: let's leave it.
>
> I can put up with a 21 minute build. If you guys are at the 7
> minute level (new machines ;-) then I'm not sure it's a big impact
> on what you're doing in terms of build time.
It's a pain in the ass, but ... role on 5.0 and maven2 :-)
+1
Mark.
>
> Mark.
>
>
> On 28 Jun 2007, at 12:22, Tom Fennelly wrote:
>
>> If we were going to spend time on the build scripts, I'd vote for
>> looking at ways to simplify them altogether rather than patching
>> them more with timers etc. I think once we simplify them, we'll
>> be in a better position to sort out issues around making it run
>> quicker.
>>
>> The product/build.xml has 33 targets in it >:o . As I see it,
>> the whole thing is overly hierarchical with build.xml files at
>> nearly every level + separate build.xml files for testing etc.
>> Many of the property names are so long that it becomes very
>> difficult to distinguish between them. I think we're overly
>> fixated with trying to make the build scripts super intelligent
>> ala "I want to be able to run any target and have the build
>> figure out what else needs to be run" resulting in every target
>> being dependent on every other target up and down the build.
>>
>> Sorry for going on a bit. It's just that our build is something
>> that drives me bats.
>>
>> KISS :-*
>>
>> T.
>>
>>
>> Mark Little wrote:
>>> I'd +1 on fixing this up if it can dramatically reduce build
>>> times. Any idea what we might get it down to? I seem to recall
>>> it used to take about 7 minutes on my "old" box :-(
>>>
>>> Mark.
>>>
>>>
>>> On 28 Jun 2007, at 11:55, Kevin Conner wrote:
>>>
>>>> Kevin Conner wrote:
>>>>> As I said, I will go through it tonight and make sure it is
>>>>> correct :)
>>>>
>>>> I went through the build files and tidied them up but this is
>>>> not the
>>>> reason for the long build time. It appears that a number of
>>>> targets are
>>>> being called more than once, caused by the build files
>>>> traversing their
>>>> targets horizontally and vertically.
>>>>
>>>> There are a number of tasks which can handle this, javac
>>>> springs to
>>>> mind, but the majority of them do not. The normal way of
>>>> handling these
>>>> types of issue is to create a timestamp file when the
>>>> particular target
>>>> executes. This timestamp file can then be used, in conjunction
>>>> with the
>>>> target requirements, to determine whether the target needs to
>>>> be executed.
>>>>
>>>> This could be used to shorten the build cycle, especially for
>>>> repeat
>>>> invocations (i.e. rerunning tests).
>>>>
>>>> Does anyone feel that this is something worth implementing at
>>>> this stage?
>>>>
>>>> Kev
>>>>
>>>> P.S. I am sharing wireless atm so may not get any replies until
>>>> tomorrow :)
>>>>
>>>> --
>>>> JBoss, a Division of Red Hat
>>>> Registered Address: Red Hat UK Ltd, Amberley Place, 107-111
>>>> Peascod
>>>> Street, Windsor, Berkshire,
>>>> SI4 1TE, United Kingdom.
>>>> Registered in UK and Wales under Company Registration No. 3798903
>>>> Directors: Michael Cunningham (USA), Charlie Peters (USA) and
>>>> David
>>>> Owens (Ireland)
>>>> _______________________________________________
>>>> esb-dev mailing list
>>>> esb-dev(a)lists.jboss.org <mailto:esb-dev@lists.jboss.org>
>>>>
https://lists.jboss.org/mailman/listinfo/esb-dev
>>>
>>> ----
>>>
>>> Mark Little
>>> mlittle(a)redhat.com <mailto:mlittle@redhat.com>
>>>
>>> JBoss, a Division of Red Hat
>>> Registered Address: Red Hat UK Ltd, Amberley Place, 107-111
>>> Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom.
>>> Registered in UK and Wales under Company Registration No.
>>> 3798903 Directors: Michael Cunningham (USA), Charlie Peters
>>> (USA) and David Owens (Ireland)
>>>
>>>
>>>
>>>
>>
>> --
>> Red Hat:
>> Registered Address: Red Hat Ltd, Brian O' Donnell and Partners,
>> 62 Merrion Square, Dublin 2, Ireland.
>> Registered in the Companies Registration Office, Parnell House,
>> 14 Parnell Square, Dublin 1, Ireland, at No. 304873
>> Directors: Charlie Peters (USA), Michael Cunningham (USA). David
>> Owens, Brendan Lane
>>
>
> ----
>
> Mark Little
> mlittle(a)redhat.com <mailto:mlittle@redhat.com>
>
> JBoss, a Division of Red Hat
> Registered Address: Red Hat UK Ltd, Amberley Place, 107-111
> Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom.
> Registered in UK and Wales under Company Registration No. 3798903
> Directors: Michael Cunningham (USA), Charlie Peters (USA) and
> David Owens (Ireland)
>
>
>
>
--
Red Hat:
Registered Address: Red Hat Ltd, Brian O' Donnell and Partners, 62
Merrion Square, Dublin 2, Ireland.
Registered in the Companies Registration Office, Parnell House, 14
Parnell Square, Dublin 1, Ireland, at No. 304873
Directors: Charlie Peters (USA), Michael Cunningham (USA). David
Owens, Brendan Lane
----
Mark Little
mlittle(a)redhat.com
JBoss, a Division of Red Hat
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire,
SI4 1TE, United Kingdom.
Registered in UK and Wales under Company Registration No. 3798903
Directors: Michael Cunningham (USA), Charlie Peters (USA) and David
Owens (Ireland)