Hello all, Please provide beginner guide for learn hibernate. Thanks in advance. -- Thanks Brajesh Patel _______________________________________________ hibernate-dev mailing list hibernate-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev

Hi, guys, while I was fixing some bug in hibernate tools I looked through some hibernate code. And it seems to me that hibernate is not ready in some cases for quoted identifiers. Here I would like to highlight some potentially weak places in key class org.hibernate.mapping.Table. It doesn't ready for quoted catalog identifiers. There are (catalog, schema, name) fields and (schemaQuoted,quoted). There is no "catalogQuoted", but probably it should be. The static method qualify() in most cases used to generate unique key and cache some data. It is used in such way: String key = Table.qualify(catalog, schema, name); and it is a potentially(non-unique) problem if there are names with dots. "catalog.my.schema.table" = "catalog.my"."schema"."table" or "catalog"."my.schema"."table". I didn't find any usage of Table#isSchemaQuoted(), and DatabaseMetadata#getTableMetadata(..., isQuoted) called with Table#isQuoted() parameter. Perhaps there should be isQuoted = Table#isQuoted() || Table#isSchemaQuoted() || Table#isCatalogQuoted() ? Dmitry Geraskov. _______________________________________________ hibernate-dev mailing list hibernate-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev

missing attachement? /max On Sep 30, 2010, at 15:01, Steve Ebersole wrote: > True enough. Attached is the code I developed for Hibernate 4 to handle > this better. Care to gander? > > > On Thu, 2010-09-30 at 15:09 +0300, Dmitry Geraskov wrote: >> Hi, guys, >> while I was fixing some bug in hibernate tools I looked through some >> hibernate code. >> And it seems to me that hibernate is not ready in some cases for quoted >> identifiers. >> >> Here I would like to highlight some potentially weak places in key class >> org.hibernate.mapping.Table. >> It doesn't ready for quoted catalog identifiers. >> There are (catalog, schema, name) fields and (schemaQuoted,quoted). >> There is no "catalogQuoted", but probably it should be. >> The static method qualify() in most cases used to generate unique key >> and cache some data. It is used in such way: >> >> String key = Table.qualify(catalog, schema, name); >> and it is a potentially(non-unique) problem if there are names with dots. >> "catalog.my.schema.table" = "catalog.my"."schema"."table" or >> "catalog"."my.schema"."table". >> >> I didn't find any usage of Table#isSchemaQuoted(), and >> DatabaseMetadata#getTableMetadata(..., isQuoted) called with >> Table#isQuoted() parameter. Perhaps there should be >> isQuoted = Table#isQuoted() || Table#isSchemaQuoted() || >> Table#isCatalogQuoted() ? >> >> Dmitry Geraskov. >> _______________________________________________ >> hibernate-dev mailing list >> hibernate-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/hibernate-dev > > -- > Steve Ebersole <steve(a)hibernate.org&gt; > http://hibernate.org > _______________________________________________ > hibernate-dev mailing list > hibernate-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev

Hmm a few other people said they did not get them either. Trying again... On Thu, 2010-09-30 at 10:37 -0500, Steve Ebersole wrote: > ? > > They came back through to me. > > On Thu, 2010-09-30 at 17:21 +0200, Max Rydahl Andersen wrote: > > missing attachement? > > > > /max > > > > On Sep 30, 2010, at 15:01, Steve Ebersole wrote: > > > > > True enough. Attached is the code I developed for Hibernate 4 to handle > > > this better. Care to gander? > > > > > > > > > On Thu, 2010-09-30 at 15:09 +0300, Dmitry Geraskov wrote: > > >> Hi, guys, > > >> while I was fixing some bug in hibernate tools I looked through some > > >> hibernate code. > > >> And it seems to me that hibernate is not ready in some cases for quoted > > >> identifiers. > > >> > > >> Here I would like to highlight some potentially weak places in key class > > >> org.hibernate.mapping.Table. > > >> It doesn't ready for quoted catalog identifiers. > > >> There are (catalog, schema, name) fields and (schemaQuoted,quoted). > > >> There is no "catalogQuoted", but probably it should be. > > >> The static method qualify() in most cases used to generate unique key > > >> and cache some data. It is used in such way: > > >> > > >> String key = Table.qualify(catalog, schema, name); > > >> and it is a potentially(non-unique) problem if there are names with dots. > > >> "catalog.my.schema.table" = "catalog.my"."schema"."table" or > > >> "catalog"."my.schema"."table". > > >> > > >> I didn't find any usage of Table#isSchemaQuoted(), and > > >> DatabaseMetadata#getTableMetadata(..., isQuoted) called with > > >> Table#isQuoted() parameter. Perhaps there should be > > >> isQuoted = Table#isQuoted() || Table#isSchemaQuoted() || > > >> Table#isCatalogQuoted() ? > > >> > > >> Dmitry Geraskov. > > >> _______________________________________________ > > >> hibernate-dev mailing list > > >> hibernate-dev(a)lists.jboss.org > > >> https://lists.jboss.org/mailman/listinfo/hibernate-dev > > > > > > -- > > > Steve Ebersole <steve(a)hibernate.org&gt; > > > http://hibernate.org > > > _______________________________________________ > > > hibernate-dev mailing list > > > hibernate-dev(a)lists.jboss.org > > > https://lists.jboss.org/mailman/listinfo/hibernate-dev > > >

Got them this time. Looks like quoting is done all good there. Looking at it reminded me of http://opensource.atlassian.com/projects/hibernate/browse/HHH-1476 The problem of the separators actually having to be dialect controlled and even in some cases schema can be skipped resulting in catalog..table. Worth covering ?

> I'd like to figure out if this could be determined by looking at the > DatabaseMetaData before making the Dialects have to specify this. With > the Dialects its just another thing we need to "keep in synch". Not > sure if you saw my comments in ObjectName wrt DatabaseMetaData, but > those 2 were just the start of my investigation into this. Ok, saw it now. I'm eery to requiring databasemetadata access as part of the Table model since I (at least until now) have been using them extensively without wanting to require a running db...(which is not a requirement today).

I'd like to figure out if this could be determined by looking at the DatabaseMetaData before making the Dialects have to specify this. With the Dialects its just another thing we need to "keep in synch". Not sure if you saw my comments in ObjectName wrt DatabaseMetaData, but those 2 were just the start of my investigation into this.

>> I'd like to figure out if this could be determined by looking at the >> DatabaseMetaData before making the Dialects have to specify this. With >> the Dialects its just another thing we need to "keep in synch". Not >> sure if you saw my comments in ObjectName wrt DatabaseMetaData, but >> those 2 were just the start of my investigation into this. > > Sorry if I misunderstood or if it was discussed before, but when using > DatabaseMetaData, it's always wise to have a fall back to the Dialect, > in case the driver returns wrong information. For instance, the Sybase > 15 JDBC4 driver returns a wrong value for getIdentifierQuoteString() > (see https://jira.jboss.org/browse/JBPAPP-4661). > Totally agreed....I guess the question is though if that is going to part of what we today call Dialect or something else (If i follow Steve's comments right)

The vast majority of databases out there have more or less decent JDBC drivers. So forcing every single Dialect to reproduce information that is already correctly available to us because of a few *known* slackers seems silly. Why can't the majority of Dialect's say "you know what... you can already get this information via the driver's DatabaseMataData; go look there"? Thats all I'm saying.

So because Sybase has crappy JDBC drivers (ok thats a tad harsh, but making a point...) we need to penalize every Dialect developer into duplicating this information?

For something like this, here is what I would propose... 1) public interface ObjectNameRenderer { public String render(OjectName objectName); } 2) Dialect { ... ObjectNameRenderer getObjectNameRenderer() { return TrustMetaDataObjectNameRenderer.INSTANCE; } } And also allow one to be plugged in via "config", which would take precedence if present.