Change commit messages?
by Steve Ebersole
Anyone know how to change commit messages? Trying to merge in a pull
request where they did not reference the jira key in their commit messages
--
steve(a)hibernate.org
http://hibernate.org
12 years, 3 months
Hibernate Developer Weekly IRC Meeting - 1/10
by Steve Ebersole
the jbott logging bot was not around today, so i just captured the
discussion an have attached it here.
Essentially:
1) 4.0.1 release on 4/11
2) after 4.0.1: (a) rename repo; (b) branch 4.0
3) 3.6.10 in 4 weeks (2/8) along with 4.0.2 or 4.1.0
4) intructions on handling repo rename to follow
--
steve(a)hibernate.org
http://hibernate.org
12 years, 3 months
hibernate-infinispan
by Steve Ebersole
We have been having intermittent failures with the hibernate-infinispan
module. Yesterday's upgrade to the latest Infinispan version seems to
exacerbate this condition; at least the CI builds are failing routinely now.
I think we either need to spend some time cleaning up whatever leads to
the intermittent-ness or we do "something else" to isolate the build
from it (move this to a separate, dedicated repo; etc).
--
steve(a)hibernate.org
http://hibernate.org
12 years, 3 months
[HV] ThreadLocal in ValidatorImpl
by Hardy Ferentschik
Hi,
I was thinking about https://hibernate.onjira.com/browse/HV-439 which basically also means a
refactoring of the current ValidatorImpl.
One thing I noticed is that we start at one of the public Bean Validation methods and then
create different context (e.g. ValueContext, ValidationConext) which we can passing around
all the time, creating quite long method parameter lists.
Would it be a good idea to introduce a ThreadLocal here and pass the context information this way?
It would definitely clean up the methods signatures. Thoughts?
--Hardy
12 years, 3 months
HHH-5024 : MappedSuperclass and Static Metamodel Generator
by Steve Ebersole
There is definitely an issue here. The code in HEM is just wrong. I am
not familiar enough with the code/spec here in regards to static
metamodel generation to determine the appropriate fix on my own.
The model in question there is essentially:
@MappedSuperclass
abstract class AbstractAttribute {
protected String key;
protected String value;
public abstract String getOwner();
@Column(name = "attribute_key")
public String getKey() { return key; }
@Column(name = "attribute_value")
public String getValue() { return value; }
// setters
}
then we have:
@Entity
public class ProductAttribute extends AbstractAttribute {
private String owner;
@Id @Column(name = "owner")
public String getOwner() { return owner; }
@Id @Column(name = "attribute_key")
public String getKey() { return key; }
// setters
}
The attributes in question are the 2 (key,owner) that get overridden in
the subclass. We end up with a mismatch.
The metamodel generator does:
@StaticMetamodel(AbstractAttribute.class)
public abstract class AbstractAttribute_ {
public static volatile SingularAttribute<AbstractAttribute, Integer> owner;
public static volatile SingularAttribute<AbstractAttribute, String> value;
public static volatile SingularAttribute<AbstractAttribute, String> key;
}
@StaticMetamodel(ProductAttribute.class)
public abstract class ProductAttribute_ extends AbstractAttribute_ {
}
In the type system however only value shows up as "declared" by
AbstractAttribute. These other 2 show up as being declared by
ProductAttribute, presumably because that is where there ultimate
metadata is defined.
I think the metamodel is defined correctly, but then that leaves a
question as to how we handle that for the type system
(org.hibernate.mapping.MappedSuperclass).
--
steve(a)hibernate.org
http://hibernate.org
12 years, 3 months
org.hibernate.test.locking.LockModeTest failures
by Gail Badner
I pulled from master and now I'm getting 3 test failures for org.hibernate.test.locking.LockModeTest:
- testLegacyCriteria()
- testLegacyCriteriaAliasSpecific()
- testQuery()
All fail due to:
org.hibernate.testing.junit4.FailureExpectedHandler$FailureExpectedTestPassedException: Test marked as FailureExpected, but did not fail
Also in the test report:
<system-err><![CDATA[Exception in thread "Thread-8" java.lang.AssertionError: Unexpected error type testing pessimistic locking : java.lang.NullPoin
terException
at org.junit.Assert.fail(Assert.java:91)
at org.hibernate.test.locking.LockModeTest$1.execute(LockModeTest.java:223)
at org.hibernate.testing.async.ExecutableAdapter.run(ExecutableAdapter.java:45)
at java.lang.Thread.run(Thread.java:662)
Exception in thread "Thread-9" java.lang.AssertionError: Unexpected error type testing pessimistic locking : java.lang.NullPointerException
at org.junit.Assert.fail(Assert.java:91)
at org.hibernate.test.locking.LockModeTest$1.execute(LockModeTest.java:223)
at org.hibernate.testing.async.ExecutableAdapter.run(ExecutableAdapter.java:45)
at java.lang.Thread.run(Thread.java:662)
Exception in thread "Thread-10" java.lang.AssertionError: Unexpected error type testing pessimistic locking : java.lang.NullPointerException
at org.junit.Assert.fail(Assert.java:91)
at org.hibernate.test.locking.LockModeTest$1.execute(LockModeTest.java:223)
at org.hibernate.testing.async.ExecutableAdapter.run(ExecutableAdapter.java:45)
at java.lang.Thread.run(Thread.java:662)
]]></system-err>
Is this related to HHH-6940 or HHH-5275?
Regards,
Gail
12 years, 3 months
Spring + Hibernate Shards
by Imtiyaz S
Has anybody had luck using Spring with Hibernate Shards?
I have implemented a sample in the spring environment. But the data
does not get committed. (Sample project attached)
I figured the issue is with transactions.
in my Dao.save() if i add transaction code then i see the entries in DB.
This does not seem right, we cannot commit on each save...
Code:
public PK save (E e) {
Session s = this.getSessionFactory().openSession();
s2.flush();
Transaction tx =s2.beginTransaction();
Object o = s2.save(e);
tx.commit();
s2.flush();
s2.close();
return (PK) o;
Also getCurrentSession() on SharededSessionFactory throws
"UnsupportedOperationException"
Without Sharding, my configuration in XML was:
Code:
<bean id="sessionFactory"
class="org.springframework.orm.hibernate3.LocalSessionFactoryBean">
<property name="dataSource" ref="dataSource" />
<property name="mappingResources">
....
</bean>
Now, for sharding, i am using my own ShardedSessionFactoryBuilder class as
described in:
http://www.ibm.com/developerworks/ja...j-javadev2-11/<http://www.ibm.com/developerworks/java/library/j-javadev2-11/>
So there is no "LocalSessionFactoryBean". Is this needed for Transactions?
thanks in advance.
12 years, 3 months
