Re: [hibernate-dev] any specific reason left that keep hibernate away from building on jdk6?

Hi all, If there is no more object, I'm going to apply this patch, see below: Index: parent/pom.xml =================================================================== --- parent/pom.xml (revision 19258) +++ parent/pom.xml (working copy) @@ -118,6 +118,34 @@ <extensions>true</extensions> </plugin> <plugin> + <groupId>org.codehaus.groovy.maven</groupId> + <artifactId>gmaven-plugin</artifactId> + <version>1.0</version> + <executions> + <execution> + <phase>deploy</phase> + <goals> + <goal>execute</goal> + </goals> + <configuration> + <source><![CDATA[ + def javaVersion=System.getProperty("java.version") + def enforceJava5=System.getProperty("hibernate.enforce.deploy.notjdk5") + if(!javaVersion.startsWith("1.5")){ + if(enforceJava5==null || !enforceJava5.equalsIgnoreCase("true")) + fail("Hi man, you're not using JDK5 for hibernate deploying!\n"+ + "Although Hibernate can be build on both jdk5 and jdk6 during "+ + "development, but we do need build it on jdk5 for releasing. "+ + "If you *really* want to do this deploy on a non-jdk5, "+ + "please add this property '-Dhibernate.enforce.deploy.notjdk5=true'.") + } + ]]> + </source> + </configuration> + </execution> + </executions> + </plugin> + <plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-enforcer-plugin</artifactId> <executions> @@ -132,7 +160,7 @@ <rules> <requireJavaVersion> <!-- require JDK 1.5 to run the build --> - <version>[1.5,1.6)</version> + <version>[1.5,)</version> </requireJavaVersion> <requireMavenVersion> <!-- we need at least Maven 2.0.8 because of a bug fix affecting our antlr usage --> -------------------------------------------- here is the result if you run "mvn clean deploy" on jdk6: papa-pc:core-branch35 stliu$ java -version java version "1.6.0_15" Java(TM) SE Runtime Environment (build 1.6.0_15-b03-219) Java HotSpot(TM) 64-Bit Server VM (build 14.1-b02-90, mixed mode) papa-pc:core-branch35 stliu$ mvn clean deploy ... [INFO] [deploy:deploy] altDeploymentRepository = null [INFO] Retrieving previous build number from snapshots.jboss.org Uploading: file:///User/stliu/.m2/test/org/hibernate/hibernate-parent/3.5.2-SNAPSHOT/hibernate-parent-3.5.2-20100421.094808-19.pom 41K uploaded [INFO] Retrieving previous metadata from snapshots.jboss.org [INFO] Uploading repository metadata for: 'artifact org.hibernate:hibernate-parent' [INFO] Retrieving previous metadata from snapshots.jboss.org [INFO] Uploading repository metadata for: 'snapshot org.hibernate:hibernate-parent:3.5.2-SNAPSHOT' [INFO] [groovy:execute {execution: default}] [INFO] ------------------------------------------------------------------------ [ERROR] BUILD ERROR [INFO] ------------------------------------------------------------------------ [INFO] org.apache.maven.plugin.MojoExecutionException: Hi man, you're not using JDK5 for hibernate deploying! Although Hibernate can be build on both jdk5 and jdk6 during development, but we do need build it on jdk5 for releasing. If you *really* want to do this deploy on a non-jdk5, please add this property '-Dhibernate.enforce.deploy.notjdk5=true'. [INFO] ------------------------------------------------------------------------ [INFO] For more information, run Maven with the -e switch [INFO] ------------------------------------------------------------------------ [INFO] Total time: 14 seconds [INFO] Finished at: Wed Apr 21 17:48:11 CST 2010 [INFO] Final Memory: 42M/88M [INFO] ------------------------------------------------------------------------ ------------------------- Best Regards, Strong Liu <stliu at redhat.com> On Apr 19, 2010, at 4:33 PM, Strong Liu wrote: