[hibernate-dev] Re: Dialect.supportsValuesList() ignored for InsertUpdateTests.testInsertValues

Hi Mark, thanks for the report. As you figured, this is currently not handled. The method was introduced for a CTE mutation strategy that I rewrote and the method currently has no real use. I agree though that it makes sense to make use of it for this purpose. I don't know if it makes sense to handle this in the SqlAstTranslator though. It's probably best to do some kind of query splitting for this. I created https://hibernate.atlassian.net/browse/HHH-14483 for this. Have to think about it a little though. Regards, Christian Am 07.03.2021 um 16:29 schrieb Mark Rotteveel: > Testing against Firebird, it seems like Dialect.supportsValuesList() > is ignored. > > Specifically the test > org.hibernate.orm.test.query.hql.InsertUpdateTests.testInsertValues > generates the following statement even with > Dialect.supportsValuesList() return false: > > ``` >     insert >     into >         Ticket >         (id, ticket_key, subject, details) >     values >         (2, 'XYZ123', 'Outage', 'Something is broken'),  ( >             13, 'HIJ456', 'x', 'x' >         ) > ``` > > Or is this a situation where this is ignored because the HQL > explicitly contains two lists? > > Mark