Re: [hibernate-dev] Refactor MySQL Dialects
I created a Pull Request for this:
https://github.com/hibernate/hibernate-orm/pull/1787
If you think we should not make this change, then I can close it.
However, I think it's much easier if we have a single hierarchy in the
MySQL Dialects.
Vlad
On Thu, Feb 9, 2017 at 3:28 PM, Steve Ebersole <steve(a)hibernate.org> wrote:
That is a good solution for now.
Ultimately I think we still want to add some capability for Dialects to
configure either themselves or the things they return based on Connection,
env, etc. It's something we have discussed for some time.
On Wed, Feb 8, 2017 at 1:01 AM Vlad Mihalcea <mihalcea.vlad(a)gmail.com>
wrote:
> Hi,
>
> While working on MariaDB Dialects, I realize that we should also refactor
> the MySQL ones.
> The problem is that we introduced the InnoDB hierarchy.
>
> Since the only difference between those two is related to 3 methods, I
> think we should hide them behind a MySQLStorageEngine hierarchy with
> InnoDB
> being the default one.
> This way, we'll have a single MySQL Dialect hierarchy, and users can
> switch
> to MyISAM via a configuration property which define what
> MySQLStorageEngine
> implementation we are using.
>
> Let me know what you think.
>
> Vlad
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>