Re: [hibernate-dev] Hibernate ORM modules for Wildfly 11
On Wed, Aug 30, 2017 at 10:38 AM Sanne Grinovero <sanne(a)hibernate.org>
wrote:
On 29 August 2017 at 20:28, Steve Ebersole
<steve(a)hibernate.org> wrote:
> Then I think we should update 5.2 as well, but that creates an
interesting
> concern in that the published artifact name would change if I understand
> correctly because it would change the artifact's classifier from
> `wildfly-10-dist` to `wildfly-11-dist`. Things that refer to this
artifact
> as a dependency would no longer work.
Sorry but I'm not understanding. To be clear: I only patched master,
so I already updated 5.2 and yes I can confirm that the classifier
changed accordingly.
I don't see this as a big deal for users, I updated the ORM
documentation accordingly to mention the new classifier. IMO changing
target appserver is not expected to be "as automatic" as changing some
dependencies, and it's unlikely to not be noticed so having to change
the classifier shouldn't be a big deal.
Well you are assuming that someone using hibernate-orm-modules going from
Hibernate version 5.2.10 to 5.2.10 also wants to go from WF 10 to WF 11. I
don't think that is necessarily a valid assumption. This line of thinking
clearly targets people wanting to try the latest Hibernate in the latest
WF. If that is the only goal, then this works. But it causes problems for
people already using
`org.hibernate:hibernate-orm-module:5.2.10:wildfly-10-dist` - its not just
the version that changed so changing a single ~`hibernateVersion` property
somewhere is not enough for a simple upgrade for these people.
My concern is really more along the lines, e.g., of the trouble we ran into
with Spring and us dropping hibernate-entity-manager - their BOMs no longer
worked as it referred to no-longer-existent artifact. Changing the
classifier leads to the same condition.