As suggested by Sanne and Galder, I'll open a new Jira for the commit in my pull
request and amend the comment to reflect the new Jira.
I'll see if I can get "forced version" in Gradle working in the next couple
of hours. If not, I don't want to hold up releasing 4.3.10.Final for this. I can try
to get those details worked out later.
I think that about wraps up what is needed for Hibernate 4.3 to support and test with
Infinispan 7.2.1.Final. Unless I hear otherwise, I plan to release 4.3.10.Final later
today, tomorrow at the latest.
Regards,
Gail
----- Original Message -----
From: "Steve Ebersole" <steve(a)hibernate.org>
To: "Gail Badner" <gbadner(a)redhat.com>
Cc: "Sanne Grinovero" <sanne(a)hibernate.org>, "Scott Marlow"
<smarlow(a)redhat.com>, "Galder ZamarreƱo"
<galder(a)redhat.com>, "Hibernate Dev"
<hibernate-dev(a)lists.jboss.org>
Sent: Wednesday, May 13, 2015 9:57:24 AM
Subject: Re: Another pull request for supporting Infinispan 7.2.1 in 4.3
Not sure what limitations you mean. All I said was that if you wanted to
allow testing with both you would need to make this conditional and expose
a property to control which to use.
On Wed, May 13, 2015 at 11:29 AM, Gail Badner <gbadner(a)redhat.com> wrote:
> Adding hibernate-dev.
>
> No, I did not have a chance to read up on what you suggested. I sounded
> like it had some limitations that would not work, but maybe I
> misunderstood. I'll look into it today.
>
> The last couple of days have been very long. Sorry for the oversights.
>
> ----- Original Message -----
> > From: "Steve Ebersole" <steve(a)hibernate.org>
> > To: "Gail Badner" <gbadner(a)redhat.com>
> > Cc: "Sanne Grinovero" <sanne(a)hibernate.org>, "Scott
Marlow" <
> smarlow(a)redhat.com>, "Galder ZamarreƱo"
> > <galder(a)redhat.com>
> > Sent: Wednesday, May 13, 2015 5:33:24 AM
> > Subject: Re: Another pull request for supporting Infinispan 7.2.1 in 4.3
> >
> > On May 13, 2015 7:32 AM, "Steve Ebersole" <steve(a)hibernate.org>
wrote:
> > >
> > > 1) This really should be a hibernate-core discussion
> >
> > I meant to say hibernate-dev...
> >
> > > 2) I already suggested using forced version in Gradle and gave you a
> link
> > on how that works. Did you read it? Did you try it?
> > >
> > > On May 13, 2015 2:04 AM, "Gail Badner"
<gbadner(a)redhat.com> wrote:
> > >>
> > >> Sanne, Scott, and I discussed how Hibernate should deal with
> supporting
> > Infinispan 7.2.1 in 4.3 earlier today. I think the consensus was it would
> > be sufficient to:
> > >> - specify the Infinispan 7.2 configuration by using
> > hibernate.cache.infinispan.cfg (so Hibernate wouldn't have to switch if
> > parsing failed);
> > >> - run tests manually with Infinispan 7.2 for WildFly integration
> testing.
> > >>
> > >> I created another pull request:
> >
https://github.com/hibernate/hibernate-orm/pull/953
> > >>
> > >> My pull request incorporated some of Galder's changes from
> >
https://github.com/hibernate/hibernate-orm/pull/951.
> > >>
> > >> The main differences:
> > >> - Hibernate will consider the 7.2 configuration as test code
> > >> - the 7.2 configuration can be specified using
> >
> -Dhibernate.cache.infinispan.cfg=src/test/resources/infinispan-7-configs.xml
> > >>
> > >> Currently, the only way to run hibernate-infinispan tests is to
change
> > infinispanVersion from 6.0.0.Final to 7.2.1.Final. It would be nice to be
> > able to specify infinispanVersion as a environment variable, defaulting
> to
> > 6.0.0.Final to avoid having to manually update libraries.gradle.
> > >>
> > >> Another consideration is that manually updating libraries.gradle
> forces
> > a re-build using Infinispan 7.2.1 as a dependency.
> > >>
> > >> Since WildFly will use a hiberanate-infinispan jar build against
> > Infinispan 6.0.0.Final (won't it???), I think it would be best if we
> could
> > run unit tests without rebuilding with Infinispan 7.2.1, but using it as
> a
> > run time dependency. I haven't been able to figure out how to do that
> > though.
> > >>
> > >> Anyone have an idea how to do that, even manually?
> > >>
> > >> Thoughts on all this?
> > >>
> > >> Thanks,
> > >> Gail
> >
>