Re: [hibernate-dev] missing ANTLR dependency from gradle built pom.xml

I don't know if this is directly relevant (as it is a Maven build), but the other day I downloaded the 3.6.0 final code from github and used Idea 10 to create a (Maven) project from the sources. Once the project was created, it did not compile, and the first visible errors showed classes created by Antler were not present. I simply used the IDE to build the POM's for different parts of the code and after a few builds, the project would build and run. I did this to run the tests. Later, I downloaded the 3.6.1 head and updated the changed files in the previous Idea setup. The build was successful. Fred On Sat, 15 Jan 2011 11:40 -0600, "Steve Ebersole" <steve(a)hibernate.org&gt; wrote: > Pretty sure I checked this previously. The part you ask about configures > the antlr plugin that generates the parsers from the grammar files. > Pretty > positive that also used to add antlr to the project's set or exported > deps. That is where I think something changed. Let me ask about this > on > the gradle channels. > On Jan 14, 2011 12:39 PM, "Sanne Grinovero" <sanne.grinovero(a)gmail.com&gt; > > wrote: > > Hello, > > It seems that ANTLR is missing from the pom.xml generated by the new > > gradle build of Hibernate Core. > > > > The following patch seems to fix it but I couldn't find any > > information on the "antlr( libraries.antlr )" line, from the > > documentation is seems it's only being used to choose the ANTLR > > version to use to generate the parser code, but I couldn't find an > > option to also include it as dependency so I added an additional line. > > > > Could anybody confirm this change is right? (It seems to work). > > > > diff --git a/hibernate-core/hibernate-core.gradle > > b/hibernate-core/hibernate-core.gradle > > index 59f80aa..4f28e93 100644 > > --- a/hibernate-core/hibernate-core.gradle > > +++ b/hibernate-core/hibernate-core.gradle > > @@ -12,6 +12,7 @@ dependencies { > > compile( libraries.commons_annotations ) > > compile( libraries.jpa ) > > antlr( libraries.antlr ) > > + compile( libraries.antlr ) > > provided( libraries.javassist ) > > provided( libraries.cglib ) { > > transitive = true > > > > thanks, > > Sanne > > _______________________________________________ > > hibernate-dev mailing list > > hibernate-dev(a)lists.jboss.org > > https://lists.jboss.org/mailman/listinfo/hibernate-dev > > _______________________________________________ > hibernate-dev mailing list > hibernate-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev _______________________________________________ hibernate-dev mailing list hibernate-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev