I decided to hold off on this for now until GRADLE-2966[1] is resolved,
which would allow us to fold hibernate-testing into hibernate-core from
a source/project perspective but still allow us to publish
hibernate-testing as a artifact.
So I am also working on reverting the change to use -proc:both with a
single compile phase. However, what we will end up with is still a
single -proc:only phase no matter how many processors are run. They
will output to a unified directory
(${buildDir}/generated-src/apt/${sourceSet.name}) and will still give
us a single command up from to generateSources.
[1]
We've removed the dependency to hibernate-testing from OGM now as
it
indeed wasn't actually used.
--Gunnar
2013/11/25 Steve Ebersole <steve(a)hibernate.org
<mailto:steve@hibernate.org>>
If I were to collapse it into hibernate-core... To use Maven
terms, I can expose it as a hibernate-core artifact with a
different classifier. But I would no longer be able to expose it
using the hibernate-testing artifact id.
This works fine either way within the hibernate-orm project. In
fact we already have a very similar usage to this in hibernate-orm
between envers and hem. If I publish the jar, others can access
it as well using that published classifier.
On Mon 25 Nov 2013 08:42:49 AM CST, Gunnar Morling wrote:
Hi,
Hibernate OGM is using hibernate-testing, but I'm not totally
sure why.
When I remove the dependency, the build still passes; Maybe it was
used in the past. But also if we started to use stuff from
hibernate-testing one day, a merge with hibernate-core
wouldn't be a
problem, provided you publish a test JAR (speaking in Maven
terms).
--Gunnar
2013/11/25 Brett Meyer <brmeyer(a)redhat.com
<mailto:brmeyer@redhat.com> <mailto:brmeyer@redhat.com
<mailto:brmeyer@redhat.com>>>
IMO, there shouldn't be anything preventing us from pulling
hibernate-testing into hibernate-core. Are there any external
modules/projects that use testing w/o core? AFAIK, no, but
correct me if I'm overlooking something.
Brett Meyer
Software Engineer
Red Hat, Hibernate ORM
----- Original Message -----
From: "Steve Ebersole" <steve(a)hibernate.org
<mailto:steve@hibernate.org>
<mailto:steve@hibernate.org <mailto:steve@hibernate.org>>>
To: "hibernate-dev" <hibernate-dev(a)lists.jboss.org
<mailto:hibernate-dev@lists.jboss.org>
<mailto:hibernate-dev@lists.__jboss.org
<mailto:hibernate-dev@lists.jboss.org>>>
Sent: Friday, November 22, 2013 5:05:23 PM
Subject: [hibernate-dev] Annotation Processors
I started today on removing the separate calls to javac to
execute
Annotation Processors in the Hibernate ORM build. From
Gradle it is
working fine. However when I try to enable Annotation
Processing in
IntelliJ, it complains about the "module cycle" between
hibernate-core
and hibernate-testing.
I'd really like to get a gauge on how many people really use
hibernate-testing.
_________________________________________________
hibernate-dev mailing list
hibernate-dev(a)lists.jboss.org
<mailto:hibernate-dev@lists.jboss.org>
<mailto:hibernate-dev@lists.__jboss.org
<mailto:hibernate-dev@lists.jboss.org>>
https://lists.jboss.org/__mailman/listinfo/hibernate-dev
<
https://lists.jboss.org/mailman/listinfo/hibernate-dev>
_________________________________________________
hibernate-dev mailing list
hibernate-dev(a)lists.jboss.org
<mailto:hibernate-dev@lists.jboss.org>
<mailto:hibernate-dev@lists.__jboss.org
<mailto:hibernate-dev@lists.jboss.org>>
https://lists.jboss.org/__mailman/listinfo/hibernate-dev
<
https://lists.jboss.org/mailman/listinfo/hibernate-dev>