On Tue, May 16, 2017 at 11:20 AM Sanne Grinovero <sanne(a)hibernate.org&gt; wrote: > Since 6 is coming I'd like to suggest two trivial changes for the > listeners: > > # Serializable > > I assume we can drop the "extend Serializable" from all these interfaces ? > > Personally I've never been a fan of interfaces extending Serializable, so I am fine with that. > # PostInsertEventListener.requiresPostCommitHanding(EntityPersister) > > I suspect there is a typo in this method? > N.B. there are some more copies of `requiresPostCommitHanding` in > other listeners, beyond the PostInsertEventListener. Fine by me, but I wonder if we ought to deprecate it instead and use default methods. Or maybe do that retro in 5.2 and do clean in 6

On 17 May 2017 at 02:23, Steve Ebersole <steve(a)hibernate.org&gt; wrote: > Jira please or we will forget. Assign it to Alpha2 for now - https://hibernate.atlassian.net/browse/HHH-11755 - https://hibernate.atlassian.net/browse/HHH-11756 Is it a good time to help out with 6.0 ? I've been staying clear from it as you all seem to be making very quick cycles and aggressive refactorings - hard to dive in when I can only spare a few hours - but if it's a good time I'm happy to push these myself. Please assign them and set the "fix versions" as you wish. Thanks, Sanne > > On Tue, May 16, 2017 at 7:01 PM Steve Ebersole <steve(a)hibernate.org&gt; wrote: >> >> On Tue, May 16, 2017 at 11:20 AM Sanne Grinovero <sanne(a)hibernate.org&gt; >> wrote: >>> >>> Since 6 is coming I'd like to suggest two trivial changes for the >>> listeners: >>> >>> # Serializable >>> >>> I assume we can drop the "extend Serializable" from all these interfaces >>> ? >>> >> >> Personally I've never been a fan of interfaces extending Serializable, so >> I am fine with that. >> >> >>> >>> # PostInsertEventListener.requiresPostCommitHanding(EntityPersister) >>> >>> I suspect there is a typo in this method? >>> N.B. there are some more copies of `requiresPostCommitHanding` in >>> other listeners, beyond the PostInsertEventListener. >> >> >> Fine by me, but I wonder if we ought to deprecate it instead and use >> default methods. Or maybe do that retro in 5.2 and do clean in 6

On 17 May 2017 at 14:56, Steve Ebersole <steve(a)hibernate.org&gt; wrote: > Thanks, I'll check them out. > > As to your questions... > > Now would be fine to tackle these if you wish. What we are working on > should not really impact places you are talking about. I said Alpha 2 > earlier because I meant it was not going to be a priority for us any time > soon, although we would do it before any CRs. But if you want to take it > on, I'd say go for it > As to where... we are still working on a branch in my fork of orm. We will > continue that until we can at least get it buildable. But you can send me a > PR or I can give you access to that branch. TBH if it's still in "incubating branches" I might want to dodge the bullet and wait for better times :) May I suggest to move it into master and resume "normal cycles"? What is making you uncomfortable about that? Thanks, Sanne > > > On Wed, May 17, 2017 at 8:46 AM Sanne Grinovero <sanne(a)hibernate.org&gt; wrote: >> >> On 17 May 2017 at 02:23, Steve Ebersole <steve(a)hibernate.org&gt; wrote: >> > Jira please or we will forget. Assign it to Alpha2 for now >> >> - https://hibernate.atlassian.net/browse/HHH-11755 >> - https://hibernate.atlassian.net/browse/HHH-11756 >> >> Is it a good time to help out with 6.0 ? I've been staying clear from >> it as you all seem to be making very quick cycles and aggressive >> refactorings - hard to dive in when I can only spare a few hours - but >> if it's a good time I'm happy to push these myself. >> >> Please assign them and set the "fix versions" as you wish. >> >> Thanks, >> Sanne >> >> > >> > On Tue, May 16, 2017 at 7:01 PM Steve Ebersole <steve(a)hibernate.org&gt; >> > wrote: >> >> >> >> On Tue, May 16, 2017 at 11:20 AM Sanne Grinovero < sanne(a)hibernate.org&gt; >> >> wrote: >> >>> >> >>> Since 6 is coming I'd like to suggest two trivial changes for the >> >>> listeners: >> >>> >> >>> # Serializable >> >>> >> >>> I assume we can drop the "extend Serializable" from all these >> >>> interfaces >> >>> ? >> >>> >> >> >> >> Personally I've never been a fan of interfaces extending Serializable, >> >> so >> >> I am fine with that. >> >> >> >> >> >>> >> >>> # PostInsertEventListener.requiresPostCommitHanding(EntityPersister) >> >>> >> >>> I suspect there is a typo in this method? >> >>> N.B. there are some more copies of `requiresPostCommitHanding` in >> >>> other listeners, beyond the PostInsertEventListener. >> >> >> >> >> >> Fine by me, but I wonder if we ought to deprecate it instead and use >> >> default methods. Or maybe do that retro in 5.2 and do clean in 6