Nice. I checkout out the metamodel branch and all builds fine. You seem to have chosen the merge path for the integration. Is this what we are going to do in the future as well (merging instead of rebasing)?

OOI, was it hard to merge? Many conflicts? It should have been straight forward, right?

I like the dynamic task approach or at least never had any problems w/ it. IMO it is one of the nicer features of Gradle. What anger are you talking about?

are the master and metamodel supposed to be synced?

I see there are some mismatch org.hibernate.internal.SessionFactoryImpl#determineCustomEntityDirtinessStrategy

org.hibernate.internal.SessionFactoryImpl#determineCurrentTenantIdentifierResolver

I am done with consolidating src/matrix into src/test and merging master into metamodel. Everything seems to be working. Let me know if you see any issues. I did need to adjust the "matrix plugin" a little bit. We should talk about testing as it relates to the database matric a little more and specifically how we want this to work. We have been using the the "dynamic task" approach for quite some time now. Curious how everyone likes/dislikes it now after using it in anger for the last months. The one main thing that changed in the plugin is that there is no longer a notion of a "matrix unit test". `gradle test` simply runs all the tests using the default database (h2) for any tests that need a database. Then there are the "matrix test tasks" that perform the test using the requested database. I did not alter those task names. However, running one of those "matrix test tasks" no longer runs the [test] task (default database) as a task dependency.

-- steve(a)hibernate.org http://hibernate.org _______________________________________________ hibernate-dev mailing list hibernate-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev

1) `gradle test` runs all tests (there is just src/test now) against default database (h2) 2) `gradle matrix_XYZ` essentially runs [gradle test] but against the XYZ "database profile"

3) `gradle matrix` runs all all tests against all "database profiles". It does not currently run against h2 I believe, so we might want to change that. Although I think it is more a matter of idealism; I cannot imagine the usefulness of running all tests against all database profiles in a single command from a practical point-of-view. On Sun 10 Jun 2012 09:04:36 PM CDT, Strong Liu wrote: > > On Jun 8, 2012, at 9:20 PM, Steve Ebersole wrote: > >> I am done with consolidating src/matrix into src/test and merging master >> into metamodel. Everything seems to be working. Let me know if you see >> any issues. >> >> I did need to adjust the "matrix plugin" a little bit. We should talk >> about testing as it relates to the database matric a little more and >> specifically how we want this to work. We have been using the the >> "dynamic task" approach for quite some time now. Curious how everyone >> likes/dislikes it now after using it in anger for the last months. >> >> The one main thing that changed in the plugin is that there is no longer >> a notion of a "matrix unit test". `gradle test` simply runs all the >> tests using the default database (h2) for any tests that need a >> database. Then there are the "matrix test tasks" that perform the test >> using the requested database. I did not alter those task names. >> However, running one of those "matrix test tasks" no longer runs the >> [test] task (default database) as a task dependency. > > so, the "matrix test tasks" now runs all test cases on the target DB? > > >> >> >> -- >> steve(a)hibernate.org <mailto:steve@hibernate.org> >> http://hibernate.org >> _______________________________________________ >> hibernate-dev mailing list >> hibernate-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/hibernate-dev > > ------------------------- > Best Regards, > > Strong Liu <stliu at hibernate.org <http://hibernate.org/>> > http://about.me/stliu/bio > -- steve(a)hibernate.org http://hibernate.org

Not sure how else to "all tests" ;) On Mon 11 Jun 2012 09:14:28 AM CDT, Strong Liu wrote: > > On Jun 11, 2012, at 10:02 PM, Steve Ebersole wrote: > >> 1) `gradle test` runs all tests (there is just src/test now) against >> default database (h2) >> >> 2) `gradle matrix_XYZ` essentially runs [gradle test] but against the >> XYZ "database profile" > > so, for example, those metamodel unit tests are also triggered to run > in this case on XYZ db? don't we want to skip those unit tests? > > I see there are couple tests are failing due to the tests were not > wrote to run on other DBs (or any DB) > >> >> 3) `gradle matrix` runs all all tests against all "database >> profiles". It does not currently run against h2 I believe, so we >> might want to change that. Although I think it is more a matter of >> idealism; I cannot imagine the usefulness of running all tests >> against all database profiles in a single command from a practical >> point-of-view. >> >> >> On Sun 10 Jun 2012 09:04:36 PM CDT, Strong Liu wrote: >>> >>> On Jun 8, 2012, at 9:20 PM, Steve Ebersole wrote: >>> >>>> I am done with consolidating src/matrix into src/test and merging >>>> master >>>> into metamodel. Everything seems to be working. Let me know if you >>>> see >>>> any issues. >>>> >>>> I did need to adjust the "matrix plugin" a little bit. We should talk >>>> about testing as it relates to the database matric a little more and >>>> specifically how we want this to work. We have been using the the >>>> "dynamic task" approach for quite some time now. Curious how everyone >>>> likes/dislikes it now after using it in anger for the last months. >>>> >>>> The one main thing that changed in the plugin is that there is no >>>> longer >>>> a notion of a "matrix unit test". `gradle test` simply runs all the >>>> tests using the default database (h2) for any tests that need a >>>> database. Then there are the "matrix test tasks" that perform the >>>> test >>>> using the requested database. I did not alter those task names. >>>> However, running one of those "matrix test tasks" no longer runs the >>>> [test] task (default database) as a task dependency. >>> >>> so, the "matrix test tasks" now runs all test cases on the target DB? >>> >>> >>>> >>>> >>>> -- >>>> steve(a)hibernate.org <mailto:steve@hibernate.org> >>>> <mailto:steve@hibernate.org> >>>> http://hibernate.org >>>> _______________________________________________ >>>> hibernate-dev mailing list >>>> hibernate-dev(a)lists.jboss.org <mailto:hibernate-dev@lists.jboss.org> >>>> https://lists.jboss.org/mailman/listinfo/hibernate-dev >>> >>> ------------------------- >>> Best Regards, >>> >>> Strong Liu <stliu at hibernate.org <http://hibernate.org> >>> <http://hibernate.org/>> >>> http://about.me/stliu/bio >>> >> >> -- >> steve(a)hibernate.org <mailto:steve@hibernate.org> >> http://hibernate.org > > ------------------------- > Best Regards, > > Strong Liu <stliu at hibernate.org <http://hibernate.org/>> > http://about.me/stliu/bio > -- steve(a)hibernate.org http://hibernate.org