10:19 a.m.
Hi,
I just noticed https://github.com/hibernate/hibernate-core/pull/147/files
Does that change work on all previous AS versions or is Hibernate JTA now locked down to
run on AS 7 ?
if I recall java:/TransactionManager is the only place it is posted in AS 4 and 5?
Or am I wrong about that?
/max
http://about.me/maxandersen
10:57 a.m.
On 08/05/2011 11:19 AM, Max Rydahl Andersen wrote:
Hi,
I just noticed https://github.com/hibernate/hibernate-core/pull/147/files
Does that change work on all previous AS versions or is Hibernate JTA now locked down to
run on AS 7 ?
Good point, its wrong either way for some version of AS.
if I recall java:/TransactionManager is the only place it is posted in AS 4 and 5?
Right, java:/TransactionManager is correct before AS7.
Or am I wrong about that?
What is the best approach here? Should we support older versions of AS
in Hibernate 4?
If yes, should we create a different JBossAppServerJTAPlatform for
AS4-AS6? Maybe called JBossAppServer4JTAPlatform? Hopefully the AS7
way, will cover us for version range AS7-AS64. ;)
12:03 p.m.
> if I recall java:/TransactionManager is the only place it is
posted in AS 4 and 5?
Right, java:/TransactionManager is correct before AS7.
Do you know the reason for this change BTW?
What is the best approach here? Should we support older versions of AS
in Hibernate 4?
Yes if we can and if that's the only sticking point.
If yes, should we create a different JBossAppServerJTAPlatform for
AS4-AS6? Maybe called JBossAppServer4JTAPlatform? Hopefully the AS7
way, will cover us for version range AS7-AS64. ;)
That's the approach we have used for WAS that was changing their names in an
unreasonable way :)
12:29 p.m.
On 08/05/2011 01:03 PM, Emmanuel Bernard wrote:
>> if I recall java:/TransactionManager is the only place it is posted in AS 4 and
5?
>
> Right, java:/TransactionManager is correct before AS7.
Do you know the reason for this change BTW?
>
> What is the best approach here? Should we support older versions of AS
> in Hibernate 4?
Yes if we can and if that's the only sticking point.
>
> If yes, should we create a different JBossAppServerJTAPlatform for
> AS4-AS6? Maybe called JBossAppServer4JTAPlatform? Hopefully the AS7
> way, will cover us for version range AS7-AS64. ;)
That's the approach we have used for WAS that was changing their names in an
unreasonable way :)
Discussing it now on #jboss-as7
(http://echelog.matzon.dk/logs/browse/jboss-as7/1312495200)
12:38 p.m.
On 08/05/2011 01:03 PM, Emmanuel Bernard wrote:
>> if I recall java:/TransactionManager is the only place it is posted in AS 4 and
5?
>
> Right, java:/TransactionManager is correct before AS7.
Do you know the reason for this change BTW?
Best to see the
http://echelog.matzon.dk/logs/browse/jboss-as7/1312495200 discussion.
Its about keeping the root name space clean...
>
> What is the best approach here? Should we support older versions of AS
> in Hibernate 4?
Yes if we can and if that's the only sticking point.
>
> If yes, should we create a different JBossAppServerJTAPlatform for
> AS4-AS6? Maybe called JBossAppServer4JTAPlatform? Hopefully the AS7
> way, will cover us for version range AS7-AS64. ;)
That's the approach we have used for WAS that was changing their names in an
unreasonable way :)
Let me know if I should create a HHH jira and do so. If you want to
discuss further (maybe on #jboss-as7), we can wait for the jira.
11:33 a.m.
>>> if I recall java:/TransactionManager is the only place it
is posted in AS 4 and 5?
>>
>> Right, java:/TransactionManager is correct before AS7.
>
> Do you know the reason for this change BTW?
Best to see the http://echelog.matzon.dk/logs/browse/jboss-as7/1312495200 discussion.
Its about keeping the root name space clean…
I get that - but it means we'll need a different lookup/class for it I assume -
hopefully we can somehow detect what env we run in to make it transparent ?
>> What is the best approach here? Should we support older
versions of AS
>> in Hibernate 4?
>
> Yes if we can and if that's the only sticking point.
+1
>
>>
>> If yes, should we create a different JBossAppServerJTAPlatform for
>> AS4-AS6? Maybe called JBossAppServer4JTAPlatform? Hopefully the AS7
>> way, will cover us for version range AS7-AS64. ;)
>
> That's the approach we have used for WAS that was changing their names in an
unreasonable way :)
>
Let me know if I should create a HHH jira and do so. If you want to discuss further
(maybe on #jboss-as7), we can wait for the jira.
Creating a jira sounds the simplest ? :)
/max
http://about.me/maxandersen
8:36 p.m.
On 08/09/2011 12:33 PM, Max Rydahl Andersen wrote:
>>>> if I recall java:/TransactionManager is the only
place it is posted in AS 4 and 5?
>>>
>>> Right, java:/TransactionManager is correct before AS7.
>>
>> Do you know the reason for this change BTW?
>
> Best to see the http://echelog.matzon.dk/logs/browse/jboss-as7/1312495200
discussion.
>
> Its about keeping the root name space clean…
I get that - but it means we'll need a different lookup/class for it I assume -
hopefully we can somehow detect what env we run in to make it transparent ?
I created HHH-6564 for this regression against earlier releases of AS +
Hibernate 4.
>>> What is the best approach here? Should we support older versions of AS
>>> in Hibernate 4?
>>
>> Yes if we can and if that's the only sticking point.
+1
>>
>>>
>>> If yes, should we create a different JBossAppServerJTAPlatform for
>>> AS4-AS6? Maybe called JBossAppServer4JTAPlatform? Hopefully the AS7
>>> way, will cover us for version range AS7-AS64. ;)
>>
>> That's the approach we have used for WAS that was changing their names in an
unreasonable way :)
>>
>
> Let me know if I should create a HHH jira and do so. If you want to discuss further
(maybe on #jboss-as7), we can wait for the jira.
Creating a jira sounds the simplest ? :)
/max
http://about.me/maxandersen
10:11 a.m.
I'll try to support AS7 and earlier. If its not as7, will catch the
jndi naming exception and try the older name.
For the user transaction lookup, I think that
"java:comp/UserTransaction" is supported by AS7 and earlier. I'll
change the AS7 user transaction lookup to use that.
Any feedback on the code change?
https://github.com/scottmarlow/hibernate-core/commit/4346f09b6ed347cb3fbe...
4872
days inactive
4878
days old
7 comments
3 participants
participants (3)
-
Emmanuel Bernard -
Max Rydahl Andersen -
Scott Marlow