11:43 a.m.
On Sun, Oct 1, 2017 at 6:18 PM, Marko Bekhta <marko.prykladna(a)gmail.com>
wrote:
otherwise they are displayed differently for each post. WDYT?
Good idea. As of now, they should be on a separate line on mobile.
2:12 a.m.
New subject: New layout for in.relation.to
Looks great! Thanks for all the good work.
Two suggestions:
- Add a button to display the menu on mobile
- Do not display the author's picture on mobile, or display it on a
separate row. I think it's currently responsible for the minimal screen
width being relatively high, which will not look good on smaller devices.
Note there's a "hidden-phone" class on the image, but it doesn't seem
to
work.
Yoann Rodière
Hibernate NoORM Team
yoann(a)hibernate.org
On 1 October 2017 at 18:43, Guillaume Smet <guillaume.smet(a)gmail.com> wrote:
On Sun, Oct 1, 2017 at 6:18 PM, Marko Bekhta
<marko.prykladna(a)gmail.com>
wrote:
> otherwise they are displayed differently for each post. WDYT?
>
>
Good idea. As of now, they should be on a separate line on mobile.
_______________________________________________
hibernate-dev mailing list
hibernate-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev
4:12 a.m.
New subject: New layout for in.relation.to
On Mon, Oct 2, 2017 at 9:12 AM, Yoann Rodiere <yoann(a)hibernate.org> wrote:
Add a button to display the menu on mobile
I don't think it has much value on in.relation.to. That's why I don't show
it.
Do not display the author's picture on mobile, or display it on a
separate row. I think it's currently responsible for the minimal screen width being
relatively high, which will not look good on smaller devices. Note there's a
"hidden-phone" class on the image, but it doesn't seem to work.
I wanted to show them (the class was a leftover I didn't notice as
these classes are not supported anymore) but you're right. I changed
the resolution of my mobile testing the other day and I didn't notice
it while testing in.relation.to. Better remove them.
Done and pushed.
--
Guillaume
4:44 a.m.
New subject: New layout for in.relation.to
I don't think it has much value on in.relation.to. That's why
I don't
show it.
Well it's a bit confusing when coming from hibernate.org, since we made
sure to make everything look like it's the same website, and yet this
important part disappears... Granted, we could only have a stripped-down
version of the hibernate.org menu, so it would still be confusing, but
that's still better than nothing in my opinion.
On top of that, the menu button would only fill some currently unused space
on the top right, so there's really not much of a reason to remove it.
Yoann Rodière
Hibernate NoORM Team
yoann(a)hibernate.org
On 2 October 2017 at 11:12, Guillaume Smet <guillaume.smet(a)gmail.com> wrote:
> On Mon, Oct 2, 2017 at 9:12 AM, Yoann Rodiere <yoann(a)hibernate.org> wrote:
> > Add a button to display the menu on mobile
>
I don't think it has much value on in.relation.to. That's why
I don't
> show it.
>
> > Do not display the author's picture on mobile, or display it on a
> separate row. I think it's currently responsible for the minimal screen
> width being relatively high, which will not look good on smaller devices.
> Note there's a "hidden-phone" class on the image, but it doesn't
seem to
> work.
>
> I wanted to show them (the class was a leftover I didn't notice as
> these classes are not supported anymore) but you're right. I changed
> the resolution of my mobile testing the other day and I didn't notice
> it while testing in.relation.to. Better remove them.
>
> Done and pushed.
>
> --
> Guillaume
>
5:55 a.m.
New subject: New layout for in.relation.to
On Mon, Oct 2, 2017 at 11:44 AM, Yoann Rodiere <yoann(a)hibernate.org> wrote:
Well it's a bit confusing when coming from hibernate.org, since
we made sure
to make everything look like it's the same website, and yet this important
part disappears... Granted, we could only have a stripped-down version of
the hibernate.org menu, so it would still be confusing, but that's still
better than nothing in my opinion.
On top of that, the menu button would only fill some currently unused space
on the top right, so there's really not much of a reason to remove it.
After discussing it with Yoann, I brought back a simplified version of
the menu on mobile (to avoid having to maintain the whole
hibernate.org tree on in.relation.to).
--
Guillaume
6:41 a.m.
New subject: New layout for in.relation.to
Thanks everyone for the useful feedback.
I pushed it to production just now.
If you have any other issue, just shout an email, I'll fix them as they come.
--
Guillaume
On Mon, Oct 2, 2017 at 12:55 PM, Guillaume Smet
<guillaume.smet(a)gmail.com> wrote:
On Mon, Oct 2, 2017 at 11:44 AM, Yoann Rodiere
<yoann(a)hibernate.org> wrote:
> Well it's a bit confusing when coming from hibernate.org, since we made sure
> to make everything look like it's the same website, and yet this important
> part disappears... Granted, we could only have a stripped-down version of
> the hibernate.org menu, so it would still be confusing, but that's still
> better than nothing in my opinion.
> On top of that, the menu button would only fill some currently unused space
> on the top right, so there's really not much of a reason to remove it.
After discussing it with Yoann, I brought back a simplified version of
the menu on mobile (to avoid having to maintain the whole
hibernate.org tree on in.relation.to).
--
Guillaume
9:42 a.m.
New subject: New layout for in.relation.to
Thanks Guillaume!
As for feedback, in case your TODO list gets out of hand over emails
you can also just WEBSITE project on JIRA:
- https://hibernate.atlassian.net/projects/WEBSITE
On 2 October 2017 at 12:41, Guillaume Smet <guillaume.smet(a)gmail.com> wrote:
Thanks everyone for the useful feedback.
I pushed it to production just now.
If you have any other issue, just shout an email, I'll fix them as they come.
--
Guillaume
On Mon, Oct 2, 2017 at 12:55 PM, Guillaume Smet
<guillaume.smet(a)gmail.com> wrote:
> On Mon, Oct 2, 2017 at 11:44 AM, Yoann Rodiere <yoann(a)hibernate.org> wrote:
>> Well it's a bit confusing when coming from hibernate.org, since we made sure
>> to make everything look like it's the same website, and yet this important
>> part disappears... Granted, we could only have a stripped-down version of
>> the hibernate.org menu, so it would still be confusing, but that's still
>> better than nothing in my opinion.
>> On top of that, the menu button would only fill some currently unused space
>> on the top right, so there's really not much of a reason to remove it.
>
> After discussing it with Yoann, I brought back a simplified version of
> the menu on mobile (to avoid having to maintain the whole
> hibernate.org tree on in.relation.to).
>
> --
> Guillaume
_______________________________________________
hibernate-dev mailing list
hibernate-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev
10:49 a.m.
New subject: New layout for in.relation.to
Yup. For now, it has been easier to fix things on the fly.
But thanks for the suggestion.
On Mon, Oct 2, 2017 at 4:42 PM, Sanne Grinovero <sanne(a)hibernate.org> wrote:
Thanks Guillaume!
As for feedback, in case your TODO list gets out of hand over emails
you can also just WEBSITE project on JIRA:
- https://hibernate.atlassian.net/projects/WEBSITE
On 2 October 2017 at 12:41, Guillaume Smet <guillaume.smet(a)gmail.com> wrote:
> Thanks everyone for the useful feedback.
>
> I pushed it to production just now.
>
> If you have any other issue, just shout an email, I'll fix them as they come.
>
> --
> Guillaume
>
> On Mon, Oct 2, 2017 at 12:55 PM, Guillaume Smet
> <guillaume.smet(a)gmail.com> wrote:
>> On Mon, Oct 2, 2017 at 11:44 AM, Yoann Rodiere <yoann(a)hibernate.org>
wrote:
>>> Well it's a bit confusing when coming from hibernate.org, since we made
sure
>>> to make everything look like it's the same website, and yet this
important
>>> part disappears... Granted, we could only have a stripped-down version of
>>> the hibernate.org menu, so it would still be confusing, but that's still
>>> better than nothing in my opinion.
>>> On top of that, the menu button would only fill some currently unused space
>>> on the top right, so there's really not much of a reason to remove it.
>>
>> After discussing it with Yoann, I brought back a simplified version of
>> the menu on mobile (to avoid having to maintain the whole
>> hibernate.org tree on in.relation.to).
>>
>> --
>> Guillaume
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
6:22 a.m.
New subject: New layout for in.relation.to
Hi,
I like the new layout and navigation. Well done. One thing I am wondering though
is the rectangular "box" around the two lines in the header? Is this intended?
I find it quite harsh. I first thought it is a browser issue, but it seems
to render the same way with any browser or device.
--Hardy
6:43 a.m.
New subject: New layout for in.relation.to
Hush, it's a sensitive topic :) Let's just say it's on purpose, and it
could have been... harsher. The current style is already a compromise.
Yoann Rodière
Hibernate NoORM Team
yoann(a)hibernate.org
On 4 October 2017 at 13:22, Hardy Ferentschik <hardy(a)hibernate.org> wrote:
Hi,
I like the new layout and navigation. Well done. One thing I am wondering
though
is the rectangular "box" around the two lines in the header? Is this
intended?
I find it quite harsh. I first thought it is a browser issue, but it seems
to render the same way with any browser or device.
--Hardy
_______________________________________________
hibernate-dev mailing list
hibernate-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev
8:24 a.m.
New subject: New layout for in.relation.to
On Wed, 04-Oct-2017 13:43, Yoann Rodiere wrote:
Hush, it's a sensitive topic :) Let's just say it's on
purpose, and it
could have been... harsher. The current style is already a compromise.
Interesting. I got more interested now, but maybe better to leave it at this. ;-)
--Hardy
3016
days inactive
3020
days old
10 comments
4 participants
participants (4)
-
Guillaume Smet -
Hardy Ferentschik -
Sanne Grinovero -
Yoann Rodiere