About this post: https://forum.hibernate.org/viewtopic.php?f=9&t=1011255 I remember this came up before, but I don't remember if we had identified a good reason for why we're storing the ids for @IndexedEmbedded objects? Cheers, Sanne _______________________________________________ hibernate-dev mailing list hibernate-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev

Hi, 2011/6/6 Emmanuel Bernard <emmanuel(a)hibernate.org&gt;: > Because somehow we need people to be able to index the id of embedded objects. But why, we don't ever use it right? Is the purpose to make it possible for people to include restrictions on the ids when creating queries?

> And at the time, I decided that automatically indexing them was harmless. > Either we stay as is or we add a specific annotation to ask for id indexing in embedded objects Wouldn't @Field work for such purpose?

Sanne > > Emmanuel > > On 3 juin 2011, at 14:42, Sanne Grinovero wrote: > >> About this post: >> https://forum.hibernate.org/viewtopic.php?f=9&t=1011255 >> >> I remember this came up before, but I don't remember if we had >> identified a good reason for why we're storing the ids for >> @IndexedEmbedded objects? >> >> Cheers, >> Sanne >> _______________________________________________ >> hibernate-dev mailing list >> hibernate-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/hibernate-dev > >

2011/6/6 Emmanuel Bernard <emmanuel(a)hibernate.org&gt;: > > On 6 juin 2011, at 11:29, Sanne Grinovero wrote: > >> Hi, >> >> 2011/6/6 Emmanuel Bernard <emmanuel(a)hibernate.org&gt;: >>> Because somehow we need people to be able to index the id of embedded objects. >> >> But why, we don't ever use it right? Is the purpose to make it >> possible for people to include restrictions on the ids when creating >> queries? > > yes > >> >>> And at the time, I decided that automatically indexing them was harmless. >>> Either we stay as is or we add a specific annotation to ask for id indexing in embedded objects >> >> Wouldn't @Field work for such purpose? >> > > Not entirely as it would index the id twice when the @Indexed @Entity is top level Right, so could we add an option to @DocumentId(includeWhenEmbedding=true) ? I'd have it default to "false", as while I agree that i might be of some use, I never needed it. >> Sanne >> >>> >>> Emmanuel >>> >>> On 3 juin 2011, at 14:42, Sanne Grinovero wrote: >>> >>>> About this post: >>>> https://forum.hibernate.org/viewtopic.php?f=9&t=1011255 >>>> >>>> I remember this came up before, but I don't remember if we had >>>> identified a good reason for why we're storing the ids for >>>> @IndexedEmbedded objects? >>>> >>>> Cheers, >>>> Sanne >>>> _______________________________________________ >>>> hibernate-dev mailing list >>>> hibernate-dev(a)lists.jboss.org >>>> https://lists.jboss.org/mailman/listinfo/hibernate-dev >>> >>> > >

2011/6/6 Emmanuel Bernard <emmanuel(a)hibernate.org&gt;: > That's a backward compatible change so it needs to be done in 4.0 That's why I'm proposing it now again. Would you agree on it? Sanne > On 6 juin 2011, at 11:58, Sanne Grinovero wrote: > >> 2011/6/6 Emmanuel Bernard <emmanuel(a)hibernate.org&gt;: >>> >>> On 6 juin 2011, at 11:29, Sanne Grinovero wrote: >>> >>>> Hi, >>>> >>>> 2011/6/6 Emmanuel Bernard <emmanuel(a)hibernate.org&gt;: >>>>> Because somehow we need people to be able to index the id of embedded objects. >>>> >>>> But why, we don't ever use it right? Is the purpose to make it >>>> possible for people to include restrictions on the ids when creating >>>> queries? >>> >>> yes >>> >>>> >>>>> And at the time, I decided that automatically indexing them was harmless. >>>>> Either we stay as is or we add a specific annotation to ask for id indexing in embedded objects >>>> >>>> Wouldn't @Field work for such purpose? >>>> >>> >>> Not entirely as it would index the id twice when the @Indexed @Entity is top level >> >> Right, so could we add an option to @DocumentId(includeWhenEmbedding=true) ? >> >> I'd have it default to "false", as while I agree that i might be of >> some use, I never needed it. >> >> >>>> Sanne >>>> >>>>> >>>>> Emmanuel >>>>> >>>>> On 3 juin 2011, at 14:42, Sanne Grinovero wrote: >>>>> >>>>>> About this post: >>>>>> https://forum.hibernate.org/viewtopic.php?f=9&t=1011255 >>>>>> >>>>>> I remember this came up before, but I don't remember if we had >>>>>> identified a good reason for why we're storing the ids for >>>>>> @IndexedEmbedded objects? >>>>>> >>>>>> Cheers, >>>>>> Sanne >>>>>> _______________________________________________ >>>>>> hibernate-dev mailing list >>>>>> hibernate-dev(a)lists.jboss.org >>>>>> https://lists.jboss.org/mailman/listinfo/hibernate-dev >>>>> >>>>> >>> >>> > >

I mean this setting being set to true (RE OGM).

On 6 juin 2011, at 12:31, Emmanuel Bernard wrote: > yep that's fine. I suspect this setting will be quite useful in Hibernate OGM's search engine though. > On 6 juin 2011, at 12:27, Sanne Grinovero wrote: > >> 2011/6/6 Emmanuel Bernard <emmanuel(a)hibernate.org&gt;: >>> That's a backward compatible change so it needs to be done in 4.0 >> >> That's why I'm proposing it now again. Would you agree on it? >> >> Sanne >> >>> On 6 juin 2011, at 11:58, Sanne Grinovero wrote: >>> >>>> 2011/6/6 Emmanuel Bernard <emmanuel(a)hibernate.org&gt;: >>>>> >>>>> On 6 juin 2011, at 11:29, Sanne Grinovero wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> 2011/6/6 Emmanuel Bernard <emmanuel(a)hibernate.org&gt;: >>>>>>> Because somehow we need people to be able to index the id of embedded objects. >>>>>> >>>>>> But why, we don't ever use it right? Is the purpose to make it >>>>>> possible for people to include restrictions on the ids when creating >>>>>> queries? >>>>> >>>>> yes >>>>> >>>>>> >>>>>>> And at the time, I decided that automatically indexing them was harmless. >>>>>>> Either we stay as is or we add a specific annotation to ask for id indexing in embedded objects >>>>>> >>>>>> Wouldn't @Field work for such purpose? >>>>>> >>>>> >>>>> Not entirely as it would index the id twice when the @Indexed @Entity is top level >>>> >>>> Right, so could we add an option to @DocumentId(includeWhenEmbedding=true) ? >>>> >>>> I'd have it default to "false", as while I agree that i might be of >>>> some use, I never needed it. >>>> >>>> >>>>>> Sanne >>>>>> >>>>>>> >>>>>>> Emmanuel >>>>>>> >>>>>>> On 3 juin 2011, at 14:42, Sanne Grinovero wrote: >>>>>>> >>>>>>>> About this post: >>>>>>>> https://forum.hibernate.org/viewtopic.php?f=9&t=1011255 >>>>>>>> >>>>>>>> I remember this came up before, but I don't remember if we had >>>>>>>> identified a good reason for why we're storing the ids for >>>>>>>> @IndexedEmbedded objects? >>>>>>>> >>>>>>>> Cheers, >>>>>>>> Sanne >>>>>>>> _______________________________________________ >>>>>>>> hibernate-dev mailing list >>>>>>>> hibernate-dev(a)lists.jboss.org >>>>>>>> https://lists.jboss.org/mailman/listinfo/hibernate-dev >>>>>>> >>>>>>> >>>>> >>>>> >>> >>> > > > _______________________________________________ > hibernate-dev mailing list > hibernate-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev

On 6 juin 2011, at 14:34, Sanne Grinovero wrote: > 2011/6/6 Emmanuel Bernard <emmanuel(a)hibernate.org&gt;: >> I mean this setting being set to true (RE OGM). > > I'm wondering how you would use that, and especially if you wouldn't > need the class type as well; you wouldn't need it today as all mapping > is static and so the type can be inferred from the owning > documentBuilder, but we had some plans to make this dynamic (not sure > yet?) so we might need to store the runtime type. > The id is unique within a class hierarchy that should be sufficient for most cases.