I'm seeing a bunch of core unit test failures on metamodel branch. Is anyone looking into these? org.hibernate.test.ops.SaveOrUpdateTest > testEvictThenSaveOrUpdate FAILED java.lang.AssertionError at SaveOrUpdateTest.java:467 org.hibernate.test.discriminator.DiscriminatorTest > testAccessAsIncorrectSubclass FAILED org.hibernate.exception.SQLGrammarException at DiscriminatorTest.java:137 Caused by: org.h2.jdbc.JdbcSQLException at DiscriminatorTest.java:137 org.hibernate.test.discriminator.DiscriminatorTest > testDiscriminatorSubclass FAILED org.hibernate.exception.SQLGrammarException at DiscriminatorTest.java:86 Caused by: org.h2.jdbc.JdbcSQLException at DiscriminatorTest.java:86 org.hibernate.test.discriminator.DiscriminatorTest > testLoadSuperclassProxyEvictPolymorphicAccess FAILED org.hibernate.exception.SQLGrammarException at DiscriminatorTest.java:258 Caused by: org.h2.jdbc.JdbcSQLException at DiscriminatorTest.java:258 org.hibernate.test.discriminator.DiscriminatorTest > testLoadSuperclassProxyPolymorphicAccess FAILED org.hibernate.exception.SQLGrammarException at DiscriminatorTest.java:214 Caused by: org.h2.jdbc.JdbcSQLException at DiscriminatorTest.java:214 org.hibernate.test.discriminator.DiscriminatorTest > testQuerySubclassAttribute FAILED org.hibernate.exception.SQLGrammarException at DiscriminatorTest.java:173 Caused by: org.h2.jdbc.JdbcSQLException at DiscriminatorTest.java:173 org.hibernate.test.bidi.AuctionTest2 > testLazy FAILED org.hibernate.exception.SQLGrammarException at AuctionTest2.java:83 Caused by: org.h2.jdbc.JdbcSQLException at AuctionTest2.java:83 org.hibernate.test.where.WhereTest > testWhere FAILED java.lang.AssertionError at WhereTest.java:62 org.hibernate.test.annotations.cid.keymanytoone.EagerKeyManyToOneTest > testLoadEntityWithEagerFetchingToKeyManyToOneReferenceBackToSelf FAILED org.hibernate.testing.junit4.CallbackException Caused by: java.lang.IllegalStateException org.hibernate.test.version.VersionTest > testCollectionNoVersion FAILED org.hibernate.exception.ConstraintViolationException at VersionTest.java:150 Caused by: org.h2.jdbc.JdbcSQLException at VersionTest.java:150 org.hibernate.test.version.VersionTest > testCollectionVersion FAILED java.lang.AssertionError at VersionTest.java:105 org.hibernate.test.naturalid.immutable.ImmutableEntityNaturalIdTest > testSaveParentWithDetachedChildren FAILED org.hibernate.exception.ConstraintViolationException at ImmutableEntityNaturalIdTest.java:134 Caused by: org.h2.jdbc.JdbcSQLException at ImmutableEntityNaturalIdTest.java:134 org.hibernate.test.cascade.BidirectionalOneToManyCascadeTest > testSaveChildWithParent FAILED java.lang.AssertionError at BidirectionalOneToManyCascadeTest.java:100 org.hibernate.test.cascade.BidirectionalOneToManyCascadeTest > testSaveOrphanDeleteChildWithParent FAILED java.lang.AssertionError at BidirectionalOneToManyCascadeTest.java:155 org.hibernate.test.cascade.BidirectionalOneToManyCascadeTest > testSaveParentWithChild FAILED java.lang.AssertionError at BidirectionalOneToManyCascadeTest.java:74 org.hibernate.test.cascade.BidirectionalOneToManyCascadeTest > testSaveParentWithOrphanDeleteChild FAILED java.lang.AssertionError at BidirectionalOneToManyCascadeTest.java:128 org.hibernate.test.cascade.CascadeTestWithAssignedParentIdTest > testSaveChildWithParent FAILED java.lang.AssertionError at CascadeTestWithAssignedParentIdTest.java:69 org.hibernate.test.nonflushedchanges.SaveOrUpdateTest > testEvictThenSaveOrUpdate FAILED java.lang.AssertionError at SaveOrUpdateTest.java:525 org.hibernate.test.readonly.ReadOnlyVersionedNodesTest > testAddNewChildToReadOnlyParent FAILED java.lang.AssertionError at ReadOnlyVersionedNodesTest.java:293 org.hibernate.test.readonly.ReadOnlyVersionedNodesTest > testGetParentMakeReadOnlyThenMergeDetachedParentWithNewChildC FAILED java.lang.AssertionError at ReadOnlyVersionedNodesTest.java:429 org.hibernate.test.readonly.ReadOnlyVersionedNodesTest > testMergeDetachedParentWithNewChildCommitWithReadOnlyParent FAILED java.lang.AssertionError at ReadOnlyVersionedNodesTest.java:380 org.hibernate.test.readonly.ReadOnlyVersionedNodesTest > testMergeUnchangedDetachedParentChildren FAILED java.lang.AssertionError at ReadOnlyVersionedNodesTest.java:493 org.hibernate.test.readonly.ReadOnlyVersionedNodesTest > testUpdateParentWithNewChildCommitWithReadOnlyParent FAILED java.lang.AssertionError at ReadOnlyVersionedNodesTest.java:333 org.hibernate.metamodel.internal.source.AssertSourcesTest > testUserEntitySources FAILED java.lang.AssertionError at AssertSourcesTest.java:107 org.hibernate.metamodel.internal.source.annotations.entity.TemporalBindingTest > testNoTemporalAnnotationOnTemporalTypeAttribute FAILED java.lang.AssertionError org.hibernate.metamodel.internal.source.annotations.entity.NaturalIdBindingTests > testAssociationNaturalIdBinding FAILED java.lang.AssertionError at NaturalIdBindingTests.java:205 org.hibernate.metamodel.internal.source.annotations.entity.InheritanceBindingTest > testRootPolymporphism FAILED junit.framework.AssertionFailedError at InheritanceBindingTest.java:168 org.hibernate.metamodel.spi.binding.BasicHbmBindingTests > testEntityWithManyToOneMapping FAILED java.lang.AssertionError 3774 tests completed, 28 failed, 94 skipped _______________________________________________ hibernate-dev mailing list hibernate-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev

Many of those are related to HHH-7663 ("ManyToOne column names incorrect"). There were some fixes I made last week (especially in the discriminator area) that exposed the issue. Should @FailureExpectedWithNewMetamodels be added, or can we hold off shortly until 7663 is addressed? ----- Original Message ----- From: "Gail Badner" <gbadner(a)redhat.com&gt; To: "Hibernate hibernate-dev" <hibernate-dev(a)lists.jboss.org&gt; Sent: Tuesday, October 9, 2012 1:25:01 AM Subject: [hibernate-dev] Failing unit tests on metamodel branch I'm seeing a bunch of core unit test failures on metamodel branch. Is anyone looking into these? org.hibernate.test.ops.SaveOrUpdateTest > testEvictThenSaveOrUpdate FAILED java.lang.AssertionError at SaveOrUpdateTest.java:467 org.hibernate.test.discriminator.DiscriminatorTest > testAccessAsIncorrectSubclass FAILED org.hibernate.exception.SQLGrammarException at DiscriminatorTest.java:137 Caused by: org.h2.jdbc.JdbcSQLException at DiscriminatorTest.java:137 org.hibernate.test.discriminator.DiscriminatorTest > testDiscriminatorSubclass FAILED org.hibernate.exception.SQLGrammarException at DiscriminatorTest.java:86 Caused by: org.h2.jdbc.JdbcSQLException at DiscriminatorTest.java:86 org.hibernate.test.discriminator.DiscriminatorTest > testLoadSuperclassProxyEvictPolymorphicAccess FAILED org.hibernate.exception.SQLGrammarException at DiscriminatorTest.java:258 Caused by: org.h2.jdbc.JdbcSQLException at DiscriminatorTest.java:258 org.hibernate.test.discriminator.DiscriminatorTest > testLoadSuperclassProxyPolymorphicAccess FAILED org.hibernate.exception.SQLGrammarException at DiscriminatorTest.java:214 Caused by: org.h2.jdbc.JdbcSQLException at DiscriminatorTest.java:214 org.hibernate.test.discriminator.DiscriminatorTest > testQuerySubclassAttribute FAILED org.hibernate.exception.SQLGrammarException at DiscriminatorTest.java:173 Caused by: org.h2.jdbc.JdbcSQLException at DiscriminatorTest.java:173 org.hibernate.test.bidi.AuctionTest2 > testLazy FAILED org.hibernate.exception.SQLGrammarException at AuctionTest2.java:83 Caused by: org.h2.jdbc.JdbcSQLException at AuctionTest2.java:83 org.hibernate.test.where.WhereTest > testWhere FAILED java.lang.AssertionError at WhereTest.java:62 org.hibernate.test.annotations.cid.keymanytoone.EagerKeyManyToOneTest > testLoadEntityWithEagerFetchingToKeyManyToOneReferenceBackToSelf FAILED org.hibernate.testing.junit4.CallbackException Caused by: java.lang.IllegalStateException org.hibernate.test.version.VersionTest > testCollectionNoVersion FAILED org.hibernate.exception.ConstraintViolationException at VersionTest.java:150 Caused by: org.h2.jdbc.JdbcSQLException at VersionTest.java:150 org.hibernate.test.version.VersionTest > testCollectionVersion FAILED java.lang.AssertionError at VersionTest.java:105 org.hibernate.test.naturalid.immutable.ImmutableEntityNaturalIdTest > testSaveParentWithDetachedChildren FAILED org.hibernate.exception.ConstraintViolationException at ImmutableEntityNaturalIdTest.java:134 Caused by: org.h2.jdbc.JdbcSQLException at ImmutableEntityNaturalIdTest.java:134 org.hibernate.test.cascade.BidirectionalOneToManyCascadeTest > testSaveChildWithParent FAILED java.lang.AssertionError at BidirectionalOneToManyCascadeTest.java:100 org.hibernate.test.cascade.BidirectionalOneToManyCascadeTest > testSaveOrphanDeleteChildWithParent FAILED java.lang.AssertionError at BidirectionalOneToManyCascadeTest.java:155 org.hibernate.test.cascade.BidirectionalOneToManyCascadeTest > testSaveParentWithChild FAILED java.lang.AssertionError at BidirectionalOneToManyCascadeTest.java:74 org.hibernate.test.cascade.BidirectionalOneToManyCascadeTest > testSaveParentWithOrphanDeleteChild FAILED java.lang.AssertionError at BidirectionalOneToManyCascadeTest.java:128 org.hibernate.test.cascade.CascadeTestWithAssignedParentIdTest > testSaveChildWithParent FAILED java.lang.AssertionError at CascadeTestWithAssignedParentIdTest.java:69 org.hibernate.test.nonflushedchanges.SaveOrUpdateTest > testEvictThenSaveOrUpdate FAILED java.lang.AssertionError at SaveOrUpdateTest.java:525 org.hibernate.test.readonly.ReadOnlyVersionedNodesTest > testAddNewChildToReadOnlyParent FAILED java.lang.AssertionError at ReadOnlyVersionedNodesTest.java:293 org.hibernate.test.readonly.ReadOnlyVersionedNodesTest > testGetParentMakeReadOnlyThenMergeDetachedParentWithNewChildC FAILED java.lang.AssertionError at ReadOnlyVersionedNodesTest.java:429 org.hibernate.test.readonly.ReadOnlyVersionedNodesTest > testMergeDetachedParentWithNewChildCommitWithReadOnlyParent FAILED java.lang.AssertionError at ReadOnlyVersionedNodesTest.java:380 org.hibernate.test.readonly.ReadOnlyVersionedNodesTest > testMergeUnchangedDetachedParentChildren FAILED java.lang.AssertionError at ReadOnlyVersionedNodesTest.java:493 org.hibernate.test.readonly.ReadOnlyVersionedNodesTest > testUpdateParentWithNewChildCommitWithReadOnlyParent FAILED java.lang.AssertionError at ReadOnlyVersionedNodesTest.java:333 org.hibernate.metamodel.internal.source.AssertSourcesTest > testUserEntitySources FAILED java.lang.AssertionError at AssertSourcesTest.java:107 org.hibernate.metamodel.internal.source.annotations.entity.TemporalBindingTest > testNoTemporalAnnotationOnTemporalTypeAttribute FAILED java.lang.AssertionError org.hibernate.metamodel.internal.source.annotations.entity.NaturalIdBindingTests > testAssociationNaturalIdBinding FAILED java.lang.AssertionError at NaturalIdBindingTests.java:205 org.hibernate.metamodel.internal.source.annotations.entity.InheritanceBindingTest > testRootPolymporphism FAILED junit.framework.AssertionFailedError at InheritanceBindingTest.java:168 org.hibernate.metamodel.spi.binding.BasicHbmBindingTests > testEntityWithManyToOneMapping FAILED java.lang.AssertionError 3774 tests completed, 28 failed, 94 skipped _______________________________________________ hibernate-dev mailing list hibernate-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev _______________________________________________ hibernate-dev mailing list hibernate-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev

From: "Strong Liu" <stliu(a)hibernate.org&gt; To: "Hibernate hibernate-dev" <hibernate-dev(a)lists.jboss.org&gt; Sent: Tuesday, October 9, 2012 10:15:14 AM Subject: Re: [hibernate-dev] Failing unit tests on metamodel branch On Oct 10, 2012, at 12:54 AM, Strong Liu <stliu(a)hibernate.org&gt; wrote: > I just pushed a fix ( well, rollback one of my change ) and now > only 9 failures left > > > org.hibernate.test.collection.bag.PersistentBagTest > classMethod > FAILED > org.hibernate.testing.junit4.CallbackException > Caused by: > org.hibernate.tool.schema.spi.SchemaManagementException > > org.hibernate.test.collection.list.PersistentListTest > classMethod > FAILED > org.hibernate.testing.junit4.CallbackException > Caused by: > org.hibernate.tool.schema.spi.SchemaManagementException > > org.hibernate.test.reattachment.CollectionReattachmentTest > > classMethod FAILED > org.hibernate.testing.junit4.CallbackException > Caused by: > org.hibernate.tool.schema.spi.SchemaManagementException > > org.hibernate.test.reattachment.ProxyReattachmentTest > classMethod > FAILED > org.hibernate.testing.junit4.CallbackException > Caused by: > org.hibernate.tool.schema.spi.SchemaManagementException > > org.hibernate.test.sql.autodiscovery.AutoDiscoveryTest > > testDialectGetColumnAliasExtractor > FAILED > org.hibernate.exception.SQLGrammarException at > AutoDiscoveryTest.java:124 > Caused by: org.h2.jdbc.JdbcSQLException at > AutoDiscoveryTest.java:124 > > org.hibernate.test.sql.autodiscovery.AutoDiscoveryTest > > testSqlQueryAutoDiscovery > FAILED > org.hibernate.exception.SQLGrammarException at > AutoDiscoveryTest.java:104 > Caused by: org.h2.jdbc.JdbcSQLException at > AutoDiscoveryTest.java:104 > > > > ############ above are caused by @FailureExpectedWithNewMetamodel > removed in c73162270a5f9a15c80b4d25811e312c554781a8 > > org.hibernate.metamodel.internal.source.annotations.entity.TemporalBindingTest > > testNoTemporalAnnotationOnTemporalTypeAttribute > FAILED > java.lang.AssertionError > > ############ caused by change in HHH-7655, code changed but test > not updated > > > org.hibernate.metamodel.internal.source.AssertSourcesTest > > testUserEntitySources > FAILED > java.lang.AssertionError at AssertSourcesTest.java:107 > > org.hibernate.metamodel.internal.source.annotations.entity.InheritanceBindingTest > > testRootPolymporphism > FAILED > junit.framework.AssertionFailedError at > InheritanceBindingTest.java:168 > > ############ too late now, leave them for tomorrow :) ########## okay, these two are failed from commit 691463578b6d09c9f1932ac3863ebc9531da00db > > > > > > On Oct 10, 2012, at 12:22 AM, Brett Meyer <brmeyer(a)redhat.com&gt; > wrote: > >> Many of those are related to HHH-7663 ("ManyToOne column names >> incorrect"). There were some fixes I made last week (especially >> in the discriminator area) that exposed the issue. Should >> @FailureExpectedWithNewMetamodels be added, or can we hold off >> shortly until 7663 is addressed? >> >> ----- Original Message ----- >> From: "Gail Badner" <gbadner(a)redhat.com&gt; >> To: "Hibernate hibernate-dev" <hibernate-dev(a)lists.jboss.org&gt; >> Sent: Tuesday, October 9, 2012 1:25:01 AM >> Subject: [hibernate-dev] Failing unit tests on metamodel branch >> >> I'm seeing a bunch of core unit test failures on metamodel branch. >> Is anyone looking into these? >> >> org.hibernate.test.ops.SaveOrUpdateTest > >> testEvictThenSaveOrUpdate FAILED >> java.lang.AssertionError at SaveOrUpdateTest.java:467 >> >> org.hibernate.test.discriminator.DiscriminatorTest > >> testAccessAsIncorrectSubclass FAILED >> org.hibernate.exception.SQLGrammarException at >> DiscriminatorTest.java:137 >> Caused by: org.h2.jdbc.JdbcSQLException at >> DiscriminatorTest.java:137 >> >> org.hibernate.test.discriminator.DiscriminatorTest > >> testDiscriminatorSubclass FAILED >> org.hibernate.exception.SQLGrammarException at >> DiscriminatorTest.java:86 >> Caused by: org.h2.jdbc.JdbcSQLException at >> DiscriminatorTest.java:86 >> >> org.hibernate.test.discriminator.DiscriminatorTest > >> testLoadSuperclassProxyEvictPolymorphicAccess >> FAILED >> org.hibernate.exception.SQLGrammarException at >> DiscriminatorTest.java:258 >> Caused by: org.h2.jdbc.JdbcSQLException at >> DiscriminatorTest.java:258 >> >> org.hibernate.test.discriminator.DiscriminatorTest > >> testLoadSuperclassProxyPolymorphicAccess >> FAILED >> org.hibernate.exception.SQLGrammarException at >> DiscriminatorTest.java:214 >> Caused by: org.h2.jdbc.JdbcSQLException at >> DiscriminatorTest.java:214 >> >> org.hibernate.test.discriminator.DiscriminatorTest > >> testQuerySubclassAttribute FAILED >> org.hibernate.exception.SQLGrammarException at >> DiscriminatorTest.java:173 >> Caused by: org.h2.jdbc.JdbcSQLException at >> DiscriminatorTest.java:173 >> >> org.hibernate.test.bidi.AuctionTest2 > testLazy FAILED >> org.hibernate.exception.SQLGrammarException at >> AuctionTest2.java:83 >> Caused by: org.h2.jdbc.JdbcSQLException at >> AuctionTest2.java:83 >> >> org.hibernate.test.where.WhereTest > testWhere FAILED >> java.lang.AssertionError at WhereTest.java:62 >> >> org.hibernate.test.annotations.cid.keymanytoone.EagerKeyManyToOneTest >> > >> testLoadEntityWithEagerFetchingToKeyManyToOneReferenceBackToSelf >> FAILED >> org.hibernate.testing.junit4.CallbackException >> Caused by: java.lang.IllegalStateException >> >> org.hibernate.test.version.VersionTest > testCollectionNoVersion >> FAILED >> org.hibernate.exception.ConstraintViolationException at >> VersionTest.java:150 >> Caused by: org.h2.jdbc.JdbcSQLException at >> VersionTest.java:150 >> >> org.hibernate.test.version.VersionTest > testCollectionVersion >> FAILED >> java.lang.AssertionError at VersionTest.java:105 >> >> org.hibernate.test.naturalid.immutable.ImmutableEntityNaturalIdTest >> > testSaveParentWithDetachedChildren >> FAILED >> org.hibernate.exception.ConstraintViolationException at >> ImmutableEntityNaturalIdTest.java:134 >> Caused by: org.h2.jdbc.JdbcSQLException at >> ImmutableEntityNaturalIdTest.java:134 >> >> org.hibernate.test.cascade.BidirectionalOneToManyCascadeTest > >> testSaveChildWithParent FAILED >> java.lang.AssertionError at >> BidirectionalOneToManyCascadeTest.java:100 >> >> org.hibernate.test.cascade.BidirectionalOneToManyCascadeTest > >> testSaveOrphanDeleteChildWithParent FAILED >> java.lang.AssertionError at >> BidirectionalOneToManyCascadeTest.java:155 >> >> org.hibernate.test.cascade.BidirectionalOneToManyCascadeTest > >> testSaveParentWithChild FAILED >> java.lang.AssertionError at >> BidirectionalOneToManyCascadeTest.java:74 >> >> org.hibernate.test.cascade.BidirectionalOneToManyCascadeTest > >> testSaveParentWithOrphanDeleteChild FAILED >> java.lang.AssertionError at >> BidirectionalOneToManyCascadeTest.java:128 >> >> org.hibernate.test.cascade.CascadeTestWithAssignedParentIdTest > >> testSaveChildWithParent FAILED >> java.lang.AssertionError at >> CascadeTestWithAssignedParentIdTest.java:69 >> >> org.hibernate.test.nonflushedchanges.SaveOrUpdateTest > >> testEvictThenSaveOrUpdate FAILED >> java.lang.AssertionError at SaveOrUpdateTest.java:525 >> >> org.hibernate.test.readonly.ReadOnlyVersionedNodesTest > >> testAddNewChildToReadOnlyParent FAILED >> java.lang.AssertionError at ReadOnlyVersionedNodesTest.java:293 >> >> org.hibernate.test.readonly.ReadOnlyVersionedNodesTest > >> testGetParentMakeReadOnlyThenMergeDetachedParentWithNewChildC >> FAILED >> java.lang.AssertionError at ReadOnlyVersionedNodesTest.java:429 >> >> org.hibernate.test.readonly.ReadOnlyVersionedNodesTest > >> testMergeDetachedParentWithNewChildCommitWithReadOnlyParent >> FAILED >> java.lang.AssertionError at ReadOnlyVersionedNodesTest.java:380 >> >> org.hibernate.test.readonly.ReadOnlyVersionedNodesTest > >> testMergeUnchangedDetachedParentChildren FAILED >> java.lang.AssertionError at ReadOnlyVersionedNodesTest.java:493 >> >> org.hibernate.test.readonly.ReadOnlyVersionedNodesTest > >> testUpdateParentWithNewChildCommitWithReadOnlyParent >> FAILED >> java.lang.AssertionError at ReadOnlyVersionedNodesTest.java:333 >> >> org.hibernate.metamodel.internal.source.AssertSourcesTest > >> testUserEntitySources FAILED >> java.lang.AssertionError at AssertSourcesTest.java:107 >> >> org.hibernate.metamodel.internal.source.annotations.entity.TemporalBindingTest >> > testNoTemporalAnnotationOnTemporalTypeAttribute >> FAILED >> java.lang.AssertionError >> >> org.hibernate.metamodel.internal.source.annotations.entity.NaturalIdBindingTests >> > testAssociationNaturalIdBinding >> FAILED >> java.lang.AssertionError at NaturalIdBindingTests.java:205 >> >> org.hibernate.metamodel.internal.source.annotations.entity.InheritanceBindingTest >> > testRootPolymporphism >> FAILED >> junit.framework.AssertionFailedError at >> InheritanceBindingTest.java:168 >> >> org.hibernate.metamodel.spi.binding.BasicHbmBindingTests > >> testEntityWithManyToOneMapping FAILED >> java.lang.AssertionError >> >> 3774 tests completed, 28 failed, 94 skipped >> >> _______________________________________________ >> hibernate-dev mailing list >> hibernate-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/hibernate-dev >> _______________________________________________ >> hibernate-dev mailing list >> hibernate-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/hibernate-dev > > ------------------------- > Best Regards, > > Strong Liu <stliu at hibernate.org> > http://about.me/stliu/bio > ------------------------- Best Regards, Strong Liu <stliu at hibernate.org> http://about.me/stliu/bio _______________________________________________ hibernate-dev mailing list hibernate-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev