11:15 a.m.
Hello,
I really wanted to merge my super-trivial patch using the new JUnit4
capabilities, but I'm having some issues in building core.
1)IntelliJ
(after solving the OOM issues with the annotation processor)
It doesn't find the ANTLR generated files, hence I can't run my test
as it has a compile failure.
2)Eclipse
the configuration files generated by gradle are totally wrong, but I
could fix them by hand.
Now Eclipse refuses to compile the project as there's a circular dependency:
the testsuite from hibernate-core depends on the hibernate-testing
module, which in turn depends on hibernate-core.
This doesn't look right, I guess we should merge this module back into
hibernate-core?
Reopening in IntelliJ to figure out why it seemed to almost work there:
In fact, it's showing a warning about circular dependencies, but
somehow it can work around it.
3) Command line
./gradlew clean build
Gets me 100 compile errors, related to the usage of @Override in the
generated code, I guess Gradle could also somehow could workaround the
dependency circularity but didn't set the compiler to Java6
compatibility:
TestLogger_$logger.java:515: method does not override or implement a
method from a supertype
@Override
^
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
100 errors
FAILURE: Build failed with an exception.
Suggestions? Is it working fine for everyone else?
Cheers,
Sanne
11:45 a.m.
On Wednesday, March 16, 2011, at 10:15 am, Sanne Grinovero wrote:
Same thing with the older Maven builds. You have to
manually run the antlr
generation task. You could set that up to run on build, but personally I
prefer to run that stuff manaully when needed. Up to you.
By the way, same in eclipse.
This was
intentional. Both gradle and intellij can handle this. I asked max
and he said that such a set up was in some way workable.
I dont understand what is so foreign about this "circularity". Look at it at
the task level. You compile hibernate-core/src/main; you compile hibernate-
testing/src/main; you compile hibernate-core/src/test. Yes there is
"circularity" if you look strictly at this in terms of modules. But in terms
of tasks and source sets there is not.
Make sure the dep in hibernate-core on
hibernate-testing is "Compile" scope.
Are you running gradle with Java 6?
---
Steve Ebersole <steve(a)hibernate.org>
http://hibernate.org
12:09 p.m.
Thanks didn't know it needed a manual step. Actually in eclipse it was
generated automatically by triggering Maven's ANTLR plugin, and I expected IDEA
to have something similar.
I might have backed off from IDEA quickly returning to command line /
Eclipse alternatives as I'm not comfortable with it's interface yet.
Yes that seems a resonable plan if you look at it as being three modules.
But eclipse is having a different concept, if will join the classpath
of test and main of each project, so it creates a two way dependency
and then bails out with critical complaints.
I guess IDEA is much smarted but it still provides a warning.
I didn't change any code, this is the master state as opened in Idea
after "./gradlew idea"
Can't get that wrong as I don't have Java5 on my disk.
thanks you for the ideas, setting up antlr in IDEA is good enough for now.
Sanne
1:19 p.m.
On Wednesday, March 16, 2011, at 11:09 am, Sanne Grinovero wrote:
In
IntelliJ (no clue about eclipse) that is true depending on the tasks you
tell it to run on (re)import if using the Maven project imprt stuff. You
could tell IntelliJ to run a certain Maven goal or phase before compilation of
a module, but thats what I never ever set up as it made compiling in the IDE
painfully slow for the 80% case. If I changed the Antlr grammars I just
manually reran the Antlr generation tools.
Btw, if you like that model you can do the same with IntelliJ + Gradle using
either "external tools" or the Gradle UI plugin.
---
Steve Ebersole <steve(a)hibernate.org>
http://hibernate.org
6:14 a.m.
I said it was probably possibly to workaround/hack, but I did not at all recommend it.
It's a broken setup IMO.
There is of project dependencies - which is the level eclipse is working on.
Just because the compile setup is possible doesn't make it right IMO.
/max
http://about.me/maxandersen
9:28 a.m.
Just because eclipse might not like it does not make it broken ;)
On Thursday, March 31, 2011, at 05:14 am, Max Rydahl Andersen wrote:
---
Steve Ebersole <steve(a)hibernate.org>
http://hibernate.org
12:52 p.m.
On Mar 31, 2011, at 15:28, Steve Ebersole wrote:
Just because eclipse might not like it does not make it broken ;)
It's your choice to make it hard to develop on Hibernate core in Eclipse.
You can fix it on Hibernate side - I can't fix Eclipse core fundamentals.
/max
/max
http://about.me/maxandersen
1:32 p.m.
On Thursday, March 31, 2011, at 11:52 am, Max Rydahl Andersen wrote:
Thats one way to look at it. One point of view. Of course a just as valid
point of view is that Eclipse is making it difficult.
You can fix it on Hibernate side - I can't fix Eclipse core fundamentals.
Well as John already said, he was able to verify that it does in fact work in
Eclipse. So obviously *they* don't think its a broken set up. Thats just
your opinion. Perhaps maybe the concern is that it possibly does not work in
JBoss Tools...
---
Steve Ebersole <steve(a)hibernate.org>
http://hibernate.org
2:07 p.m.
2011/3/31 Steve Ebersole <steve(a)hibernate.org>:
It's actually broken on any Eclipse, nothing to do with JBoss Tools.
I doubt Max's point of view is "one point", we're scoring at least two
already.
Possibly a large part of eclipse users aren't going to be as lucky as John was,
I have no idea how comes it works fine for him, whatever trick he's
using it would be nice to have gradle generate his configuration.
1:07 a.m.
It's not a configuration issue, rather a preference setting to
turn off the warning about cyclic dependencies: Preferences > Java > Compilter >
Building > Build Path Problems > Circular Dependencies > Warning
If thats enough thats great....but there is a reason eclipse has that as an Error.
But since we have different opinions on consequences and effects of cyclic dependencies
i'll just leave it at that.
/max
/max
http://about.me/maxandersen
1:03 a.m.
5109
days inactive
5125
days old
11 comments
4 participants
participants (4)
-
John Verhaeg -
Max Rydahl Andersen -
Sanne Grinovero -
Steve Ebersole