adding the mailing list back. Other datastores use the same approach as you so we need to eb consistent On Wed 2014-05-14 11:22, Davide D'Alto wrote: > Neo4jSequenceGenerator and Neo4jTypeConverter were the result of some code > that I've extracted from the dialect. > Initially I didn't expect them to be used somewhere else outside the > dialect. > > Sounds good to me to move them to a separate package. > > > On Wed, May 14, 2014 at 8:08 AM, Emmanuel Bernard < emmanuel(a)hibernate.org&gt;wrote: > > > It does not make a huge difference as these are in impl packages but I > > wonder if somebody has a specific reasoning for putting types > > (converters) and sequence generators inside the dialect package? > > > > Granted they are wired in the dialect but in practice they are used by > > the code base at large. I think naturally I would ahve put them under > > > > o.h.o.datastore.somenosql.type / generator or idgenerator > > _______________________________________________ > > hibernate-dev mailing list > > hibernate-dev(a)lists.jboss.org > > https://lists.jboss.org/mailman/listinfo/hibernate-dev > > _______________________________________________ hibernate-dev mailing list hibernate-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev