Hi, I plan on adding the JPA 2.2 Query#getResultStream() method since we already support streaming and, this way, Hibernate 5.2 will work even if the client has a JPA 2.2 dependency in their classpath. https://jcp.org/aboutJava/communityprocess/maintenance/jsr338/ChangeLog-J... While we can allow the 6.0 release to be fully JPA 2.2 compliant, is there anyone against adding the aforementioned change in 5.2 as well? Vlad

You don't plan on actually updating the JPA API we use at build time

On 2 August 2017 at 15:21, Vlad Mihalcea <mihalcea.vlad(a)gmail.com&gt; wrote: > Hi, > > I plan on adding the JPA 2.2 Query#getResultStream() method since we > already support streaming and, > this way, Hibernate 5.2 will work even if the client has a JPA 2.2 > dependency in their classpath. > > https://jcp.org/aboutJava/communityprocess/maintenance/ jsr338/ChangeLog-JPA-2.2-MR.txt > > While we can allow the 6.0 release to be fully JPA 2.2 compliant, is there > anyone against adding the aforementioned change in 5.2 as well? > > Vlad Such a change would break Hibernate Search integration. I'm not strictly against it as we can catch up on the Search side, but it introduces a burden for end users to be aware of which precise versions they will need: typically we promise that any "micro" in the same major.minor will be compatible, so we'd be violating this rule. Anyone not using this method would be unaffected so this seems a very minor point but I think the "stick to the rules" part is more valuable to keep people from worrying. On which interfaces do you plan adding this method exactly? You don't plan on actually updating the JPA API we use at build time right? Thanks, Sanne _______________________________________________ hibernate-dev mailing list hibernate-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev

On 2 August 2017 at 17:07, Gunnar Morling <gunnar(a)hibernate.org&gt; wrote: >> You don't plan on actually updating the JPA API we use at build time >> right? > > We cannot do that, you may not provide a version of a spec'ed API with > additional methods. It'd have to be in ORM's sub-interface or similar. The new spec'ed API already has this method.

On 2 August 2017 at 18:40, Gunnar Morling <gunnar(a)hibernate.org&gt; wrote: > Sure, but you may not publish something like an JPA 2.1+ with just some of > the 2.2 methods. Sure, I never proposed that. Just *asked* some clarifications ;) > > 2017-08-02 17:40 GMT+01:00 Sanne Grinovero <sanne(a)hibernate.org&gt;: >> >> On 2 August 2017 at 17:07, Gunnar Morling <gunnar(a)hibernate.org&gt; wrote: >> >> You don't plan on actually updating the JPA API we use at build time >> >> right? >> > >> > We cannot do that, you may not provide a version of a spec'ed API with >> > additional methods. It'd have to be in ORM's sub-interface or similar. >> >> The new spec'ed API already has this method. > > _______________________________________________ hibernate-dev mailing list hibernate-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev

I've never considered changing the dependencies in any way.

Sure, but you may not publish something like an JPA 2.1+ with just some of > the 2.2 methods. I don't understand this part because, for instance, we already support Java 1.8 Date/Time types for quite some time. So, Hibernate 5.x already supports JPA 2.1 +. The 5.1 Stream support is also in the JPA 2.1+ category too. The only difference is that the method is called stream and not getStreamResult. Now, back to the org.hibernate.query.Query method: default Stream<R> getResultStream() { return stream(); } Even if the JPA 2.2 define this method, we can still implement it as a default method and that will work for both JPA 2.1 and JPA 2.2, right? I've never considered changing the dependencies in any way. It's just this method that makes it easier to use Hibernate 5.2 with both JPA 2.1 and JPA 2.2 API. Vlad On Wed, Aug 2, 2017 at 8:40 PM, Gunnar Morling <gunnar(a)hibernate.org&gt; wrote: > Sure, but you may not publish something like an JPA 2.1+ with just some > of the 2.2 methods. > > 2017-08-02 17:40 GMT+01:00 Sanne Grinovero <sanne(a)hibernate.org&gt;: > >> On 2 August 2017 at 17:07, Gunnar Morling <gunnar(a)hibernate.org&gt; wrote: >> >> You don't plan on actually updating the JPA API we use at build time >> >> right? >> > >> > We cannot do that, you may not provide a version of a spec'ed API with >> > additional methods. It'd have to be in ORM's sub-interface or similar. >> >> The new spec'ed API already has this method. >> > >

I added this Pull Request, and, if it gets approved, we could integrate it for 5.2.11 https://github.com/hibernate/hibernate-orm/pull/1973 On Thu, Aug 3, 2017 at 10:47 AM, Gunnar Morling <gunnar(a)hibernate.org&gt; wrote: > > I've never considered changing the dependencies in any way. > > Cool, we're all on the same page then. > > 2017-08-02 21:16 GMT+01:00 Vlad Mihalcea <mihalcea.vlad(a)gmail.com&gt;: > >> Sure, but you may not publish something like an JPA 2.1+ with just some >>> of the 2.2 methods. >> >> >> I don't understand this part because, for instance, we already support >> Java 1.8 Date/Time types for quite some time. So, Hibernate 5.x already >> supports JPA 2.1 +. >> >> The 5.1 Stream support is also in the JPA 2.1+ category too. The only >> difference is that the method is called stream and not getStreamResult. >> >> Now, back to the org.hibernate.query.Query method: >> >> default Stream<R> getResultStream() { >> return stream(); >> } >> >> >> Even if the JPA 2.2 define this method, we can still implement it as a >> default method and that will work for both JPA 2.1 and JPA 2.2, right? >> >> I've never considered changing the dependencies in any way. It's just >> this method that makes it easier to use Hibernate 5.2 with both JPA 2.1 and >> JPA 2.2 API. >> >> Vlad >> >> On Wed, Aug 2, 2017 at 8:40 PM, Gunnar Morling <gunnar(a)hibernate.org&gt; >> wrote: >> >>> Sure, but you may not publish something like an JPA 2.1+ with just some >>> of the 2.2 methods. >>> >>> 2017-08-02 17:40 GMT+01:00 Sanne Grinovero <sanne(a)hibernate.org&gt;: >>> >>>> On 2 August 2017 at 17:07, Gunnar Morling <gunnar(a)hibernate.org&gt; wrote: >>>> >> You don't plan on actually updating the JPA API we use at build time >>>> >> right? >>>> > >>>> > We cannot do that, you may not provide a version of a spec'ed API with >>>> > additional methods. It'd have to be in ORM's sub-interface or similar. >>>> >>>> The new spec'ed API already has this method. >>>> >>> >>> >> > _______________________________________________ hibernate-dev mailing list hibernate-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev