3:40 p.m.
Hi,
While playing with ElasticSearch faceting (and having tests failing due to
that), I noticed that for Longs and Dates, the preexisting range faceting
doesn't take into account facetRequest.hasZeroCountsIncluded().
See
https://github.com/hibernate/hibernate-search/blob/master/engine/src/main...
and a few lines below for floating point ranges which take into account
this very parameter.
Is this something expected? Should I prepare a PR to fix it?
--
Guillaume
9:15 a.m.
It's probably a bug, Hardy, you confirm?
On Tue 2016-02-02 15:40, Guillaume Smet wrote:
Hi,
While playing with ElasticSearch faceting (and having tests failing due to
that), I noticed that for Longs and Dates, the preexisting range faceting
doesn't take into account facetRequest.hasZeroCountsIncluded().
See
https://github.com/hibernate/hibernate-search/blob/master/engine/src/main...
and a few lines below for floating point ranges which take into account
this very parameter.
Is this something expected? Should I prepare a PR to fix it?
--
Guillaume
_______________________________________________
hibernate-dev mailing list
hibernate-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev
9:32 a.m.
Guillaume, just in case, if you plan to work on stuff around the ES
backend, I'd recommend you do so based on my pending PR
https://github.com/hibernate/hibernate-search/pull/960. This changes
quit a bit, so you may be in merge hell otherwise.
2016-02-03 9:15 GMT+01:00 Emmanuel Bernard <emmanuel(a)hibernate.org>:
It's probably a bug, Hardy, you confirm?
On Tue 2016-02-02 15:40, Guillaume Smet wrote:
> Hi,
>
> While playing with ElasticSearch faceting (and having tests failing due to
> that), I noticed that for Longs and Dates, the preexisting range faceting
> doesn't take into account facetRequest.hasZeroCountsIncluded().
>
> See
>
https://github.com/hibernate/hibernate-search/blob/master/engine/src/main...
> and a few lines below for floating point ranges which take into account
> this very parameter.
>
> Is this something expected? Should I prepare a PR to fix it?
>
> --
> Guillaume
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
_______________________________________________
hibernate-dev mailing list
hibernate-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev
12:49 p.m.
On Wed, Feb 3, 2016 at 9:32 AM, Gunnar Morling <gunnar(a)hibernate.org> wrote:
Guillaume, just in case, if you plan to work on stuff around the ES
backend, I'd recommend you do so based on my pending PR
https://github.com/hibernate/hibernate-search/pull/960. This changes
quit a bit, so you may be in merge hell otherwise.
Yes, I have seen it and I have based my work on it!
Cheers.
11:45 a.m.
Hi,
On Wed, Feb 03, 2016 at 09:15:31AM +0100, Emmanuel Bernard wrote:
It's probably a bug, Hardy, you confirm?
Sounds like an oversight. I would add it, make sure tests still pass and
add some new ones ;-)
--Hardy
On Tue 2016-02-02 15:40, Guillaume Smet wrote:
> Hi,
>
> While playing with ElasticSearch faceting (and having tests failing due to
> that), I noticed that for Longs and Dates, the preexisting range faceting
> doesn't take into account facetRequest.hasZeroCountsIncluded().
>
> See
>
https://github.com/hibernate/hibernate-search/blob/master/engine/src/main...
> and a few lines below for floating point ranges which take into account
> this very parameter.
>
> Is this something expected? Should I prepare a PR to fix it?
>
> --
> Guillaume
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
12:13 p.m.
Good catch!
Make sure to open a JIRA issue as first step, to not forget about this
even in case you get distracted.
On 3 February 2016 at 11:10, Guillaume Smet <guillaume.smet(a)gmail.com> wrote:
On Wed, Feb 3, 2016 at 11:45 AM, Hardy Ferentschik
<hardy(a)hibernate.org>
wrote:
> Sounds like an oversight. I would add it, make sure tests still pass and
> add some new ones ;-)
>
Will do.
Thanks for the confirmation.
_______________________________________________
hibernate-dev mailing list
hibernate-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev
3005
days inactive
3006
days old
7 comments
5 participants
participants (5)
-
Emmanuel Bernard -
Guillaume Smet -
Gunnar Morling -
Hardy Ferentschik -
Sanne Grinovero