I'd like to follow up on the discussion started here[1]. I was asked to port an existing application to Hana, so my first task was to write a hibernate dialect for it. I've completed this and so far it is working nicely in the integration tests for the application. My app is still using Hibernate 3.3, so that was my starting point, but with a few small changes it also compiles against the current git master. Is there still interest in such a dialect? Should I open a jira ticket and submit a pull request? Thanks, Andrew [1] https://community.jboss.org/wiki/DoHibernatePlanToSupportSAPHANADatabase _______________________________________________ hibernate-dev mailing list hibernate-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev

Why not? Especially as Hana looks extremely interesting. I recall some discussion about having the database vendors maintain them, but to go that route we could at least document how it works and make sure it's easy enough for end users. I think I'd prefer to see if database vendors are willing to donate hosting of a public instance of their db for test purposes. On 3 May 2013 04:02, "Strong Liu" <stliu(a)hibernate.org&gt; wrote: IIRC there was an agreement that we'd not accept new dialect anymore On May 2, 2013, at 3:41 AM, Andrew Clemons <andrew.clemons(a)gmail.com&gt; wrote: > I'd like to follow up on the discussion started here[1]. I was asked to > port an existing application to Hana, so my first task was to write a > hibernate dialect for it. I've completed this and so far it is working > nicely in the integration tests for the application. My app is still > using Hibernate 3.3, so that was my starting point, but with a few small > changes it also compiles against the current git master. Is there still > interest in such a dialect? Should I open a jira ticket and submit a > pull request? > > Thanks, > Andrew > > [1] https://community.jboss.org/wiki/DoHibernatePlanToSupportSAPHANADatabase > > _______________________________________________ > hibernate-dev mailing list > hibernate-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev ------------------------- Best Regards, Strong Liu <stliu at hibernate.org> http://about.me/stliu/bio _______________________________________________ hibernate-dev mailing list hibernate-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev

But we can definitely have a wiki page or even better a table in the documentation for third party dialects and where they are hosted. That' cheap for us and keep the ecosystem thriving. Emmanuel On Fri 2013-05-03 17:17, Strong Liu wrote: > I think the main reason is the lack of dev resource, if someone is willing to promise that long time contribution / maintains, I'm fine with that, or it will just become some dead code that we don't have knowledge nor time to maintains. > > On May 3, 2013, at 4:47 PM, Sanne Grinovero <sanne(a)hibernate.org&gt; wrote: > > > Why not? Especially as Hana looks extremely interesting. > > > > I recall some discussion about having the database vendors maintain them, but to go that route we could at least document how it works and make sure it's easy enough for end users. > > > > I think I'd prefer to see if database vendors are willing to donate hosting of a public instance of their db for test purposes. > > On 3 May 2013 04:02, "Strong Liu" <stliu(a)hibernate.org&gt; wrote: > > IIRC there was an agreement that we'd not accept new dialect anymore > > > > On May 2, 2013, at 3:41 AM, Andrew Clemons <andrew.clemons(a)gmail.com&gt; wrote: > > > > > I'd like to follow up on the discussion started here[1]. I was asked to > > > port an existing application to Hana, so my first task was to write a > > > hibernate dialect for it. I've completed this and so far it is working > > > nicely in the integration tests for the application. My app is still > > > using Hibernate 3.3, so that was my starting point, but with a few small > > > changes it also compiles against the current git master. Is there still > > > interest in such a dialect? Should I open a jira ticket and submit a > > > pull request? > > > > > > Thanks, > > > Andrew > > > > > > [1] https://community.jboss.org/wiki/DoHibernatePlanToSupportSAPHANADatabase > > > > > > _______________________________________________ > > > hibernate-dev mailing list > > > hibernate-dev(a)lists.jboss.org > > > https://lists.jboss.org/mailman/listinfo/hibernate-dev > > > > ------------------------- > > Best Regards, > > > > Strong Liu <stliu at hibernate.org> > > http://about.me/stliu/bio > > > > > > > > _______________________________________________ > > hibernate-dev mailing list > > hibernate-dev(a)lists.jboss.org > > https://lists.jboss.org/mailman/listinfo/hibernate-dev > > ------------------------- > Best Regards, > > Strong Liu <stliu at hibernate.org> > http://about.me/stliu/bio > > > > _______________________________________________ > hibernate-dev mailing list > hibernate-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev

Hi, On 2013-05-03 17:17:28 +0800, Strong Liu wrote: > I think the main reason is the lack of dev resource, if someone is > willing to promise that long time contribution / maintains, I'm fine > with that, or it will just become some dead code that we don't have > knowledge nor time to maintains. I probably should have mentioned this in my first email, but I work for SAP (through an acquisition). I am not involved in HANA development, but was told it might be interesting to port the app I work on to HANA, so that's how I got started working on the dialect on my own time. I asked around internally at SAP and was told there was a lot of interest in having Hibernate support for HANA and that quite a few external inquiries had been made about it. I was encouraged to submit this (which I was planning anyway) and that SAP are also willing to maintain it. SAP have also already submitted code for HANA to EclipseLink. Andrew _______________________________________________ hibernate-dev mailing list hibernate-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev

Andrew, could you create a pull request against our master branch and add your dialect to hibernate-core/src/main/java/org/hibernate/dialect? We'll take a look. Email me if you need help creating the PR.