3:40 p.m.
Hi Luis,
We talked at some point about a potential issue in Agroal, you said 1.3
should have all the known issues solved but apparently, there is still one
as we have transient test failures on ORM from time to time.
A good example is the following one:
http://ci.hibernate.org/view/ORM/job/hibernate-orm-master-h2-javassist/la...
(it's build #265, haven't found a way to get a stable URL from Jenkins)
The issue is in this test:
org.hibernate.test.agroal.AgroalTransactionIsolationConfigTest.testSettingIsolationAsName
.
And we have the following stacktrace when closing the pool:
java.util.concurrent.RejectedExecutionException: Task
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask@189a0b8e
rejected from io.agroal.pool.util.PriorityScheduledExecutor@2ded5d2e[Shutting
down, pool size = 1, active threads = 0, queued tasks = 1, completed
tasks = 2]
at
java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:2063)
at java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:830)
at
java.util.concurrent.ScheduledThreadPoolExecutor.delayedExecute(ScheduledThreadPoolExecutor.java:326)
at
java.util.concurrent.ScheduledThreadPoolExecutor.schedule(ScheduledThreadPoolExecutor.java:533)
at
java.util.concurrent.ScheduledThreadPoolExecutor.execute(ScheduledThreadPoolExecutor.java:622)
at
io.agroal.pool.util.PriorityScheduledExecutor.executeNow(PriorityScheduledExecutor.java:46)
at
io.agroal.pool.util.PriorityScheduledExecutor.executeNow(PriorityScheduledExecutor.java:35)
at
io.agroal.pool.util.PriorityScheduledExecutor.shutdown(PriorityScheduledExecutor.java:67)
at io.agroal.pool.ConnectionPool.close(ConnectionPool.java:126)
at io.agroal.pool.DataSource.close(DataSource.java:54)
at
org.hibernate.agroal.internal.AgroalConnectionProvider.stop(AgroalConnectionProvider.java:142)
at
org.hibernate.testing.common.connections.BaseTransactionIsolationConfigTest.testSettingIsolationAsName(BaseTransactionIsolationConfigTest.java:101)
It happens once in a while. I already had the issue locally but lately I
only observed it on CI.
I suppose it won't be easy to get to the bottom of it but it would be nice
if we could get this fixed.
Thanks.
--
Guillaume
7:39 a.m.
Hello Luis,
Any chance you could take a look at this one?
I just got it again on my laptop and it happened quite frequently on our CI
lately.
AFAICS, it's always failing in the setting isolation test but it can be
different test methods. Just had it for
AgroalTransactionIsolationConfigTest > testSettingIsolationAsNumericString
this time.
--
Guillaume
On Sat, Jan 5, 2019 at 10:40 PM Guillaume Smet <guillaume.smet(a)gmail.com>
wrote:
Hi Luis,
We talked at some point about a potential issue in Agroal, you said 1.3
should have all the known issues solved but apparently, there is still one
as we have transient test failures on ORM from time to time.
A good example is the following one:
http://ci.hibernate.org/view/ORM/job/hibernate-orm-master-h2-javassist/la...
(it's build #265, haven't found a way to get a stable URL from Jenkins)
The issue is in this test:
org.hibernate.test.agroal.AgroalTransactionIsolationConfigTest.testSettingIsolationAsName
.
And we have the following stacktrace when closing the pool:
java.util.concurrent.RejectedExecutionException: Task
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask@189a0b8e rejected
from io.agroal.pool.util.PriorityScheduledExecutor@2ded5d2e[Shutting down, pool size = 1,
active threads = 0, queued tasks = 1, completed tasks = 2]
at
java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:2063)
at java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:830)
at
java.util.concurrent.ScheduledThreadPoolExecutor.delayedExecute(ScheduledThreadPoolExecutor.java:326)
at
java.util.concurrent.ScheduledThreadPoolExecutor.schedule(ScheduledThreadPoolExecutor.java:533)
at
java.util.concurrent.ScheduledThreadPoolExecutor.execute(ScheduledThreadPoolExecutor.java:622)
at
io.agroal.pool.util.PriorityScheduledExecutor.executeNow(PriorityScheduledExecutor.java:46)
at
io.agroal.pool.util.PriorityScheduledExecutor.executeNow(PriorityScheduledExecutor.java:35)
at
io.agroal.pool.util.PriorityScheduledExecutor.shutdown(PriorityScheduledExecutor.java:67)
at io.agroal.pool.ConnectionPool.close(ConnectionPool.java:126)
at io.agroal.pool.DataSource.close(DataSource.java:54)
at
org.hibernate.agroal.internal.AgroalConnectionProvider.stop(AgroalConnectionProvider.java:142)
at
org.hibernate.testing.common.connections.BaseTransactionIsolationConfigTest.testSettingIsolationAsName(BaseTransactionIsolationConfigTest.java:101)
It happens once in a while. I already had the issue locally but lately I
only observed it on CI.
I suppose it won't be easy to get to the bottom of it but it would be nice
if we could get this fixed.
Thanks.
--
Guillaume
2:48 p.m.
Have we gotten any reply about this?
On Wed, Jan 23, 2019 at 8:58 AM Guillaume Smet <guillaume.smet(a)gmail.com>
wrote:
Hello Luis,
Any chance you could take a look at this one?
I just got it again on my laptop and it happened quite frequently on our CI
lately.
AFAICS, it's always failing in the setting isolation test but it can be
different test methods. Just had it for
AgroalTransactionIsolationConfigTest > testSettingIsolationAsNumericString
this time.
--
Guillaume
On Sat, Jan 5, 2019 at 10:40 PM Guillaume Smet <guillaume.smet(a)gmail.com>
wrote:
> Hi Luis,
>
> We talked at some point about a potential issue in Agroal, you said 1.3
> should have all the known issues solved but apparently, there is still
one
> as we have transient test failures on ORM from time to time.
>
> A good example is the following one:
>
>
http://ci.hibernate.org/view/ORM/job/hibernate-orm-master-h2-javassist/la...
> (it's build #265, haven't found a way to get a stable URL from Jenkins)
>
> The issue is in this test:
>
org.hibernate.test.agroal.AgroalTransactionIsolationConfigTest.testSettingIsolationAsName
> .
>
> And we have the following stacktrace when closing the pool:
>
> java.util.concurrent.RejectedExecutionException: Task
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask@189a0b8e
rejected from io.agroal.pool.util.PriorityScheduledExecutor@2ded5d2e[Shutting
down, pool size = 1, active threads = 0, queued tasks = 1, completed tasks
= 2]
> at
java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:2063)
> at
java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:830)
> at
java.util.concurrent.ScheduledThreadPoolExecutor.delayedExecute(ScheduledThreadPoolExecutor.java:326)
> at
java.util.concurrent.ScheduledThreadPoolExecutor.schedule(ScheduledThreadPoolExecutor.java:533)
> at
java.util.concurrent.ScheduledThreadPoolExecutor.execute(ScheduledThreadPoolExecutor.java:622)
> at
io.agroal.pool.util.PriorityScheduledExecutor.executeNow(PriorityScheduledExecutor.java:46)
> at
io.agroal.pool.util.PriorityScheduledExecutor.executeNow(PriorityScheduledExecutor.java:35)
> at
io.agroal.pool.util.PriorityScheduledExecutor.shutdown(PriorityScheduledExecutor.java:67)
> at io.agroal.pool.ConnectionPool.close(ConnectionPool.java:126)
> at io.agroal.pool.DataSource.close(DataSource.java:54)
> at
org.hibernate.agroal.internal.AgroalConnectionProvider.stop(AgroalConnectionProvider.java:142)
> at
org.hibernate.testing.common.connections.BaseTransactionIsolationConfigTest.testSettingIsolationAsName(BaseTransactionIsolationConfigTest.java:101)
>
>
> It happens once in a while. I already had the issue locally but lately I
> only observed it on CI.
>
> I suppose it won't be easy to get to the bottom of it but it would be
nice
> if we could get this fixed.
>
> Thanks.
>
> --
> Guillaume
>
_______________________________________________
hibernate-dev mailing list
hibernate-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev
8:43 a.m.
I hate to be overly reactionary, but we we may want to consider dropping
that module then. If there is a bug and we cannot get in touch with him to
figure it out then we cannot really suppport it
On Tue, Jan 29, 2019 at 3:31 PM Guillaume Smet <guillaume.smet(a)gmail.com>
wrote:
On Tue, Jan 29, 2019 at 9:48 PM Steve Ebersole
<steve(a)hibernate.org>
wrote:
> Have we gotten any reply about this?
>
No.
10:43 a.m.
Hi,
Although I have not experienced that particular issue in Agroal (either
locally or in the CI), I was aware that the race condition that was
mitigated in 1.3 could still happen.
I've long reworked the shutdown code so the issue is completely gone. It
just happens that I'm about to release Agroal 1.4 that will include this
fix.
Regards,
Luis Barreiro
Middleware Performance Team
<https://red.ht/sig>
On 1/30/19 2:43 PM, Steve Ebersole wrote:
I hate to be overly reactionary, but we we may want to consider
dropping that module then. If there is a bug and we cannot get in
touch with him to figure it out then we cannot really suppport it
On Tue, Jan 29, 2019 at 3:31 PM Guillaume Smet
<guillaume.smet(a)gmail.com <mailto:guillaume.smet@gmail.com>> wrote:
On Tue, Jan 29, 2019 at 9:48 PM Steve Ebersole
<steve(a)hibernate.org <mailto:steve@hibernate.org>> wrote:
Have we gotten any reply about this?
No.
2124
days inactive
2149
days old
5 comments
3 participants
participants (3)
-
Guillaume Smet -
Luis Barreiro -
Steve Ebersole