6:38 a.m.
Hi Hardy,
sorry I screwed up both during review and setting up ci.hibernate.org
: the code in Maven module _hibernate-search-performance_ isn't
compiling anymore; could you extend your refactoring to this module
please?
This slipped in as the profile is disabled by default; I'm fixing the
pull requests checker to verify this profile as well. I suspect I
wanted to keep the PR checker quick and lean, but it doesn't take too
long now.
Cheers,
Sanne
6:56 a.m.
On 31 Jan 2013, at 1:38 PM, Sanne Grinovero <sanne(a)hibernate.org> wrote:
Hi Hardy,
sorry I screwed up both during review and setting up ci.hibernate.org
: the code in Maven module _hibernate-search-performance_ isn't
compiling anymore; could you extend your refactoring to this module
please?
:-( I can have a look tomorrow
This slipped in as the profile is disabled by default; I'm fixing
the
pull requests checker to verify this profile as well. I suspect I
wanted to keep the PR checker quick and lean, but it doesn't take too
long now.
And this is exactly why I always say that all modules should build by default
(with options for the performance minded to disable certain modules/parts)!
Also getting feedback from the pull request checker is ways too late. By the time
I get feedback from there I have moved on and work on another branch.
At least the code parts needs to be all compiled on each build.
But I guess I stand alone with this opinion :-(
--Hardy
7:04 a.m.
2013/7/31 Hardy Ferentschik <hardy(a)hibernate.org>
On 31 Jan 2013, at 1:38 PM, Sanne Grinovero <sanne(a)hibernate.org> wrote:
> Hi Hardy,
> sorry I screwed up both during review and setting up ci.hibernate.org
> : the code in Maven module _hibernate-search-performance_ isn't
> compiling anymore; could you extend your refactoring to this module
> please?
:-( I can have a look tomorrow
> This slipped in as the profile is disabled by default; I'm fixing the
> pull requests checker to verify this profile as well. I suspect I
> wanted to keep the PR checker quick and lean, but it doesn't take too
> long now.
And this is exactly why I always say that all modules should build by
default
(with options for the performance minded to disable certain modules/parts)!
Also getting feedback from the pull request checker is ways too late. By
the time
I get feedback from there I have moved on and work on another branch.
At least the code parts needs to be all compiled on each build.
But I guess I stand alone with this opinion :-(
No, you don't. Take OGM for example, there we just enabled the MongoDB
modules to run as part of the default build.
--Hardy
_______________________________________________
hibernate-dev mailing list
hibernate-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev
7:18 a.m.
On 31 July 2013 13:04, Gunnar Morling <gunnar(a)hibernate.org> wrote:
2013/7/31 Hardy Ferentschik <hardy(a)hibernate.org>
>
>
> On 31 Jan 2013, at 1:38 PM, Sanne Grinovero <sanne(a)hibernate.org> wrote:
>
> > Hi Hardy,
> > sorry I screwed up both during review and setting up ci.hibernate.org
> > : the code in Maven module _hibernate-search-performance_ isn't
> > compiling anymore; could you extend your refactoring to this module
> > please?
>
> :-( I can have a look tomorrow
>
> > This slipped in as the profile is disabled by default; I'm fixing the
> > pull requests checker to verify this profile as well. I suspect I
> > wanted to keep the PR checker quick and lean, but it doesn't take too
> > long now.
>
> And this is exactly why I always say that all modules should build by
> default
> (with options for the performance minded to disable certain
> modules/parts)!
>
> Also getting feedback from the pull request checker is ways too late. By
> the time
> I get feedback from there I have moved on and work on another branch.
> At least the code parts needs to be all compiled on each build.
>
> But I guess I stand alone with this opinion :-(
No, you don't. Take OGM for example, there we just enabled the MongoDB
modules to run as part of the default build.
It's a tradeoff, it's not the end of the world if this module doesn't
compile for day.
On the other hand I run the build dozens of times a day, quite happy
it takes just 2 minutes, which is not possible with the performance
tests.
Another approach would be to move those tests into a different
repository; but technically I wish I had merged my other tests sooner
as now they are outdated and need maintenance.
I don't think we should automate this all to make our life too easy:
engineers!=mindless chickens. it was my mistake, should just think
better of the consequences of code change and I think we can generally
do that, and be forgiving for the occasional mistake as it saves lots
of time.
The MongoDB example is different; I have always run those tests, I
just had to put a 10 minutes investment to install MongoDB and setup
the variables. The improvement is welcome but I think mostly meant for
eventual occasional contributors not interested in the MongoDB
backend.
Sanne
>
>
> --Hardy
>
>
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
7:45 a.m.
It's a tradeoff, it's not the end of the world if this module
doesn't
compile for day.
On the other hand I run the build dozens of times a day, quite happy
it takes just 2 minutes, which is not possible with the performance
tests.
I think we have to differentiate here. I am not saying that the performance
tests need to run all the time, however, I would like the test classes to
at least getting compiled to detect simple compilation errors.
Right now the performance module is completely deactivated until
a certain profile is selected. IMO the performance module should be
part of the default module list and what should be turned on and off
via the profile is the actual test run. This way at least the sources get
compiled and the costs for that should be quite small.
Another approach would be to move those tests into a different
repository;
I don't think this is necessary
--Hardy
4131
days inactive
4131
days old
4 comments
3 participants
participants (3)
-
Gunnar Morling -
Hardy Ferentschik -
Sanne Grinovero