9:14 a.m.
In tests we find our `#inSession` and `#inTransaction` methods very
useful. Which got me thinking that maybe we should support these on
SessionFactory directly:
public interface SessionFactory ... {
...
void inSession(Consumer<Session> action);
void inTransaction(Consumer<Session> action);
void inTransaction(Session session, Consumer<Session> action);
}
and maybe even:
public interface Session ... {
void inTransaction(Consumer<Session> action);
}
Objections?
1:33 p.m.
Hey,
When discussing this before, there were some doubts about its actual
usefulness in non-testing, real-world code. E.g. you'd typically
interact with multiple DAOs/repositories etc. and would have to
somehow pass the session to each of them.
One other thought is that inTransaction() should allow to return a result value.
--Gunnar
Am Do., 20. Dez. 2018 um 17:02 Uhr schrieb Steve Ebersole <steve(a)hibernate.org>:
In tests we find our `#inSession` and `#inTransaction` methods very
useful. Which got me thinking that maybe we should support these on
SessionFactory directly:
public interface SessionFactory ... {
...
void inSession(Consumer<Session> action);
void inTransaction(Consumer<Session> action);
void inTransaction(Session session, Consumer<Session> action);
}
and maybe even:
public interface Session ... {
void inTransaction(Consumer<Session> action);
}
Objections?
_______________________________________________
hibernate-dev mailing list
hibernate-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev
4:16 p.m.
On Thu, Dec 20, 2018 at 1:33 PM Gunnar Morling <gunnar(a)hibernate.org> wrote:
Hey,
When discussing this before, there were some doubts about its actual
usefulness in non-testing, real-world code. E.g. you'd typically
interact with multiple DAOs/repositories etc. and would have to
somehow pass the session to each of them.
I've written many non-trivial apps in my past that did not use
"DAO/repositories" etc. Not sure why we'd choose to not implement
something that is useful just because not everyone would use it. To me, if
something is repeatedly useful in writing tests... it tends to be
more-or-less generally useful.
One other thought is that inTransaction() should allow to return a result
value.
An over-loaded form perhaps, yes I can see that - but non-returning is
valid as well. So maybe:
public interface SessionFactory ... {
...
void inSession(Consumer<Session> action);
void inTransaction(Consumer<Session> action);
void inTransaction(Session session, Consumer<Session> action);
<T> T inSession(Function<Session,T> action);
<T> T inTransaction(Function<Session,T> action);
<T> T inTransaction(Session session, Function<Session,T> action);
}
and
public interface Session ... {
void inTransaction(Consumer<Session> action);
<T> T inTransaction(Function<Session,T> action);
}
9:37 a.m.
I have no objections to exposing them directly rather than being part of
the test infrastructure.
On 12/20/18 5:16 PM, Steve Ebersole wrote:
On Thu, Dec 20, 2018 at 1:33 PM Gunnar Morling
<gunnar(a)hibernate.org> wrote:
> Hey,
>
> When discussing this before, there were some doubts about its actual
> usefulness in non-testing, real-world code. E.g. you'd typically
> interact with multiple DAOs/repositories etc. and would have to
> somehow pass the session to each of them.
>
I've written many non-trivial apps in my past that did not use
"DAO/repositories" etc. Not sure why we'd choose to not implement
something that is useful just because not everyone would use it. To me, if
something is repeatedly useful in writing tests... it tends to be
more-or-less generally useful.
One other thought is that inTransaction() should allow to return a result
> value.
>
An over-loaded form perhaps, yes I can see that - but non-returning is
valid as well. So maybe:
public interface SessionFactory ... {
...
void inSession(Consumer<Session> action);
void inTransaction(Consumer<Session> action);
void inTransaction(Session session, Consumer<Session> action);
<T> T inSession(Function<Session,T> action);
<T> T inTransaction(Function<Session,T> action);
<T> T inTransaction(Session session, Function<Session,T> action);
}
and
public interface Session ... {
void inTransaction(Consumer<Session> action);
<T> T inTransaction(Function<Session,T> action);
}
_______________________________________________
hibernate-dev mailing list
hibernate-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev
2147
days inactive
2165
days old
3 comments
3 participants
participants (3)
-
Chris Cranford -
Gunnar Morling -
Steve Ebersole