2013/4/16 Steve Ebersole <steve(a)hibernate.org>
No, I haven't. Nice, seems we agree then :)
But really, tell me what is wrong with this "circularity"?
And try not to
use IDEs as the justification; I mean conceptually, what is wrong with this
"circularity".
And note that i use quotes here ;)
Ah, why do I feel this will end bad for me ;)
There is nothing conceptually wrong with this circular dependency, if the
two modules actually are one "logical" module and are put into two physical
modules (one with production and one with test code) only due to some
shortcoming with a build tool. But if that's the case, then I think it's
better to actually make it one module if possible, if only to avoid
irritations :)
Also, once I start to ignore such circularities, I might miss cases where
they really are a problem, i.e. a circle between two "real" modules.
On 04/16/2013 02:54 AM, Gunnar Morling wrote:
2013/4/15 Steve Ebersole <steven.ebersole(a)gmail.com>
> I am not touching this :)
>
> I think I have explained this 198,052 times thus far lol
>
I must have missed this then. Or I was not yet part of the team at that
time.
>
>
https://community.jboss.org/wiki/GradleWhy see #4
Thanks for the link.
I get the reasoning about Maven's "one artifact" rule and the need for
re-usable test code. But now that we use Gradle, wouldn't it be possible to
move the things from hibernate-testng back to hibernate-core and built two
JARs with the different contents from there? To me, a circular dependency
between two modules always seems a bit suspicious, also if it is doable
with Gradle, turning off warnings in the IDE etc.
Btw. also Maven supports this particular use case of creating a main JAR
and a JAR with re-usable test infrastructure [1]. We e.g. make use of this
in HV.
--Gunnar
[1]
http://maven.apache.org/plugins/maven-jar-plugin/test-jar-mojo.html
>
> On Mon 15 Apr 2013 04:10:43 PM CDT, Gunnar Morling wrote:
>
>> Hi Brett,
>>
>> That's good news, thanks for your efforts. Based on step 3 from your blog
>> post it seems as there still is a circular dependency between some of the
>> modules/projects. Just out of interest, could you give some more details
>> why this kind of setup is required?
>>
>> --Gunnar
>>
>>
>>
>> 2013/4/15 Brett Meyer <brmeyer(a)redhat.com>
>>
>> There's been several complaints about ORM's use of Gradle not generating
>>> Eclipse projects correctly. This was recently cleaned up in HHH-7617
>>> [1].
>>> FYI, there's a quick blog post [2] about how to quickly get
>>> up-and-running. Please let me know if there are any further ways we
>>> could
>>> streamline the IDE setup.
>>>
>>> [1]
https://hibernate.atlassian.net/browse/HHH-7617
>>> [2]
>>>
>>>
http://in.relation.to/Bloggers/ImprovedEclipseProjectSupportForHibernateO...
>>>
>>> Brett Meyer
>>> Red Hat Software Engineer, Hibernate
>>> _______________________________________________
>>> hibernate-dev mailing list
>>> hibernate-dev(a)lists.jboss.org
>>>
https://lists.jboss.org/mailman/listinfo/hibernate-dev
>>>
>>> _______________________________________________
>> hibernate-dev mailing list
>> hibernate-dev(a)lists.jboss.org
>>
https://lists.jboss.org/mailman/listinfo/hibernate-dev
>>
>