[Design of Messaging on JBoss (Messaging/JBoss)] - Re: Some comments on new scheduled delivery work
by ataylor
anonymous wrote : a) Can you tell your formatter to add a space between if statements and the opening brace?
It already is, I musn't have formatted this piece of code.
anonymous wrote : b) Main issue. Scheduled delivery time is being stored in the journal at the message level. However, it should be an attribute of the message reference, not the message. (See my earlier post)
So at what point do i add a record to the journal then? I guess i just need to add the queue id and the message id to the encoding.
anonymous wrote : ) Can you point me to the core tests for this functionality?
|
|
If you're going to add a scheduledDeliveryTime attribute to the ref, then there's no need for a separate addScheduledDelivery method, so they should be combined.
More over the current addScheduledDelivery method bypasses all the message and size counting done in add.
theres a ScheduledMessageTest under the timing tests. Ive also added some tests to unut tests that already exist, journalManagerTest etc
anonymous wrote :
| If you're going to add a scheduledDeliveryTime attribute to the ref, then there's no need for a separate addScheduledDelivery method, so they should be combined.
|
| More over the current addScheduledDelivery method bypasses all the message and size counting done in add.anonymous wrote :
| |
| | Ok i'll sort
View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4180963#4180963
Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4180963
16 years, 3 months