November 2008 - jboss-dev-forums - Jboss List Archives

[Design the new POJO MicroContainer] - Re: Handling of null native values

by alesj

"scott.stark(a)jboss.org" wrote : Ok. But you'll have to port it to branch. ;-) View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4191444#4191444 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4191444

15 years, 10 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: Handling of null native values

by scott.stark＠jboss.org

Ok. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4191443#4191443 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4191443

15 years, 10 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: Handling of null native values

by alesj

True. I'll eventually add this to reflect's PrimitiveInfo. For now I'll change your n if's to use a map. ;-) View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4191442#4191442 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4191442

15 years, 10 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: Handling of null native values

by scott.stark＠jboss.org

SimpleMetaType does not differentiate between a primitive, and non-primitive, so how would I know what the default value for a SimpleMetaType.INTEGER would be for example? For an int its 0, for an Integer its null. We would have to add an isPrimitive notion and allow this to be specified in wrap. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4191441#4191441 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4191441

15 years, 10 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: Handling of null native values

by alesj

"scott.stark(a)jboss.org" wrote : This is implemented in the metavalue project now. I think you are again doing it wrong, as with SimpleMetaValueComparator. You should add this info to SimpleMetaType. As you have all the info required in AbstractInstanceClassFactory::setValue. | protected void setValue(BeanInfo beanInfo, PropertyInfo propertyInfo, Object object, Object unwrapValue) | throws Throwable | { | TypeInfo type = propertyInfo.getType(); | if(unwrapValue == null && type.isPrimitive()) | { | MetaType metaType = MetaTypeFactory.getInstance().resolve(type); | SimpleMetaType smt = SimpleMetaType.class.cast(metaType); | unwrapValue = smt.getDefaultValue(); // <-- missing method | } | propertyInfo.set(object, unwrapValue); | } | More OO. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4191439#4191439 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4191439

15 years, 10 months

1
0
0 / 0

[Design of JBossXB] - Using generics info in CollectionPropertyHandler

by alesj

Checking how KernelDeployment handles BeanMetaDataFactorys I came with the following issue: - http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4191432#4191432 I guess CollectionPropertyHandler could include this check | if (child != null) | { | TypeInfo typeInfo = propertyInfo.getType(); | if (typeInfo instanceof ClassInfo) | { | ClassInfo classInfo = (ClassInfo)typeInfo; | TypeInfo componentType = classInfo.getComponentType(); | if (componentType != null) | { | TypeInfoFactory tif = componentType.getTypeInfoFactory(); | TypeInfo childTypeInfo = tif.getTypeInfo(child.getClass()); | if (componentType.isAssignableFrom(childTypeInfo) == false) | throw new IllegalArgumentException("Illegal child type"); | } | } | } | probably in a bit more optimized way - not checking for component type every time. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4191434#4191434 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4191434

15 years, 10 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: Handling of null native values

by scott.stark＠jboss.org

Yes. This is implemented in the metavalue project now. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4191433#4191433 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4191433

15 years, 10 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: Handling of null native values

by alesj

"scott.stark(a)jboss.org" wrote : That's a valid question. Thinking about it some more, I think it's not the job of PropertyInfo/MethodInfo to recognize primitive type + default value, they should just do what they are instructed - as it is currently implemented. It should be the code that's using it, that should know what to do. In your case it's meta value/type, in kernel's case it's configure action. I'll check how this behaves in MC-Kernel code. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4191429#4191429 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4191429

15 years, 10 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: Handling of null native values

by scott.stark＠jboss.org

That's a valid question. In this case I believe it actually is a non-null MetaValue whose underlying value is null, so it really should be mapped to a zero. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4191422#4191422 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4191422

15 years, 10 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: Handling of null native values

by alesj

I'll check how much work is there to add this to jboss reflect. It should be MethodInfo::invoke and PropertyInfo::set that should probably have this logic. But does setting null on a primitive really always means you want default value or should the user get exception? View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4191419#4191419 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4191419

15 years, 10 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jboss-dev-forums November 2008