November 2008 - jboss-dev-forums - Jboss List Archives

[Design the new POJO MicroContainer] - AbstractDeploymentClassLoaderPolicyModule is mossing reset

by alesj

Deployers's AbstractDeploymentClassLoaderPolicyModule is not removing alias if one was added at AbstractDeploymentClassLoaderPolicyModule construction. I've added the following code: | public abstract class AbstractDeploymentClassLoaderPolicyModule extends ClassLoaderPolicyModule | @@ -64,12 +66,14 @@ | * Determine the classloading metadata for the deployment unit | * | * @param unit the deployment unit | + * @param addAlias should we add alias or remove | * @return the classloading metadata | */ | - private static String determineContextName(DeploymentUnit unit) | + private static String determineContextName(DeploymentUnit unit, boolean addAlias) | { | if (unit == null) | throw new IllegalArgumentException("Null unit"); | + | ControllerContext context = unit.getTopLevel().getAttachment(ControllerContext.class); | if (context == null) | throw new IllegalStateException("Deployment has no controller context"); | @@ -83,13 +87,21 @@ | Set<Object> aliases = context.getAliases(); | if (aliases != null && aliases.contains(contextName) == false) | { | - try | + Controller controller = context.getController(); | + if (addAlias) | { | - context.getController().addAlias(contextName, context.getName()); | + try | + { | + controller.addAlias(contextName, context.getName()); | + } | + catch (Throwable t) | + { | + throw new RuntimeException("Error adding deployment alias " + contextName + " to " + context, t); | + } | } | - catch (Throwable t) | + else | { | - throw new RuntimeException("Error adding deployment alias " + contextName + " to " + context, t); | + controller.removeAlias(contextName); | } | } | } | @@ -105,7 +117,7 @@ | */ | public AbstractDeploymentClassLoaderPolicyModule(DeploymentUnit unit) | { | - super(determineClassLoadingMetaData(unit), determineContextName(unit)); | + super(determineClassLoadingMetaData(unit), determineContextName(unit, true)); | this.unit = unit; | ControllerContext context = unit.getTopLevel().getAttachment(ControllerContext.class); | setControllerContext(context); | @@ -126,4 +138,11 @@ | { | return CLASSLOADER_STATE; | } | + | + @Override | + public void reset() | + { | + super.reset(); | + determineContextName(unit, false); | + } | } | Should this be part of new release for JBoss5 GA? I still need to write some tests, checking if it was successfully removed from Controller (in case it was added). View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4193129#4193129 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4193129

15 years, 4 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: MC upgrade breaks scoped aop tests in trunk

by anil.saldhana＠jboss.com

"alesj" wrote : "dimitris(a)jboss.org" wrote : So who's fixing this / when? A new release of MC is needed? | I can do the release (if needed), but dunno who's fixing this. While you are at the mc release, can you put back the system property for the real urls in VFSClassLoaderPolicy? View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4193127#4193127 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4193127

15 years, 4 months

1
0
0 / 0

[Design of POJO Server] - Re: VFS Permissions - JBMICROCONT-149

by anil.saldhana＠jboss.com

Ales, only if you had retained the system property for the useRealURLs. ;) View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4193126#4193126 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4193126

15 years, 4 months

1
0
0 / 0

[Design of Security on JBoss] - Re: Security aspect updates

by anil.saldhana＠jboss.com

1) I inherited AOP security in whatever form it was. I have not worked on it except for it to remain running. So will certainly take your suggestions into consideration when I work on it. 2) We still maintain RealmMapping for backwards compatibility. The current recommended approach is AuthorizationManager interface. As you can see, JaasSecurityManager.realmmapping methods just delegate to the authz mgr interface. Currently, the ISecurityManagement interface provides the strategy based hook into the security managers. I think we need to inject an instance of ISM into the bean container. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4193125#4193125 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4193125

15 years, 4 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: MC upgrade breaks scoped aop tests in trunk

by alesj

"dimitris(a)jboss.org" wrote : So who's fixing this / when? A new release of MC is needed? I can do the release (if needed), but dunno who's fixing this. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4193117#4193117 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4193117

15 years, 4 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: MC upgrade breaks scoped aop tests in trunk

by dimitris＠jboss.org

So who's fixing this / when? A new release of MC is needed? View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4193115#4193115 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4193115

15 years, 4 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: MC upgrade breaks scoped aop tests in trunk

by kabir.khan＠jboss.com

I have added a test to mc Branch_2_0 org.jboss.test.microcontainer.test.OverriddenClassLoaderTestCase. This will fail until this is fixed, but should help against regressions in this area in future. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4193088#4193088 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4193088

15 years, 4 months

1
0
0 / 0

[Design of Security on JBoss] - Security aspect updates

by scott.stark＠jboss.org

In going through the current jboss-aspects/security aspects and applying them to the profileservice, I see a few issues we should work on updating to be better mc/pojo citizens. 1. The jndi based dynamic security makes it a little awkward to setup a bean/interceptor that depends on an AuthenticationManager instance. We should create an AuthenticationManagerBean or some such that simplifies this. Right now you can do something like the following to create an instance that uses the security-jboss-beans.xml JNDIBasedSecurityManagement as a factory. The ProfileServiceAuthenticationManager bean can then be injected into the AuthenticationInterceptor: | <bean name="ProfileServiceAuthenticationManager" class="org.jboss.security.AuthenticationManager"> | <constructor factoryMethod="getAuthenticationManager"> | <factory bean="JNDIBasedSecurityManagement"/> | <parameter>profileservice</parameter> | </constructor> | </bean> | <interceptor xmlns="urn:jboss:aop-beans:1.0" class="org.jboss.aspects.security.AuthenticationInterceptor"> | <constructor> | <parameter><inject bean="ProfileServiceAuthenticationManager"/></parameter> | </constructor> | </interceptor> | 2. The RoleBasedAuthorizationInterceptor depends on the older RealmMapping interface, and nothing directly provides access to this. I was able to use the JNDIBasedSecurityManagement.getAuthorizationManager instance as a RealmMapping instance using: | <bean name="ProfileServiceAuthorizationManager" class="org.jboss.security.AuthorizationManager"> | <constructor factoryMethod="getAuthorizationManager"> | <factory bean="JNDIBasedSecurityManagement"/> | <parameter>profileservice</parameter> | </constructor> | </bean> | <interceptor xmlns="urn:jboss:aop-beans:1.0" class="org.jboss.aspects.security.RoleBasedAuthorizationInterceptor"> | <constructor> | <parameter><inject bean="ProfileServiceAuthenticationManager"/></parameter> | <parameter><inject bean="ProfileServiceAuthorizationManager"/></parameter> | </constructor> | </interceptor> | but this relies on the implementation details of the AuthorizationManager. We need a new RoleBasedAuthorizationInterceptor that uses the AuthorizationManager spi. 3. All of the *InterceptorFactory rely on hard-coded lookups of metadata from the advisor metadata api with fallbacks to jndi lookups. Because of the mc capabilities with specifying how a bean is created, these are probably all obsolete, but we should review them. Generally we should just review what the current spis are and their associated beans and make sure the beans expose sufficient pojo based configuration, and that the aspects cover the use cases we want. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4193084#4193084 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4193084

15 years, 4 months

1
0
0 / 0

[Design of POJO Server] - Re: JBAS-6105; Improve start-up time

by adrian＠jboss.org

"alesj" wrote : "adrian(a)jboss.org" wrote : So we are obviously tickling something inefficent | | in JDK5 that has been fixed in JDK6? | How to find this needle in JDK haystack? :-) I still see the two biggest hits as the VFS and aop pointcut matching when I've measured it. So for the VFS, I guess it would be that JDK6 no longer uses memory mapped files for jars. For the AOP pointcut matching it would be the reflection calls. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4193079#4193079 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4193079

15 years, 4 months

1
0
0 / 0

[Design of POJO Server] - Re: JBAS-6105; Improve start-up time

by alesj

"adrian(a)jboss.org" wrote : So we are obviously tickling something inefficent | in JDK5 that has been fixed in JDK6? How to find this needle in JDK haystack? :-) View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4193071#4193071 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4193071

15 years, 4 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jboss-dev-forums November 2008