Maciej Swiderski [http://community.jboss.org/people/swiderski.maciej] replied to the discussion
"variable declaration and history support"
To view the discussion, visit: http://community.jboss.org/message/547154#547154
--------------------------------------------------------------
> Alejandro Guizar wrote:
>
> Yes, it won't. However, what I wanted to point out with my extract from ScopeInstanceImpl.setVariable is that it ignores the historyEnabled parameter if the variable already exists. I do not know whether it makes sense to enable/disable history for an existing variable. In any case that would be a feature request that we can defer for the time being.
Fair enough, just wanted to make sure we are on the same page, so to say.
Agree that we could make further enhancement later on.
Will you make any other changes or shall I commit history stuff as well?
--------------------------------------------------------------
Reply to this message by going to Community
[http://community.jboss.org/message/547154#547154]
Start a new discussion in jBPM Development at Community
[http://community.jboss.org/choose-container!input.jspa?contentType=1&cont...]
Alejandro Guizar [http://community.jboss.org/people/alex.guizar%40jboss.com] replied to the discussion
"variable declaration and history support"
To view the discussion, visit: http://community.jboss.org/message/547148#547148
--------------------------------------------------------------
> Good to hear you found some time to look into it ;)
Quite the opposite, thanks for the patience :)
> Would that mean that once variable is created (without history being enabled) it won't be possible to alter it?
Yes, it won't. However, what I wanted to point out with my extract from ScopeInstanceImpl.setVariable is that it ignores the historyEnabled parameter if the variable already exists. I do not know whether it makes sense to enable/disable history for an existing variable. In any case that would be a feature request that we can defer for the time being.
--------------------------------------------------------------
Reply to this message by going to Community
[http://community.jboss.org/message/547148#547148]
Start a new discussion in jBPM Development at Community
[http://community.jboss.org/choose-container!input.jspa?contentType=1&cont...]
Maciej Swiderski [http://community.jboss.org/people/swiderski.maciej] replied to the discussion
"foreach activity"
To view the discussion, visit: http://community.jboss.org/message/547119#547119
--------------------------------------------------------------
> Alejandro Guizar wrote:
>
> > condition on expression was not supported
> Did this fail to pass your tests?
Yeap, condition was not set on transition at all. So no evaluation was performed. I modified binding for for each activity.
> Alejandro Guizar wrote:
>
> > if no transition conditions evaluated to true no exception was reported but for each activity was simple ended
> This is an intentional deviation. I observed that the fork activity does not throw an exception if no concurrent executions leave the fork. I thought foreach should be consistent with that behavior.
ok, I examined decision activity instead, since it has quite the same approach - conditions on transition.
--------------------------------------------------------------
Reply to this message by going to Community
[http://community.jboss.org/message/547119#547119]
Start a new discussion in jBPM Development at Community
[http://community.jboss.org/choose-container!input.jspa?contentType=1&cont...]
Ales Justin [http://community.jboss.org/people/alesj] created the discussion
"GC shutdown and wiring"
To view the discussion, visit: http://community.jboss.org/message/547120#547120
--------------------------------------------------------------
As per this OSGi-dev discussion:
* http://www.mail-archive.com/osgi-dev@mail.osgi.org/msg01406.htmlhttp://www.mail-archive.com/osgi-dev@mail.osgi.org/msg01406.htmlmailto://www.mail-archive.com/osgi-dev@mail.osgi.org //www.mail-archive.com/osgi-dev(a)mail.osgi.org/msg01406.html
we're missing "GC" notion on available capabilities / deployments.
We should be still able to wire to undeployed "GC" based deployments,
but we're definitely cleaning up too much.
This can be seen in Deployers test - MockClassLoaderDependenciesUnitTestCase::testWildcardWithGC()
where you comment out first B.class loading attempt - assertLoadClass(clA, B.class, clB).
The extra delegates never get created, and we cannot resolve them later in WildcardDelegateLoader.
Perhaps this is actually OK for wildcards, since it means no-one actually tried to load anything with the requested package?
But this would definitely not be OK for non-dynamic wiring, as any later deployment wouldn't be able to wire up to "GC-ed" deployment.
How to "enable" this GC notion into deployments as well?
--------------------------------------------------------------
Reply to this message by going to Community
[http://community.jboss.org/message/547120#547120]
Start a new discussion in JBoss Microcontainer Development at Community
[http://community.jboss.org/choose-container!input.jspa?contentType=1&cont...]
Alejandro Guizar [http://community.jboss.org/people/alex.guizar%40jboss.com] replied to the discussion
"foreach activity"
To view the discussion, visit: http://community.jboss.org/message/547087#547087
--------------------------------------------------------------
> condition on expression was not supported
Did this fail to pass your tests?
> verifying number of transition for foreach activity - exactly one transition must be given
Right. Good catch.
> if no transition conditions evaluated to true no exception was reported but for each activity was simple ended
This is an intentional deviation. I observed that the fork activity does not throw an exception if no concurrent executions leave the fork. I thought foreach should be consistent with that behavior.
--------------------------------------------------------------
Reply to this message by going to Community
[http://community.jboss.org/message/547087#547087]
Start a new discussion in jBPM Development at Community
[http://community.jboss.org/choose-container!input.jspa?contentType=1&cont...]
Maciej Swiderski [http://community.jboss.org/people/swiderski.maciej] replied to the discussion
"foreach activity"
To view the discussion, visit: http://community.jboss.org/message/547081#547081
--------------------------------------------------------------
I looked into the patch and to me it looks very good. It was missing some of the mentioned functionality:
* condition on expression was not supported
* verifying number of transition for foreach activity - exactly one transition must be given
* troubles with evaluating expressions on child executions (wrong context)
* if no transition conditions evaluated to true no exception was reported but for each activity was simple ended - bit different to what was described in the first post
I have done required fixes and the patch can be found in jira. In addition I have added several test cases to check verify the implementation.
Comments are more than welcome.
--------------------------------------------------------------
Reply to this message by going to Community
[http://community.jboss.org/message/547081#547081]
Start a new discussion in jBPM Development at Community
[http://community.jboss.org/choose-container!input.jspa?contentType=1&cont...]