June 2010 - jboss-dev-forums - Jboss List Archives

Re: [jboss-dev-forums] [JBoss Microcontainer Development] - Wildcard support in Dynamic-imports

by Ales Justin

Ales Justin [http://community.jboss.org/people/alesj] replied to the discussion "Wildcard support in Dynamic-imports" To view the discussion, visit: http://community.jboss.org/message/547073#547073 -------------------------------------------------------------- > No, just add it as a public method to BaseClassLoaderPolicy, it will get inherited into ClassLoaderPolicy.Obviously the spi.base.* stuff has to have some public/protected methods otherwise it couldn't be used, but keep > whats exposed down to a minimum. :-) I hack stuff faster than I think, but then I fix it before you can actually reply to my stupid code. :-) I actually made the add/remove methods protected in BaseCLP and public in CLP which delegate to BaseCLP methods. But if you prefer them public in BaseCLP that can be arranged. ;-) -------------------------------------------------------------- Reply to this message by going to Community [http://community.jboss.org/message/547073#547073] Start a new discussion in JBoss Microcontainer Development at Community [http://community.jboss.org/choose-container!input.jspa?contentType=1&cont...]

15 years, 10 months

1
0
0 / 0

Re: [jboss-dev-forums] [JBoss Microcontainer Development] - Wildcard support in Dynamic-imports

by Ales Justin

Ales Justin [http://community.jboss.org/people/alesj] replied to the discussion "Wildcard support in Dynamic-imports" To view the discussion, visit: http://community.jboss.org/message/547072#547072 -------------------------------------------------------------- > Don't expose the stuff from spi.base - its implementation detail.Add proper helper methods to the stuff in spi. > > Its easy to make things public or protected, but then you'll have people poking around and breaking things. > > All you want to do is add a delegate at runtime, not expose the ugly guts of the classloader! :-) Done. ;-) * http://anonsvn.jboss.org/repos/jbossas/projects/jboss-cl/trunk/classloadi... http://anonsvn.jboss.org/repos/jbossas/projects/jboss-cl/trunk/classloadi... -------------------------------------------------------------- Reply to this message by going to Community [http://community.jboss.org/message/547072#547072] Start a new discussion in JBoss Microcontainer Development at Community [http://community.jboss.org/choose-container!input.jspa?contentType=1&cont...]

15 years, 10 months

1
0
0 / 0

Re: [jboss-dev-forums] [JBoss Microcontainer Development] - Wildcard support in Dynamic-imports

by Adrian Brock

Adrian Brock [http://community.jboss.org/people/warjort] replied to the discussion "Wildcard support in Dynamic-imports" To view the discussion, visit: http://community.jboss.org/message/547070#547070 -------------------------------------------------------------- > Ales Justin wrote: > > > So you need a method (probably on ClassLoaderPolicy) like: > > void addExtraDelegate(DelegateLoader dl); > That's what I did -- the code is already commited. ;-) > But had to "protected" expose getInformation() in BaseClassLoaderPolicy so ClassLoaderPolicy can add the new delegate loader. No, just add it as a public method to BaseClassLoaderPolicy, it will get inherited into ClassLoaderPolicy. Obviously the spi.base.* stuff has to have some public/protected methods otherwise it couldn't be used, but keep whats exposed down to a minimum. :-) -------------------------------------------------------------- Reply to this message by going to Community [http://community.jboss.org/message/547070#547070] Start a new discussion in JBoss Microcontainer Development at Community [http://community.jboss.org/choose-container!input.jspa?contentType=1&cont...]

15 years, 10 months

1
0
0 / 0

Re: [jboss-dev-forums] [JBoss Microcontainer Development] - Wildcard support in Dynamic-imports

by Ales Justin

Ales Justin [http://community.jboss.org/people/alesj] replied to the discussion "Wildcard support in Dynamic-imports" To view the discussion, visit: http://community.jboss.org/message/547069#547069 -------------------------------------------------------------- > But had to "protected" expose getInformation() in BaseClassLoaderPolicy so ClassLoaderPolicy can add the new delegate loader. Eh, fixed this as well, only to expose the add/remove methods, but not the CLInfo itself. -------------------------------------------------------------- Reply to this message by going to Community [http://community.jboss.org/message/547069#547069] Start a new discussion in JBoss Microcontainer Development at Community [http://community.jboss.org/choose-container!input.jspa?contentType=1&cont...]

15 years, 10 months

1
0
0 / 0

Re: [jboss-dev-forums] [JBoss Microcontainer Development] - Wildcard support in Dynamic-imports

by Ales Justin

Ales Justin [http://community.jboss.org/people/alesj] replied to the discussion "Wildcard support in Dynamic-imports" To view the discussion, visit: http://community.jboss.org/message/547068#547068 -------------------------------------------------------------- > So you need a method (probably on ClassLoaderPolicy) like: > void addExtraDelegate(DelegateLoader dl); That's what I did -- the code is already commited. ;-) But had to "protected" expose getInformation() in BaseClassLoaderPolicy so ClassLoaderPolicy can add the new delegate loader. -------------------------------------------------------------- Reply to this message by going to Community [http://community.jboss.org/message/547068#547068] Start a new discussion in JBoss Microcontainer Development at Community [http://community.jboss.org/choose-container!input.jspa?contentType=1&cont...]

15 years, 10 months

1
0
0 / 0

Re: [jboss-dev-forums] [JBoss Microcontainer Development] - Wildcard support in Dynamic-imports

by Adrian Brock

Adrian Brock [http://community.jboss.org/people/warjort] replied to the discussion "Wildcard support in Dynamic-imports" To view the discussion, visit: http://community.jboss.org/message/547066#547066 -------------------------------------------------------------- > Ales Justin wrote: > > > And I have no idea how to hack around this dynamic loader to policy's delegates addition. > This would actually have to be done on CLInfo. > > e.g. > ClassLoaderPolicy policy = getPolicy(); > ClassLoaderInformation info = policy.getInformation(); // exposing this as protected in super, public in CLP > *if* (info != *null*) > info.addDelegate(loader); // new public method > > > > > Adding this hacks makes all previous wildcard tests pass. :-) > > > > Don't expose the stuff from spi.base - its implementation detail. Add proper helper methods to the stuff in spi. Its easy to make things public or protected, but then you'll have people poking around and breaking things. All you want to do is add a delegate at runtime, not expose the ugly guts of the classloader! :-) -------------------------------------------------------------- Reply to this message by going to Community [http://community.jboss.org/message/547066#547066] Start a new discussion in JBoss Microcontainer Development at Community [http://community.jboss.org/choose-container!input.jspa?contentType=1&cont...]

15 years, 10 months

1
0
0 / 0

Re: [jboss-dev-forums] [JBoss Microcontainer Development] - Wildcard support in Dynamic-imports

by Adrian Brock

Adrian Brock [http://community.jboss.org/people/warjort] replied to the discussion "Wildcard support in Dynamic-imports" To view the discussion, visit: http://community.jboss.org/message/547063#547063 -------------------------------------------------------------- > > Or I completely misunderstood your impl? :-) I thought I was just showing your impl from the first post, but putting it in a factory method, I must have got it wrong if you don't understand it? On the delegate loaders, you can't just modify the delegates returned by the policy (you probably dont want to, it would just be something else to tidyup later), its not used after the classloader gets constructed, you want to update the ClassLoaderInformation - this is the optimized view of the policy for runtime. So you need a method (probably on ClassLoaderPolicy) like: void addExtraDelegate(DelegateLoader dl); -------------------------------------------------------------- Reply to this message by going to Community [http://community.jboss.org/message/547063#547063] Start a new discussion in JBoss Microcontainer Development at Community [http://community.jboss.org/choose-container!input.jspa?contentType=1&cont...]

15 years, 10 months

1
0
0 / 0

Re: [jboss-dev-forums] [JBoss Microcontainer Development] - Wildcard support in Dynamic-imports

by Ales Justin

Ales Justin [http://community.jboss.org/people/alesj] replied to the discussion "Wildcard support in Dynamic-imports" To view the discussion, visit: http://community.jboss.org/message/547061#547061 -------------------------------------------------------------- > And I have no idea how to hack around this dynamic loader to policy's delegates addition. This would actually have to be done on CLInfo. e.g. ClassLoaderPolicy policy = getPolicy(); ClassLoaderInformation info = policy.getInformation(); // exposing this as protected in super, public in CLP if (info != null) info.addDelegate(loader); // new public method Adding this hacks makes all previous wildcard tests pass. :-) -------------------------------------------------------------- Reply to this message by going to Community [http://community.jboss.org/message/547061#547061] Start a new discussion in JBoss Microcontainer Development at Community [http://community.jboss.org/choose-container!input.jspa?contentType=1&cont...]

15 years, 10 months

1
0
0 / 0

Re: [jboss-dev-forums] [JBoss Microcontainer Development] - Wildcard support in Dynamic-imports

by Ales Justin

Ales Justin [http://community.jboss.org/people/alesj] replied to the discussion "Wildcard support in Dynamic-imports" To view the discussion, visit: http://community.jboss.org/message/547040#547040 -------------------------------------------------------------- > public class Module { public DelegateLoader resolveWildcard(...) > { > WildcardDelegateLoader result = new WilcardDelegateLoader(...); > return result.resolve(...); // HERE ?? > } > I don't understand the idea behind resolve(). I thought we would simply create a single WildcardDelegateLoader for the whole wildcard requirement, which would then get hit for every not-yet-resolved class/resource lookup. Resulting in creating new DelegateLoader, and adding that to existing delegates -- before our wildcard "creator". e.g. class WildcardDelegateLoader extends FilteredDelegateLoader { ... protected DelegateLoader resolve(String pckg) { Requirement requirement = new PackageRequirement(pckg, range); WildcardRequirementDependencyItem item = new WildcardRequirementDependencyItem(module, requirement, module.getClassLoaderState()); if (item.resolve(controller)) { List<RequirementDependencyItem> items = module.getDependencies(); // should not be null, as this delegate was created from a requirement items.add(item); module.addIDependOn(item); Module resolvedModule = item.getResolvedModule(); if (resolvedModule instanceof ClassLoaderPolicyModule) { ClassLoaderPolicyModule clpm = (ClassLoaderPolicyModule) resolvedModule; DelegateLoader loader = clpm.getDelegateLoader(module, requirement); item.setLoader(loader); ClassLoaderPolicy policy = getPolicy(); // TODO -- add new loader to policy's delegate // pseudo-code -- ??? List<DelegateLoader> delegates = policy.getDelegates(); delegates.add(0, loader); // make sure it's before this wildcard delegate } } return null; } @Override protected Class<?> doLoadClass(String className) { DelegateLoader loader = resolve(ClassLoaderUtils.getClassPackageName(className)); return loader != null ? loader.loadClass(className) : null; } And I have no idea how to hack around this dynamic loader to policy's delegates addition. Or I completely misunderstood your impl? :-) -------------------------------------------------------------- Reply to this message by going to Community [http://community.jboss.org/message/547040#547040] Start a new discussion in JBoss Microcontainer Development at Community [http://community.jboss.org/choose-container!input.jspa?contentType=1&cont...]

15 years, 10 months

1
0
0 / 0

Re: [jboss-dev-forums] [JBoss Microcontainer Development] - Wildcard support in Dynamic-imports

by Adrian Brock

Adrian Brock [http://community.jboss.org/people/warjort] replied to the discussion "Wildcard support in Dynamic-imports" To view the discussion, visit: http://community.jboss.org/message/547030#547030 -------------------------------------------------------------- I said when I first committed jboss-classloading that is was a bad thing that RequirementDependencyItem was in the public spi. It shouldn't really be leaking the MC api through to the user but I couldn't think of an easy way to abstract it. So the spi is already a bit ugly. :-( One way to do it would be to make the class package private in spi and have a factory method on the Module to construct it, I haven't looked at whether this really works? package org.jboss.classloading.spi; */*package private*/* *class* WildcardDelegateLoader *extends* FilteredDelegateLoader and public class Module { public DelegateLoader resolveWildcard(...) { WildcardDelegateLoader result = new WilcardDelegateLoader(...); return result.resolve(...); } } I'm sure you'll find a way to do it? :-) -------------------------------------------------------------- Reply to this message by going to Community [http://community.jboss.org/message/547030#547030] Start a new discussion in JBoss Microcontainer Development at Community [http://community.jboss.org/choose-container!input.jspa?contentType=1&cont...]

15 years, 10 months

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jboss-dev-forums June 2010