10:33 p.m.
JBoss development,
A new message was posted in the thread "JBREFLECT - Exception processing non-public
annotation":
http://community.jboss.org/message/523147#523147
Author : jaikiran pai
Profile : http://community.jboss.org/people/jaikiran
Message:
--------------------------------------------------------------
Pete has reported a failure in CDI testsuite against the AS trunk
https://jira.jboss.org/jira/browse/JBAS-7676. The testcase involves a @Stateless annotated
EJB. Apart from this annotation, the EJB class also has one other annotation. Here's
how the EJB class and its related classes looks like:
package org.jboss.jsr299.tck.tests.definition.qualifier.enterprise;
@Stateless
public class BorderCollie extends LongHairedDog
implements BorderCollieLocal
{
}
package org.jboss.jsr299.tck.tests.definition.qualifier.enterprise;
@Hairy(clipped=false)
class LongHairedDog
{
}
package org.jboss.jsr299.tck.tests.definition.qualifier.enterprise;
@Target({java.lang.annotation.ElementType.TYPE, java.lang.annotation.ElementType.METHOD,
java.lang.annotation.ElementType.PARAMETER, java.lang.annotation.ElementType.FIELD})
...//removed irrelevant stuff
@interface Hairy
{
public abstract boolean clipped();
}
During annotation scanning of this EJB class, it runs into this error, which causes the
EJB metadata of this class to be messed up and the deployment failing:
2010-01-31 00:44:49,980 TRACE
[org.jboss.mcann.repository.GenericAnnotationResourceVisitor] (HDScanner) Scanning class
org.jboss.jsr299.tck.tests.definition.qualifier.enterprise.BorderCollie for annotations
2010-01-31 00:44:49,984 TRACE
[org.jboss.mcann.repository.GenericAnnotationResourceVisitor] (HDScanner) Exception
reading resource:
org/jboss/jsr299/tck/tests/definition/qualifier/enterprise/BorderCollie.class:
java.lang.RuntimeException: Error retrieving annotation attribute values
     at
org.jboss.reflect.plugins.AnnotationValueFactory.createAnnotationValue(AnnotationValueFactory.java:107)
     at
org.jboss.reflect.plugins.introspection.IntrospectionTypeInfoFactoryImpl.createAnnotationValue(IntrospectionTypeInfoFactoryImpl.java:137)
     at
org.jboss.reflect.plugins.introspection.IntrospectionTypeInfoFactoryImpl.getAnnotations(IntrospectionTypeInfoFactoryImpl.java:130)
     at
org.jboss.reflect.plugins.InheritableAnnotationHolder.getDeclaredAnnotations(InheritableAnnotationHolder.java:95)
     at
org.jboss.reflect.plugins.ClassInfoImpl.getAnnotations(ClassInfoImpl.java:179)
     at
org.jboss.reflect.plugins.AbstractAnnotatedInfo.getUnderlyingAnnotations(AbstractAnnotatedInfo.java:63)
     at
org.jboss.mcann.repository.GenericAnnotationResourceVisitor.handleClass(GenericAnnotationResourceVisitor.java:154)
     at
org.jboss.mcann.repository.GenericAnnotationResourceVisitor.visit(GenericAnnotationResourceVisitor.java:91)
     at
org.jboss.classloading.plugins.vfs.VFSResourceVisitor.visit(VFSResourceVisitor.java:263)
     at
org.jboss.virtual.plugins.vfs.helpers.WrappingVirtualFileHandlerVisitor.visit(WrappingVirtualFileHandlerVisitor.java:62)
     at
org.jboss.virtual.plugins.context.AbstractVFSContext.visit(AbstractVFSContext.java:362)
     at
org.jboss.virtual.plugins.context.AbstractVFSContext.visit(AbstractVFSContext.java:374)
     at
org.jboss.virtual.plugins.context.AbstractVFSContext.visit(AbstractVFSContext.java:374)
     at
org.jboss.virtual.plugins.context.AbstractVFSContext.visit(AbstractVFSContext.java:374)
     at
org.jboss.virtual.plugins.context.AbstractVFSContext.visit(AbstractVFSContext.java:374)
     at
org.jboss.virtual.plugins.context.AbstractVFSContext.visit(AbstractVFSContext.java:374)
     at
org.jboss.virtual.plugins.context.AbstractVFSContext.visit(AbstractVFSContext.java:374)
     at
org.jboss.virtual.plugins.context.AbstractVFSContext.visit(AbstractVFSContext.java:374)
     at
org.jboss.virtual.plugins.context.AbstractVFSContext.visit(AbstractVFSContext.java:374)
     at
org.jboss.virtual.plugins.context.AbstractVFSContext.visit(AbstractVFSContext.java:307)
     at
org.jboss.virtual.VFS.visit(VFS.java:438)
     at
org.jboss.virtual.VirtualFile.visit(VirtualFile.java:448)
     at
org.jboss.classloading.plugins.vfs.VFSResourceVisitor.visit(VFSResourceVisitor.java:102)
     at
org.jboss.deployers.vfs.plugins.classloader.VFSDeploymentClassLoaderPolicyModule.visit(VFSDeploymentClassLoaderPolicyModule.java:181)
     at
org.jboss.mcann.scanner.ModuleAnnotationScanner.visit(ModuleAnnotationScanner.java:49)
     at
org.jboss.mcann.scanner.DefaultAnnotationScanner.rescan(DefaultAnnotationScanner.java:70)
     at
org.jboss.mcann.scanner.DefaultAnnotationScanner.rescan(DefaultAnnotationScanner.java:42)
     at
org.jboss.mcann.scanner.AbstractAnnotationScanner.scan(AbstractAnnotationScanner.java:83)
     at
org.jboss.deployers.vfs.plugins.annotations.AnnotationRepositoryDeployer.visitModule(AnnotationRepositoryDeployer.java:104)
     at
org.jboss.deployers.vfs.plugins.annotations.AnnotationRepositoryDeployer.deploy(AnnotationRepositoryDeployer.java:154)
     at
org.jboss.deployers.vfs.plugins.annotations.AnnotationRepositoryDeployer.deploy(AnnotationRepositoryDeployer.java:47)
     at
org.jboss.deployers.vfs.spi.deployer.AbstractOptionalVFSRealDeployer.deploy(AbstractOptionalVFSRealDeployer.java:57)
     at
org.jboss.deployers.spi.deployer.helpers.AbstractOptionalRealDeployer.internalDeploy(AbstractOptionalRealDeployer.java:74)
     at
org.jboss.deployers.spi.deployer.helpers.AbstractRealDeployer.deploy(AbstractRealDeployer.java:55)
     at
org.jboss.deployers.plugins.deployers.DeployerWrapper.deploy(DeployerWrapper.java:179)
     at
org.jboss.deployers.plugins.deployers.DeployersImpl.doDeploy(DeployersImpl.java:1660)
     at
org.jboss.deployers.plugins.deployers.DeployersImpl.doInstallParentFirst(DeployersImpl.java:1378)
     at
org.jboss.deployers.plugins.deployers.DeployersImpl.doInstallParentFirst(DeployersImpl.java:1431)
     at
org.jboss.deployers.plugins.deployers.DeployersImpl.install(DeployersImpl.java:1319)
     at
org.jboss.dependency.plugins.AbstractControllerContext.install(AbstractControllerContext.java:378)
     at
org.jboss.dependency.plugins.AbstractController.install(AbstractController.java:1890)
     at
org.jboss.dependency.plugins.AbstractController.incrementState(AbstractController.java:1019)
     at
org.jboss.dependency.plugins.AbstractController.executeOrIncrementStateDirectly(AbstractController.java:1251)
     at
org.jboss.dependency.plugins.AbstractController.resolveContexts(AbstractController.java:1175)
     at
org.jboss.dependency.plugins.AbstractController.resolveContexts(AbstractController.java:1073)
     at
org.jboss.dependency.plugins.AbstractController.change(AbstractController.java:887)
     at
org.jboss.dependency.plugins.AbstractController.change(AbstractController.java:602)
     at
org.jboss.deployers.plugins.deployers.DeployersImpl.process(DeployersImpl.java:898)
     at
org.jboss.deployers.plugins.main.MainDeployerImpl.process(MainDeployerImpl.java:677)
     at
org.jboss.system.server.profileservice.repository.MainDeployerAdapter.process(MainDeployerAdapter.java:117)
     at
org.jboss.system.server.profileservice.hotdeploy.HDScanner.scan(HDScanner.java:409)
     at
org.jboss.system.server.profileservice.hotdeploy.HDScanner.run(HDScanner.java:294)
     at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
     at
java.util.concurrent.FutureTask$Sync.innerRunAndReset(FutureTask.java:317)
     at
java.util.concurrent.FutureTask.runAndReset(FutureTask.java:150)
     at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:98)
     at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.runPeriodic(ScheduledThreadPoolExecutor.java:181)
     at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:205)
     at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
     at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
     at
java.lang.Thread.run(Thread.java:619)
Caused by: java.lang.IllegalAccessException: Class
org.jboss.reflect.plugins.introspection.ReflectionUtils can not access a member of class
org.jboss.jsr299.tck.tests.definition.qualifier.enterprise.Hairy with modifiers
"public abstract"
     at
sun.reflect.Reflection.ensureMemberAccess(Reflection.java:65)
     at
java.lang.reflect.Method.invoke(Method.java:588)
     at
org.jboss.reflect.plugins.introspection.ReflectionUtils.invoke(ReflectionUtils.java:59)
     at
org.jboss.reflect.plugins.introspection.ReflectMethodInfoImpl.invoke(ReflectMethodInfoImpl.java:151)
     at
org.jboss.reflect.plugins.AnnotationValueFactory.createAnnotationValue(AnnotationValueFactory.java:100)
     ... 60 more
The root cause of this issue seems to be a problem in JBREFLECT, which runs into issue
trying to create annotation value information out of a non-public annotation (notice that
"Hairy" in the above example is non-public).
I was able to reproduce this issue with a simple testcase in JBREFLECT trunk:
Index:
src/test/java/org/jboss/test/classinfo/annotation/test/NonPublicAnnotationTestCase.java
===================================================================
---
src/test/java/org/jboss/test/classinfo/annotation/test/NonPublicAnnotationTestCase.java     (revision
0)
+++
src/test/java/org/jboss/test/classinfo/annotation/test/NonPublicAnnotationTestCase.java     (revision
0)
@@ -0,0 +1,89 @@
+/**
+ *
+ */
+package org.jboss.test.classinfo.annotation.test;
+
+import java.lang.annotation.Annotation;
+
+import junit.framework.Test;
+
+import org.jboss.reflect.plugins.introspection.IntrospectionTypeInfoFactory;
+import org.jboss.reflect.spi.ClassInfo;
+import org.jboss.reflect.spi.TypeInfo;
+import org.jboss.reflect.spi.TypeInfoFactory;
+import org.jboss.test.ContainerTest;
+
+/**
+ * NonPublicAnnotationTestCase
+ *
+ * Tests that a Class annotated with a non-public annotation is
+ * correctly parsed for annotations.
+ *
+ * This test is responsible the testing fix for the bug in JBREFLECT
+ * which causes the following exception:
+ *
+ *
+ * Caused by: java.lang.IllegalAccessException: Class
org.jboss.reflect.plugins.introspection.ReflectionUtils can not access a member of class
org.jboss.test.classinfo.annotation.test.NonPublicAnnotation with modifiers "public
abstract"
+ * at sun.reflect.Reflection.ensureMemberAccess(Reflection.java:65)
+ * at java.lang.reflect.Method.invoke(Method.java:588)
+ * at
org.jboss.reflect.plugins.introspection.ReflectionUtils.invoke(ReflectionUtils.java:59)
+ * at
org.jboss.reflect.plugins.introspection.ReflectMethodInfoImpl.invoke(ReflectMethodInfoImpl.java:151)
+ * at
org.jboss.reflect.plugins.AnnotationValueFactory.createAnnotationValue(AnnotationValueFactory.java:100)
+ * ... 33 more
+ *
+ *
+ * @author Jaikiran Pai
+ * @version $Revision: $
+ */
+public class NonPublicAnnotationTestCase extends ContainerTest
+{
+ /**
+ * Constructor
+ * @param name
+ */
+ public NonPublicAnnotationTestCase(String name)
+ {
+ super(name);
+ }
+
+ public static Test suite()
+ {
+ return suite(NonPublicAnnotationTestCase.class);
+ }
+
+ /**
+ * Test that the {@link NonPublicAnnotation} when applied to {@link
SimpleAnnotatedClass}
+ * is correctly parsed and is available through {@link
ClassInfo#getUnderlyingAnnotations()}
+ *
+ * @throws Exception
+ */
+ public void testNonPublicAnnotationOnClass() throws Exception
+ {
+ ClassInfo info = getClassInfo(SimpleAnnotatedClass.class);
+
+ System.out.println("---> Getting annotations");
+ Annotation[] annotations = info.getUnderlyingAnnotations();
+ assertEquals("Incorrect number of annotations found on " +
SimpleAnnotatedClass.class, 1, annotations.length);
+ Annotation annotation = annotations[0];
+ assertTrue("Incorrect annotation type found on " +
SimpleAnnotatedClass.class, (annotation instanceof NonPublicAnnotation));
+ NonPublicAnnotation expectedAnnotation = (NonPublicAnnotation) annotation;
+ assertEquals("Incorrect value found for annotation " +
NonPublicAnnotation.class
+ + " on class " + SimpleAnnotatedClass.class,
SimpleAnnotatedClass.ANNOTATION_ELEMENT_NAME, expectedAnnotation.name());
+ }
+
+ /**
+ * Utitlity method
+ * @param clazz
+ * @return
+ */
+ protected ClassInfo getClassInfo(Class clazz)
+ {
+ TypeInfoFactory factory = new IntrospectionTypeInfoFactory();
+ TypeInfo info = factory.getTypeInfo(clazz);
+ assertNotNull(info);
+ assertTrue(info instanceof ClassInfo);
+ ClassInfo cinfo = (ClassInfo) info;
+ getLog().debug(cinfo);
+ return cinfo;
+ }
+}
Index: src/test/java/org/jboss/test/classinfo/annotation/test/NonPublicAnnotation.java
===================================================================
---
src/test/java/org/jboss/test/classinfo/annotation/test/NonPublicAnnotation.java     (revision
0)
+++
src/test/java/org/jboss/test/classinfo/annotation/test/NonPublicAnnotation.java     (revision
0)
@@ -0,0 +1,31 @@
+/**
+ *
+ */
+package org.jboss.test.classinfo.annotation.test;
+
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+import java.lang.annotation.Target;
+
+/**
+ * NonPublicAnnotation
+ *
+ * A non-public annotation.
+ *
+ * NOTE: This {@link NonPublicAnnotation}, {@link SimpleAnnotatedClass} and
+ * even the {@link NonPublicAnnotationTestCase} are all placed in the same package
+ * *intentionally*, so that this annotation is accessible for the {@link
SimpleAnnotatedClass}
+ * as well as {@link NonPublicAnnotationTestCase} during the tests.
+ *
+ * @author Jaikiran Pai
+ * @version $Revision: $
+ */
+@Target (ElementType.TYPE)
+@Retention (RetentionPolicy.RUNTIME)
+@interface NonPublicAnnotation {
+
+ public abstract String name();
+
+ public abstract boolean isTest();
+}
Index: src/test/java/org/jboss/test/classinfo/annotation/test/SimpleAnnotatedClass.java
===================================================================
---
src/test/java/org/jboss/test/classinfo/annotation/test/SimpleAnnotatedClass.java     (revision
0)
+++
src/test/java/org/jboss/test/classinfo/annotation/test/SimpleAnnotatedClass.java     (revision
0)
@@ -0,0 +1,25 @@
+/**
+ *
+ */
+package org.jboss.test.classinfo.annotation.test;
+
+
+/**
+ * SimpleAnnotatedClass
+ *
+ * A simple class used in tests
+ *
+ * NOTE: The {@link NonPublicAnnotation}, {@link SimpleAnnotatedClass} and
+ * even the {@link NonPublicAnnotationTestCase} are all placed in the same package
+ * *intentionally*, so that this annotation is accessible for the {@link
SimpleAnnotatedClass}
+ * as well as {@link NonPublicAnnotationTestCase} during the tests.
+ *
+ * @author Jaikiran Pai
+ * @version $Revision: $
+ */
+@NonPublicAnnotation (name=SimpleAnnotatedClass.ANNOTATION_ELEMENT_NAME, isTest=true)
+public class SimpleAnnotatedClass
+{
+
+ public static final String ANNOTATION_ELEMENT_NAME = "SomeName";
+}
The testcase fails with the same exception:
-------------------------------------------------------------------------------
Test set: org.jboss.test.classinfo.annotation.test.NonPublicAnnotationTestCase
-------------------------------------------------------------------------------
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.141 sec <<<
FAILURE!
testNonPublicAnnotationOnClass(org.jboss.test.classinfo.annotation.test.NonPublicAnnotationTestCase)
Time elapsed: 0.066 sec <<< ERROR!
java.lang.RuntimeException: Error retrieving annotation attribute values
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;at
org.jboss.reflect.plugins.AnnotationValueFactory.createAnnotationValue(AnnotationValueFactory.java:107)
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;at
org.jboss.reflect.plugins.introspection.IntrospectionTypeInfoFactoryImpl.createAnnotationValue(IntrospectionTypeInfoFactoryImpl.java:137)
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;at
org.jboss.reflect.plugins.introspection.IntrospectionTypeInfoFactoryImpl.getAnnotations(IntrospectionTypeInfoFactoryImpl.java:130)
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;at
org.jboss.reflect.plugins.InheritableAnnotationHolder.getDeclaredAnnotations(InheritableAnnotationHolder.java:95)
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;at
org.jboss.reflect.plugins.ClassInfoImpl.getAnnotations(ClassInfoImpl.java:179)
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;at
org.jboss.reflect.plugins.AbstractAnnotatedInfo.getUnderlyingAnnotations(AbstractAnnotatedInfo.java:63)
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;at
org.jboss.test.classinfo.annotation.test.NonPublicAnnotationTestCase.testNonPublicAnnotationOnClass(NonPublicAnnotationTestCase.java:65)
...//removed irrelevant stacktrace
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;at
org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1009)
Caused by: java.lang.IllegalAccessException: Class
org.jboss.reflect.plugins.introspection.ReflectionUtils can not access a member of class
org.jboss.test.classinfo.annotation.test.NonPublicAnnotation with modifiers "public
abstract"
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;at
sun.reflect.Reflection.ensureMemberAccess(Reflection.java:65)
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;at
java.lang.reflect.Method.invoke(Method.java:588)
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;at
org.jboss.reflect.plugins.introspection.ReflectionUtils.invoke(ReflectionUtils.java:59)
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;at
org.jboss.reflect.plugins.introspection.ReflectMethodInfoImpl.invoke(ReflectMethodInfoImpl.java:151)
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;at
org.jboss.reflect.plugins.AnnotationValueFactory.createAnnotationValue(AnnotationValueFactory.java:100)
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;... 33 more
Is there a way to disable Java language access check for the methods through JBREFLECT
project? Or does that have to be done (selectively) through the underlying
(ReflectMethodInfoImpl) impl?
--------------------------------------------------------------
To reply to this message visit the message page:
http://community.jboss.org/message/523147#523147