RE: Valdiations in FileCacheLoader
by Galder Zamarreno
Ok, sounds good to me.
Galder Zamarreño
Sr. Software Maintenance Engineer
JBoss, a division of Red Hat
IT executives: Red Hat still #1 for value http://www.redhat.com/promo/vendor/
-----Original Message-----
From: Brian Stansberry
Sent: 23 November 2006 16:32
To: Galder Zamarreno
Cc: 'jbosscache-dev(a)lists.jboss.org'
Subject: RE: Valdiations in FileCacheLoader
No and yes. No because not testing immutability is the same as making it mutable, which is what you're doing anyway.
Yes, because testing immutability is the standard pattern that should be followed. @Dynamic causes it to pass. I guess the advantage of this approach is if good style is used and all fields are declared together, it's easy to see which are mutable.
Galder Zamarreno wrote:
> Set/get methods implemented :-)
>
> Will put @Dynamic. Even if I put this tag, do I need to still
> test immutability in the setter?
>
> Galder Zamarreño
> Sr. Software Maintenance Engineer
> JBoss, a division of Red Hat
>
> IT executives: Red Hat still #1 for value
> http://www.redhat.com/promo/vendor/
>
> -----Original Message-----
> From: Brian Stansberry
> Sent: 23 November 2006 16:17
> To: Galder Zamarreno
> Cc: 'jbosscache-dev(a)lists.jboss.org'
> Subject: RE: Valdiations in FileCacheLoader
>
> Be sure to use get/setCheckCharacterPortability() in
> FileCacheLoaderConfig as the primary mechanism for
> storing/retrieving this property. Make the field @Dynamic,
> as there is no reason this can't be changed on a running cache.
>
> Galder Zamarreno wrote:
>> 1) I'm adding a switch in the properties section. I think default
>> value should be true having the possibility to switch it off by
>> setting "check.character.portability" property to false.
>>
>> 2) done
>>
>> Galder Zamarreño
>> Sr. Software Maintenance Engineer
>> JBoss, a division of Red Hat
>>
>> IT executives: Red Hat still #1 for value
>> http://www.redhat.com/promo/vendor/
>>
>> -----Original Message-----
>> From: Brian Stansberry
>> Sent: 20 November 2006 20:58
>> To: Galder Zamarreno
>> Cc: jbosscache-dev(a)lists.jboss.org
>> Subject: Valdiations in FileCacheLoader
>>
>> Hey Galder,
>>
>> Couple thoughts on the validation stuff in FileCacheLoader:
>>
>> 1) How about adding an on/off switch to FileCacheLoaderConfig? If I
>> know my stuff conforms, I don't want to pay the performance penalty
>> to check it. 2) I believe Pattern is thread safe, so you should be
>> able to cache your compiled patterns in a static field.
>>
18 years
RE: Valdiations in FileCacheLoader
by Brian Stansberry
No and yes. No because not testing immutability is the same as making it mutable, which is what you're doing anyway.
Yes, because testing immutability is the standard pattern that should be followed. @Dynamic causes it to pass. I guess the advantage of this approach is if good style is used and all fields are declared together, it's easy to see which are mutable.
Galder Zamarreno wrote:
> Set/get methods implemented :-)
>
> Will put @Dynamic. Even if I put this tag, do I need to still
> test immutability in the setter?
>
> Galder Zamarreño
> Sr. Software Maintenance Engineer
> JBoss, a division of Red Hat
>
> IT executives: Red Hat still #1 for value
> http://www.redhat.com/promo/vendor/
>
> -----Original Message-----
> From: Brian Stansberry
> Sent: 23 November 2006 16:17
> To: Galder Zamarreno
> Cc: 'jbosscache-dev(a)lists.jboss.org'
> Subject: RE: Valdiations in FileCacheLoader
>
> Be sure to use get/setCheckCharacterPortability() in
> FileCacheLoaderConfig as the primary mechanism for
> storing/retrieving this property. Make the field @Dynamic,
> as there is no reason this can't be changed on a running cache.
>
> Galder Zamarreno wrote:
>> 1) I'm adding a switch in the properties section. I think default
>> value should be true having the possibility to switch it off by
>> setting "check.character.portability" property to false.
>>
>> 2) done
>>
>> Galder Zamarreño
>> Sr. Software Maintenance Engineer
>> JBoss, a division of Red Hat
>>
>> IT executives: Red Hat still #1 for value
>> http://www.redhat.com/promo/vendor/
>>
>> -----Original Message-----
>> From: Brian Stansberry
>> Sent: 20 November 2006 20:58
>> To: Galder Zamarreno
>> Cc: jbosscache-dev(a)lists.jboss.org
>> Subject: Valdiations in FileCacheLoader
>>
>> Hey Galder,
>>
>> Couple thoughts on the validation stuff in FileCacheLoader:
>>
>> 1) How about adding an on/off switch to FileCacheLoaderConfig? If I
>> know my stuff conforms, I don't want to pay the performance penalty
>> to check it. 2) I believe Pattern is thread safe, so you should be
>> able to cache your compiled patterns in a static field.
>>
18 years
RE: Valdiations in FileCacheLoader
by Galder Zamarreno
Set/get methods implemented :-)
Will put @Dynamic. Even if I put this tag, do I need to still test immutability in the setter?
Galder Zamarreño
Sr. Software Maintenance Engineer
JBoss, a division of Red Hat
IT executives: Red Hat still #1 for value http://www.redhat.com/promo/vendor/
-----Original Message-----
From: Brian Stansberry
Sent: 23 November 2006 16:17
To: Galder Zamarreno
Cc: 'jbosscache-dev(a)lists.jboss.org'
Subject: RE: Valdiations in FileCacheLoader
Be sure to use get/setCheckCharacterPortability() in FileCacheLoaderConfig as the primary mechanism for storing/retrieving this property. Make the field @Dynamic, as there is no reason this can't be changed on a running cache.
Galder Zamarreno wrote:
> 1) I'm adding a switch in the properties section. I think
> default value should be true having the possibility to switch
> it off by setting "check.character.portability" property to false.
>
> 2) done
>
> Galder Zamarreño
> Sr. Software Maintenance Engineer
> JBoss, a division of Red Hat
>
> IT executives: Red Hat still #1 for value
> http://www.redhat.com/promo/vendor/
>
> -----Original Message-----
> From: Brian Stansberry
> Sent: 20 November 2006 20:58
> To: Galder Zamarreno
> Cc: jbosscache-dev(a)lists.jboss.org
> Subject: Valdiations in FileCacheLoader
>
> Hey Galder,
>
> Couple thoughts on the validation stuff in FileCacheLoader:
>
> 1) How about adding an on/off switch to
> FileCacheLoaderConfig? If I know my stuff conforms, I don't
> want to pay the performance penalty to check it.
> 2) I believe Pattern is thread safe, so you should be able to
> cache your compiled patterns in a static field.
>
> Brian Stansberry
> Lead, AS Clustering
> JBoss, a division of Red Hat
> Ph: 510-396-3864
> skype: bstansberry
>
> IT executives: Red Hat still #1 for value
> http://www.redhat.com/promo/vendor/
Brian Stansberry
Lead, AS Clustering
JBoss, a division of Red Hat
Ph: 510-396-3864
skype: bstansberry
IT executives: Red Hat still #1 for value
http://www.redhat.com/promo/vendor/
18 years
RE: Valdiations in FileCacheLoader
by Brian Stansberry
Be sure to use get/setCheckCharacterPortability() in FileCacheLoaderConfig as the primary mechanism for storing/retrieving this property. Make the field @Dynamic, as there is no reason this can't be changed on a running cache.
Galder Zamarreno wrote:
> 1) I'm adding a switch in the properties section. I think
> default value should be true having the possibility to switch
> it off by setting "check.character.portability" property to false.
>
> 2) done
>
> Galder Zamarreño
> Sr. Software Maintenance Engineer
> JBoss, a division of Red Hat
>
> IT executives: Red Hat still #1 for value
> http://www.redhat.com/promo/vendor/
>
> -----Original Message-----
> From: Brian Stansberry
> Sent: 20 November 2006 20:58
> To: Galder Zamarreno
> Cc: jbosscache-dev(a)lists.jboss.org
> Subject: Valdiations in FileCacheLoader
>
> Hey Galder,
>
> Couple thoughts on the validation stuff in FileCacheLoader:
>
> 1) How about adding an on/off switch to
> FileCacheLoaderConfig? If I know my stuff conforms, I don't
> want to pay the performance penalty to check it.
> 2) I believe Pattern is thread safe, so you should be able to
> cache your compiled patterns in a static field.
>
> Brian Stansberry
> Lead, AS Clustering
> JBoss, a division of Red Hat
> Ph: 510-396-3864
> skype: bstansberry
>
> IT executives: Red Hat still #1 for value
> http://www.redhat.com/promo/vendor/
Brian Stansberry
Lead, AS Clustering
JBoss, a division of Red Hat
Ph: 510-396-3864
skype: bstansberry
IT executives: Red Hat still #1 for value
http://www.redhat.com/promo/vendor/
18 years
RE: Valdiations in FileCacheLoader
by Galder Zamarreno
1) I'm adding a switch in the properties section. I think default value should be true having the possibility to switch it off by setting "check.character.portability" property to false.
2) done
Galder Zamarreño
Sr. Software Maintenance Engineer
JBoss, a division of Red Hat
IT executives: Red Hat still #1 for value http://www.redhat.com/promo/vendor/
-----Original Message-----
From: Brian Stansberry
Sent: 20 November 2006 20:58
To: Galder Zamarreno
Cc: jbosscache-dev(a)lists.jboss.org
Subject: Valdiations in FileCacheLoader
Hey Galder,
Couple thoughts on the validation stuff in FileCacheLoader:
1) How about adding an on/off switch to FileCacheLoaderConfig? If I know my stuff conforms, I don't want to pay the performance penalty to check it.
2) I believe Pattern is thread safe, so you should be able to cache your compiled patterns in a static field.
Brian Stansberry
Lead, AS Clustering
JBoss, a division of Red Hat
Ph: 510-396-3864
skype: bstansberry
IT executives: Red Hat still #1 for value http://www.redhat.com/promo/vendor/
18 years
Perf tuning for JBoss Cache
by Manik Surtani
Guys,
Every time we see or suspect potential inefficiencies in the JBoss
Cache codebase (stuff we spot while working on other features or
debugging stuff) we should note these down so they can be revisited
later.
At some point I do want to do a full performance analysis as well,
but for the time being this could be useful to capture stuff we see
as we go along.
http://wiki.jboss.org/wiki/Wiki.jsp?page=JBossCachePerfAnalysis
Cheers,
--
Manik Surtani
Lead, JBoss Cache
JBoss, a division of Red Hat
Email: manik(a)jboss.org
Telephone: +44 7786 702 706
MSN: manik(a)surtani.org
Yahoo/AIM/Skype: maniksurtani
18 years
Valdiations in FileCacheLoader
by Brian Stansberry
Hey Galder,
Couple thoughts on the validation stuff in FileCacheLoader:
1) How about adding an on/off switch to FileCacheLoaderConfig? If I know
my stuff conforms, I don't want to pay the performance penalty to check
it.
2) I believe Pattern is thread safe, so you should be able to cache your
compiled patterns in a static field.
Brian Stansberry
Lead, AS Clustering
JBoss, a division of Red Hat
Ph: 510-396-3864
skype: bstansberry
IT executives: Red Hat still #1 for value
http://www.redhat.com/promo/vendor/
18 years
JBCACHE-867
by Elias Ross
I finished most of getting rid of the TreeCacheProxyImpl references. It took
more time than anticipated.
All said, it was about 1800 lines of adds and 2000 lines of removes.
TreeNode and DataNode are pretty empty. There's now a NodeSPI which might
need some work, but it's pretty pleasant. I also refactored out a lot of
lock stuff into something that hangs off of NodeSPI.
Some tests may have been messed up (buddy replication and the move feature
and probably some others) and I haven't had time to figure these complicated
ones out. I hope this doesn't upset anybody. If somebody could help fix
these, that would be great.
I would like to suggest the following things:
1. Cache should not implement Node, it's confusing when reading an
implementation of Cache
2. Node sould include useful methods of TreeNode, such as getChild(Object)
and getName()
3. Cache should have a getCacheSPI()
4. CacheSPI should not extend Cache
5. Cache needs move(), not Node. The reason is clear if you see NodeImpl.
In the current design, CacheSPI has to have all the methods of Cache. Why
couldn't CacheSPI be written as a separate object? (It could, but then you
would just have to delegate ...)
____________________________________________________________________________________
Sponsored Link
Mortgage rates near 39yr lows.
$510k for $1,698/mo. Calculate new payment!
www.LowerMyBills.com/lre
18 years
Blog on JBoss Cache 2.0.0.ALPHA1
by Manik Surtani
Goddamn crazy-ass long URLs. :S
http://labs.jboss.com/portal/index.html?
ctrl:cmd=render&ctrl:window=default.blog.PrjBlogPortletWindowDefaultBlog
&project=jbosscache&from=1&link=JBoss_Cache_2.0.0.ALPHA1_released#JBoss_
Cache_2.0.0.ALPHA1_released
--
Manik Surtani
Lead, JBoss Cache
JBoss, a division of Red Hat
Email: manik(a)jboss.org
Telephone: +44 7786 702 706
MSN: manik(a)surtani.org
Yahoo/AIM/Skype: maniksurtani
18 years
