Can't determine the problem from your posting. Maybe make a self contained unit test, like in MiscTest, so we can see the problem. https://github.com/droolsjbpm/drools/blob/master/drools-compiler/src/test... Mark On 05/01/2012 00:07, ronalbury wrote: > I hardly got any viewers (and no responses) when I posted this just as "MVEL > Optimization" ... so I have changed the subject and re-posted (my apologies > if I just broke protocol). > > > I'm not sure how to explain this, other than it appears that MVEL is trying > to optimize the When conditions in my rules. > > I have a utility class, Test, with a number of methods on it (including null > protected versions of Drools "in" and "matches").  Note that the valueInList > method can return null (e.g. if the product code is null), and the > getAgeAsInt method can also return null (if the age is null).  I don't like > having to test if the result of the method is true, but I kept running into > null pointer errors in the Drools expression evaluation code and had to > adopt this convention. > > Here are two example rules (one in Java dialect and one in MVEL dialect).  I > realize that a list of one is a degenerate case for using 'inList', but it > should still work. > > rule "Term 15Plus Max Age - Washington" >          dialect "java" >          when >                  $ea : EasyApp( >                          Test.valueInList($ea.getEaProductCode(), > "L15P")==true >                      &&  Test.valueInList($ea.getEaIssueState(), "WA")==true >                      &&  $ea.getPriIns_xmPerson().getAgeAsInt()>  65 >                      ) >          then >                  $ea.addError(drools.getRule().getName()); > end > > rule "Term 20 Max Age - New Jersey" >          when >                  $ea : EasyApp( >                          Test.valueInList(eaProductCode, "L20")==true >                      &&  Test.valueInList(eaIssueState, "NJ")==true >                      &&  priIns_xmPerson.ageAsInt>  64 >                      ) >          then >                  $ea.addError(drools.getRule().getName()); > end > > I have approximately 30 different rules similar to those above.  When I have > the rules written in MVEL, it appears to be only be evaluating one rule per > EasyApp injection (I have a log message when ever valueInList is called), > and I get bogus results.  However, when I shift to java dialect then it > appears that the methods are called for each rule I have defined (as I would > have expected). > > Can anyone tell me if I am doing something wrong, and explain why Drools is > behaving as it is? > > Thanks > > -- > View this message in context: http://drools.46999.n3.nabble.com/Error-in-MVEL-execution-optimization-tp... > Sent from the Drools: User forum mailing list archive at Nabble.com. > _______________________________________________ > rules-users mailing list > rules-users(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/rules-users _______________________________________________ rules-users mailing list rules-users(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/rules-users

Here is a very simple test. Note that utilMethod is called twice for the first rule, but is never called for the other two rules. If you convert to Java dialect then things execute as expected. TestRules.drl: #created on: Jan 5, 2012 package com.sample import com.sample.TestUtility; rule "First Rule" when $tf : TestFact(TestUtility.utilMethod(s, "Value1") == true && i > 0 ) then System.out.println("First Rule Fires"); end rule "Second Rule" when $tf : TestFact(TestUtility.utilMethod(s, "Value2") == true && i > 0 ) then System.out.println("Second Rule Fires"); end rule "Third Rule" when $tf : TestFact(TestUtility.utilMethod(s, "Value3") == true && i > 0 ) then System.out.println("Third Rule Fires"); end TestUtility.java: package com.sample; public class TestUtility { public static Boolean utilMethod(String s1, String s2) { Boolean result = null; if (s1 != null) { result = s1.equals(s2); } System.out.println("in utilMethod >" + s1 + "< >" + s2 + "< returns " + result); return result; } } TestDriver.java: public static final void main(String[] args) { try { // load up the knowledge base KnowledgeBase kbase = readKnowledgeBase(); StatefulKnowledgeSession ksession = kbase.newStatefulKnowledgeSession(); // setup the debug listeners ksession.addEventListener(new DebugAgendaEventListener()); ksession.addEventListener(new DebugWorkingMemoryEventListener()); KnowledgeRuntimeLogger logger = KnowledgeRuntimeLoggerFactory.newFileLogger(ksession, "test"); // go ! TestFact fact = new TestFact(); fact.setS("asdf"); fact.setI(10); ksession.insert(fact); ksession.fireAllRules(); logger.close(); } catch (Throwable t) { t.printStackTrace(); } } Output: in utilMethod >asdf< >Value1< returns false in utilMethod >asdf< >Value1< returns false ==>[ObjectInsertedEventImpl: getFactHandle()=[fact 0:1:31556811:31556811:1:DEFAULT:com.sample.TestFact@1e184cb], getObject()=com.sample.TestFact@1e184cb, getKnowledgeRuntime()=org.drools.impl.StatefulKnowledgeSessionImpl@70610a, getPropagationContext()=PropagationContextImpl [activeActivations=0, dormantActivations=0, entryPoint=EntryPoint::DEFAULT, factHandle=[fact 0:1:31556811:31556811:1:DEFAULT:com.sample.TestFact@1e184cb], leftTuple=null, originOffset=-1, propagationNumber=3, rule=null, type=0]] -- View this message in context: http://drools.46999.n3.nabble.com/Error-in-MVEL-execution-optimization-tp... Sent from the Drools: User forum mailing list archive at Nabble.com. _______________________________________________ rules-users mailing list rules-users(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/rules-users

I'm running Drools 5.2. Any idea why Drools is bailing after the first rule for me?

Here is my output when I change to Java dialect: in utilMethod >asdf< >Value1< returns false in utilMethod >asdf< >Value2< returns false in utilMethod >asdf< >Value3< returns false ==>[ObjectInsertedEventImpl: getFactHandle()=[fact 0:1:15245345:15245345:1:DEFAULT:com.sample.TestFact@e8a021], getObject()=com.sample.TestFact@e8a021, getKnowledgeRuntime()=org.drools.impl.StatefulKnowledgeSessionImpl@1797795 , getPropagationContext()=PropagationContextImpl [activeActivations=0, dormantActivations=0, entryPoint=EntryPoint::DEFAULT, factHandle=[fact 0:1:15245345:15245345:1:DEFAULT:com.sample.TestFact@e8a021], leftTuple=null, originOffset=-1, propagationNumber=3, rule=null, type=0]] -- View this message in context: http://drools.46999.n3.nabble.com/Error-in-MVEL-execution-optimization-tp... Sent from the Drools: User forum mailing list archive at Nabble.com. _______________________________________________ rules-users mailing list rules-users(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/rules-users

Its working with the Java dialect (all three rules), but it bails after the first rule with MVEL dialect (see earlier post). The only change on my part is the dialect. -- View this message in context: http://drools.46999.n3.nabble.com/Error-in-MVEL-execution-optimization-tp... Sent from the Drools: User forum mailing list archive at Nabble.com. _______________________________________________ rules-users mailing list rules-users(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/rules-users

Mark: I know what Jira is ... but I don't know what you mean by a pull request ... I also don't have it set up as a JUnit test. -- View this message in context: http://drools.46999.n3.nabble.com/Error-in-MVEL-execution-optimization-tp... Sent from the Drools: User forum mailing list archive at Nabble.com. _______________________________________________ rules-users mailing list rules-users(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/rules-users