Re: [hibernate-dev] "rebranding" the Hibernate Search "ram" directory
I'd name this directory 'Buster', after the most important (non-human)
supporting character from the show Myth Busters.
Buster is a crash test dummy that takes damage with a dumb smile on his
face, much like our ram dir.
It's most prominent feature is that it forgets everything until next
run, because it is dumb. That's very important to simplify test
cleanup. filesystem dir needs a bit of cleanup to avoid issues with
spurious query results from index leftovers from previous crashed builds.
Not sure about making it a test jar. I vaguely remember being used for
testing also in infinispan server, not just embedded mode. In server
mode it is deployed using the wonderful modules system. Can we make a
jboss-module out of a test jar? Most probably yes, but would be a bit
awkward. Or we could just revise those tests to use a real index manager.
On 05/18/2017 10:22 PM, Gunnar Morling wrote:
I'd argue you can keep the name, if it's in the test JAR. If
people
still use it in their production code, well...
Otherwise, how about "ephemeral"?
2017-05-18 19:05 GMT+02:00 Sanne Grinovero <sanne(a)hibernate.org>:
> On 18 May 2017 at 17:31, Gunnar Morling <gunnar.morling(a)googlemail.com> wrote:
>> Can't you just move it to the test JAR if it's for testing only?
> Interesting idea, we can try that as well.
>
> I'd still want to set the name straight though. Let's agree on a name first.
>
>> Am 18.05.2017 6:29 nachm. schrieb "Sanne Grinovero"
<sanne(a)hibernate.org>:
>>
>> Right technically it's not a unit test. But I'd like to focus on the
>> testing aspect, as "local-ram" might still convey concepts as
"fast",
>> maybe even expect it to engage Infinispan's off-heap capabilities, or
>> just being an option to consider for other reasons.
>>
>> "testing" ?
>>
>> On 18 May 2017 at 17:20, Adrian Nistor <anistor(a)redhat.com> wrote:
>>> I agree, but probably "unit-testing" is not such a good name
either.
>>> Technically, that's a functional test.
>>> I think I like "local-ram" better, implying that it is not
>>> shared/distributed and it is also volatile.
>>>
>>>
>>> On 05/18/2017 06:07 PM, Sanne Grinovero wrote:
>>>> As anyone who's bothered to read the manual knows, the
"ram" directory
>>>> should really only be used for unit tests. The other implementations,
>>>> while typically disk based, are also faster (memory mapped files) and
>>>> more efficient (better locking design) so there's really no reason
to
>>>> use it, not even performance except for trivial, small, non important
>>>> data sets.
>>>>
>>>> For example the Elasticsearch team is making sure of this by having
>>>> totally removed the option of using the RAMDirectory - something I
>>>> actually don't appreciate as our unit tests could benefit from it,
>>>> having slow storage on our test environments.
>>>>
>>>> Tristan is reporting that the "ram" terminology is confusing
people,
>>>> not least in the Infinispan community as "RAM" might be
ambiguous
>>>> since everything is in memory, and people get surprised it's not
>>>> replicated in the "in memory cluster".
>>>>
>>>> I wouldn't want to go to the extremes of the Elasticsearch team as I
>>>> believe having this option is very useful, especially for testing.
>>>>
>>>> Should we rename (rebrand) its short name "ram" into
"unit-testing" ?
>>>>
>>>> I suspect that would make people think a bit more before pushing it
>>>> into production...
>>>>
>>>>
>>>> Thanks,
>>>> Sanne
>>>
>>>
>> _______________________________________________
>> hibernate-dev mailing list
>> hibernate-dev(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>>
>>