| // This block has been disabled because this method can be called from
| // the Netty I/O thread.
| // TODO Netty should be improved to provide a way to determine
| // if the current code is running in the I/O thread.
| //
| // if (channel.getParent() == null) {
| // // A client channel - wait until everything is cleaned up.
| // // TODO Do not spin - use signal.
| // MessagingChannelHandler handler = (MessagingChannelHandler) channel.getPipeline().get("handler");
| // while (handler.active) {
| // Thread.yield();
| // }
| // }
|
Does anyone (trustin?) know if the comment still applies? Does netty need to be changed? can the comment be deleted? etc
View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4199858#4199858
Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4199858
How about a variation on the caching approach?
The old caching approach that we discounted involved evaluating the routing address against all wildcards once to get the matching list, then caching the list for subsequent lookups.
The problem with the approach was that if a new match was added you had to invalidate the cache, so the next lookup would re-evaluate all matches. If a lot of new queues were being added frequently (as is often the case), then this would cause a lot of re-evaluation and slowness.
We could be a bit cleverer, and not invalidate the entire cache very time a new wildcard queue is added, but just evaluate the new match and add it to the cache.
If a match is removed from the post office then we could just look in the cache for each routing address and remove it from there.
View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4199836#4199836
Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4199836
"clebert.suconic(a)jboss.com" wrote : anonymous wrote : The paging files could also be broken by crashes, it's no different.
|
| It is different... we have put a lot of effort in making the Journal transactional, validating the health of records.. and etc...
|
| If we start having a file per address it's better, but once a destination gets on page-mode, you will have that file on disk until someome manually delete it.
|
Reaper thread.
View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4199824#4199824
Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4199824
Howard, I think you need to add a test somehow you have destinations deployed in only one node (without any messages), and failover with other destinations deployed on both nodes.
You need to validate the test in two cases.
- destinations only deployed in one node, but no messages on them.
- destinations only deployed in one node, but with messages on them
on both cases you need a second destination with messages on both nodes. The failover on that second destination shouldn't be affected.
View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4199812#4199812
Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4199812
anonymous wrote : The paging files could also be broken by crashes, it's no different.
It is different... we have put a lot of effort in making the Journal transactional, validating the health of records.. and etc...
If we start having a file per address it's better, but once a destination gets on page-mode, you will have that file on disk until someome manually delete it.
Think about if a temporary destination gets in page mode. What will remove that file?
View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4199806#4199806
Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4199806