[Design the new POJO MicroContainer] - Re: VFS3 - missing features and other issues
by jason.greene@jboss.com
"david.lloyd(a)jboss.com" wrote : "alesj" wrote : "david.lloyd(a)jboss.com" wrote :
| | | AssembledDirectory shouldn't be needed anymore with the new design (there is only one view of the VFS and that's the fully assembled view).
| | |
| | | MemoryFileFactory should be replaced with an alternative API... right now it all needs to be explicit (make a temp dir, mount the temp dir in the real VFS, and use getPhysicalFile() to make modifications). I think a static method might be a good idea to do this automatically though.
| | |
| | I only need this API for back-compatibility.
| | How it's implemented in the back, I don't care.
| | But not having this would mean huge changes to MC testing,
| | as a lot CL, Deployers, WB, ... tests depends on it.
| |
| | You can definitely deprecate it, and write better suited API to the new VFS API.
|
| If you want to add it back in, be my guest - it just means putting off the same work until later though. Except then it will probably be even more difficult since more time will pass allowing the API to become even more entrenched. We intended to change or remove the tests (some of the tests seem to exist only to test this feature; it would be strange to add the feature just to make those tests work). As for the other stuff, the temp file API needs to be fixed up a bit to allow for those components to be ported (remember that this is an unfinished prototype). I think the quick/easy fix would be a mistake here.
Well, lets see how porting the main VFS testsuite goes, then look at the impact of the other usages. We definitely don't want to lose valid test scenarios. An auto-mount capability, or at least some utility class that does mount everything in advance would not be a bad thing for tests which verify scenarios that happen after the deployers would mount anyway. We do need to make sure that we are actually testing the way AS uses (or will use) the VFS, else the tests aren't that helpful.
View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4246516#4246516
Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4246516
14 years, 9 months